lp:~mikemc/ubuntu-sso-client/fix-1003692

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ubuntu-sso-client at revision 962

Manuel de la Peña (community): Approve on 2012-05-25

Alejandro J. Cura (community): Approve on 2012-05-24

Diff: 169 lines (+48/-93)

2 files modified

ubuntu_sso/networkstate/linux.py (+4/-1)
ubuntu_sso/networkstate/tests/test_linux.py (+44/-92)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1003692: ubuntu-sso-login-qt crashed with TypeError in got_state()

Undecided

Fix Released

Link a bug report

Related blueprints

962. By Mike McCracken on 2012-05-24

change test for NM_STATE_UNKNOWN to match code -> code says if it's not connected or connecting, it's OFFLINE

961. By Mike McCracken on 2012-05-24

add tests for NetworkManagerState getting previously untested NM_* status values.

960. By Mike McCracken on 2012-05-24

Fix got_state inside is_machine_connected to compare against ONLINE
instead of list of ints.

Remove tests of is_machine_connected that tested calling its got_state
callback with many permutations of NM_STATE_*. That callback is only
ever called with ONLINE/OFFLINE/UNKNOWN, so those tests were wrong.

Change test of incorrect argument to test passing an int. That test
tests that we'll get an exception if we do what caused bug 1003692.

959. By Mike McCracken on 2012-05-24

add tests to reproduce bug 1003692

958. By Mike McCracken on 2012-05-23

- Fix test scripts for linux and windows to avoid running darwin tests

957. By Manuel de la Peña on 2012-05-21

- Moved the code out to a function so that it can be called from other projects (LP: #1002307).

956. By Manuel de la Peña on 2012-05-18

Added support for domain sockets in the tcpactivation and the ipc on darwin which removed the need of using random ports (LP: #984665).

955. By Diego Sarmentero on 2012-05-14

- Fixed: Check network connection when the wizard starts (LP: 996025)

954. By Roberto Alsina on 2012-05-09

 - Enable -testability option through the TESTABILITY environment variable (Fixes LP:984964).

953. By Natalia Bidart on 2012-05-04

- Made the service use the Qt UI if available, and if no UI is installed, propagate a decent error instead of AssertionError (LP: #994632).