Merge lp:~mihirsoni/ubuntu-calendar-app/fix-1464556 into lp:ubuntu-calendar-app

Proposed by Mihir Soni
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 670
Merged at revision: 672
Proposed branch: lp:~mihirsoni/ubuntu-calendar-app/fix-1464556
Merge into: lp:ubuntu-calendar-app
Diff against target: 14 lines (+3/-0)
1 file modified
NewEvent.qml (+3/-0)
To merge this branch: bzr merge lp:~mihirsoni/ubuntu-calendar-app/fix-1464556
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+262248@code.launchpad.net

Commit message

Description of the change

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Looks good! Thanks Mihir!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NewEvent.qml'
--- NewEvent.qml 2015-05-22 12:25:24 +0000
+++ NewEvent.qml 2015-06-17 16:33:49 +0000
@@ -616,7 +616,10 @@
616 return reminderModel.get(i).label616 return reminderModel.get(i).label
617 }617 }
618 }618 }
619 } else {
620 return reminderModel.get(0).label
619 }621 }
622
620 }623 }
621624
622 onClicked: pageStack.push(Qt.resolvedUrl("EventReminder.qml"),625 onClicked: pageStack.push(Qt.resolvedUrl("EventReminder.qml"),

Subscribers

People subscribed via source and target branches

to status/vote changes: