Code review comment for lp:~mihirsoni/ubuntu-calendar-app/editEvent

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

61 - pageStack.pop();
62 + if(isEdit)
63 + pageStack.push(Qt.resolvedUrl("EventDetails.qml"),{"event":event});
64 + else
65 + pageStack.pop();

You dont need to push EventDetails page again.

62 + if(isEdit)
63 + pageStack.push(Qt.resolvedUrl("EventDetails.qml"),{"event":event});

In any case we need to pop current page to go back to original page. so this modification is not necessary,

review: Needs Fixing

« Back to merge proposal