Code review comment for lp:~mihirsoni/ubuntu-calendar-app/1280598

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

> > Mihir,
> >
> > I think we need something like the following before the translation of the
> > date string:
> >
> > // TRANSLATORS: this is a time formatting string,
> > // see http://qt-project.org/doc/qt-5.0/qtqml/qml-
> > qtquick2-date.html#details for valid expressions
>
> Hi Victor.
>
> I have already followed that for expressions, the link which is there is dead
> , so here is new link for your reference :-
> http://qt-project.org/doc/qt-5/qml-qtqml-date.html#toLocaleDateString-method

Victor is asking you to put below comment

 // TRANSLATORS: this is a time formatting string,
 // see http://qt-project.org/doc/qt-5.0/qtqml/qml-qtquick2-date.html#details for valid expressions

before following statements

8 +
9 + var dateFormat = i18n.tr("dd-MMM-yyyy")
10 + eventDate.value = e.startDateTime.toLocaleString(Qt.locale(),dateFormat);

to help translators, where for look for format.

« Back to merge proposal