Merge lp:~midori/midori/win32-enable-profiles into lp:midori

Proposed by Paweł Forysiuk
Status: Merged
Approved by: Cris Dywan
Approved revision: 7031
Merged at revision: 7032
Proposed branch: lp:~midori/midori/win32-enable-profiles
Merge into: lp:midori
Diff against target: 32 lines (+0/-6)
1 file modified
extensions/apps.vala (+0/-6)
To merge this branch: bzr merge lp:~midori/midori/win32-enable-profiles
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+269575@code.launchpad.net

Commit message

Enable browser profiles on win32 as the work sans auto update

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Looks sensible - but let's remember to investigate the refreshing issue.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'extensions/apps.vala'
--- extensions/apps.vala 2015-04-18 20:04:40 +0000
+++ extensions/apps.vala 2015-08-30 10:55:27 +0000
@@ -205,8 +205,6 @@
205 if (toolbar == null) {205 if (toolbar == null) {
206 toolbar = new Gtk.Toolbar ();206 toolbar = new Gtk.Toolbar ();
207207
208#if !HAVE_WIN32
209 /* FIXME: Profiles are broken on win32 because of no multi instance support */
210 var profile = new Gtk.ToolButton.from_stock (Gtk.STOCK_ADD);208 var profile = new Gtk.ToolButton.from_stock (Gtk.STOCK_ADD);
211 profile.label = _("New _Profile");209 profile.label = _("New _Profile");
212 profile.tooltip_text = _("Creates a new, independent profile and a launcher");210 profile.tooltip_text = _("Creates a new, independent profile and a launcher");
@@ -217,7 +215,6 @@
217 Launcher.create_profile.begin (this);215 Launcher.create_profile.begin (this);
218 });216 });
219 toolbar.insert (profile, -1);217 toolbar.insert (profile, -1);
220#endif
221218
222 var app = new Gtk.ToolButton.from_stock (Gtk.STOCK_ADD);219 var app = new Gtk.ToolButton.from_stock (Gtk.STOCK_ADD);
223 app.label = _("New _App");220 app.label = _("New _App");
@@ -480,11 +477,8 @@
480 monitors = new GLib.List<GLib.FileMonitor> ();477 monitors = new GLib.List<GLib.FileMonitor> ();
481 app_folder = Launcher.get_app_folder ();478 app_folder = Launcher.get_app_folder ();
482 populate_apps.begin (app_folder);479 populate_apps.begin (app_folder);
483 /* FIXME: Profiles are broken on win32 because of no multi instance support */
484 profile_folder = Launcher.get_profile_folder ();480 profile_folder = Launcher.get_profile_folder ();
485#if !HAVE_WIN32
486 populate_apps.begin (profile_folder);481 populate_apps.begin (profile_folder);
487#endif
488 widgets = new GLib.List<Gtk.Widget> ();482 widgets = new GLib.List<Gtk.Widget> ();
489 foreach (var browser in app.get_browsers ())483 foreach (var browser in app.get_browsers ())
490 browser_added (browser);484 browser_added (browser);

Subscribers

People subscribed via source and target branches

to all changes: