Code review comment for lp:~midori/midori/ubuntults-buildfixes

Revision history for this message
Cris Dywan (kalikiana) wrote :

There's two notable drawbacks to GETTEXT_CREATE_TRANSLATIONS, it doesn't handle LINGUAS which is more of a nicety than required for survival, and it forcibly updates all po files in the source tree which isn't harmful so much as annoying… having said that, it works and given that no dev hacks on such an old system I'd say it's acceptable - if there's more time one could write a GETTEXT_PROCESS_PO_FILES that works with the old cmake but I wouldn't expect it.

review: Approve

« Back to merge proposal