Merge lp:~midori/midori/fix-1094858 into lp:midori

Proposed by Danielle Foré
Status: Merged
Merged at revision: 6168
Proposed branch: lp:~midori/midori/fix-1094858
Merge into: lp:midori
Diff against target: 32 lines (+0/-4)
1 file modified
midori/midori-locationaction.c (+0/-4)
To merge this branch: bzr merge lp:~midori/midori/fix-1094858
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+164681@code.launchpad.net

Description of the change

No idea what this does, just migrating a patch to a bzr branch. From the original report:

"midori/midori-locationaction.c: Remove unused pointer `background`

    The pointer `background` is not used in `midori_location_entry_render_text_cb()`."

To post a comment you must log in.
lp:~midori/midori/fix-1094858 updated
6163. By Paul Menzel

remove unused pointer background

Revision history for this message
Cris Dywan (kalikiana) wrote :

Makes sense, in fact there's 2 more instances of this pattern: declaring 'background' when it's actually already handled by the bound attributes. I'm taking care of those bits.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'midori/midori-locationaction.c'
--- midori/midori-locationaction.c 2013-04-18 23:16:56 +0000
+++ midori/midori-locationaction.c 2013-05-20 08:54:25 +0000
@@ -352,12 +352,10 @@
352{352{
353 MidoriLocationAction* action = data;353 MidoriLocationAction* action = data;
354 gchar* title;354 gchar* title;
355 gchar* background;
356 gchar* desc;355 gchar* desc;
357356
358 gtk_tree_model_get (model, iter,357 gtk_tree_model_get (model, iter,
359 MIDORI_AUTOCOMPLETER_COLUMNS_MARKUP, &title,358 MIDORI_AUTOCOMPLETER_COLUMNS_MARKUP, &title,
360 MIDORI_AUTOCOMPLETER_COLUMNS_BACKGROUND, &background,
361 -1);359 -1);
362360
363 if (strchr (title, '\n')) /* A search engine or action suggestion */361 if (strchr (title, '\n')) /* A search engine or action suggestion */
@@ -365,7 +363,6 @@
365 gchar** parts = g_strsplit (title, "\n", 2);363 gchar** parts = g_strsplit (title, "\n", 2);
366 desc = g_strdup (parts[0]);364 desc = g_strdup (parts[0]);
367 g_strfreev (parts);365 g_strfreev (parts);
368 g_free (background);
369 }366 }
370 else367 else
371 {368 {
@@ -406,7 +403,6 @@
406 gchar** parts = g_strsplit (title, "\n", 2);403 gchar** parts = g_strsplit (title, "\n", 2);
407 desc = g_strdup (parts[1]);404 desc = g_strdup (parts[1]);
408 g_strfreev (parts);405 g_strfreev (parts);
409 g_free (background);
410 }406 }
411 else407 else
412 {408 {

Subscribers

People subscribed via source and target branches

to all changes: