Merge lp:~midori/midori/findFileExecInfo into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6994
Merged at revision: 7001
Proposed branch: lp:~midori/midori/findFileExecInfo
Merge into: lp:midori
Diff against target: 33 lines (+5/-11)
1 file modified
CMakeLists.txt (+5/-11)
To merge this branch: bzr merge lp:~midori/midori/findFileExecInfo
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+265222@code.launchpad.net

Commit message

Use find_file to locate execinfo.h

It may not be available in a particular libc.

To post a comment you must log in.
Revision history for this message
Anthony G. Basile <blueness@gentoo.org> (basile-r) wrote :

I just tested this patch on musl/amd64 and it works.

see https://wiki.gentoo.org/wiki/Project:Hardened_musl

Revision history for this message
Paweł Forysiuk (tuxator) wrote :

Looks reasonable.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2015-06-18 05:03:38 +0000
+++ CMakeLists.txt 2015-07-19 22:27:33 +0000
@@ -68,6 +68,11 @@
68 if (SIGNAL)68 if (SIGNAL)
69 add_definitions("-DHAVE_SIGNAL_H")69 add_definitions("-DHAVE_SIGNAL_H")
70 endif ()70 endif ()
71
72 find_file (EXEC_INFO execinfo.h)
73 if (EXEC_INFO)
74 set(VALAFLAGS ${VALAFLAGS} -D HAVE_EXECINFO_H)
75 endif ()
71endif ()76endif ()
7277
73find_library (X11 X11)78find_library (X11 X11)
@@ -101,17 +106,6 @@
101 add_definitions("-DHAVE_OSX=0")106 add_definitions("-DHAVE_OSX=0")
102endif ()107endif ()
103108
104# Check if execinfo.h header exists
105string(FIND ${CMAKE_SYSTEM_NAME} "BSD" BEGIN)
106if (${BEGIN} GREATER 0)
107 string(SUBSTRING ${CMAKE_SYSTEM_NAME} ${BEGIN} 3 BSD)
108else()
109 set(BSD 0)
110endif()
111if (UNIX AND NOT BSD AND NOT DFLY)
112 set(VALAFLAGS ${VALAFLAGS} -D HAVE_EXECINFO_H)
113endif ()
114
115find_package(PkgConfig)109find_package(PkgConfig)
116pkg_check_modules(DEPS REQUIRED110pkg_check_modules(DEPS REQUIRED
117 libxml-2.0>=2.6111 libxml-2.0>=2.6

Subscribers

People subscribed via source and target branches

to all changes: