Code review comment for lp:~midori/midori/colorful_tabs_scale_fix

Revision history for this message
gue5t gue5t (gue5t) wrote :

Scaling an icon down to 1x1px shouldn't take a significant amount of memory, so I doubt that's the problem here. That said, it seems fine to check for NULL since the function is documented to potentially return NULL in OOM situations.

This may be related to the fact that on current trunk (as a result of the recent tab icon scaling commit), different parts of midori-view.c disagree about whether view->icon is a GdkPixbuf or a GIcon (midori_view_get_icon returns the GIcon pointer field as a GdkPixbuf pointer), so we have type errors. I'll write a patch for that when I get a chance to.

« Back to merge proposal