Code review comment for lp:~midori/midori/colorful_tabs_scale_fix

Revision history for this message
Paweł Forysiuk (tuxator) wrote :

Not sure, i guess i can attach a backtrace later on (i dont have it on this machine).

I reproduced this issuse on two different machines, one with fedora one with ubuntu.

In case of fedora crash it would crash when trying to scale icon for gitarzysci.pl webpage.
It was a gif (not sure if animated i think not) and i did not found an easy way to check the type of pixmap before
attempting to scale it.

On ubuntu it was some other site i dont remember. Documentations says that scale may fail when
there is not enough memory to do it. It could also be the case that the favicon in the database is corrupted since when using such fix on ubuntu the offending website had no favicon displayed on the tab.

« Back to merge proposal