Merge lp:~midori/midori/cmakeWin32fixes into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6375
Merged at revision: 6371
Proposed branch: lp:~midori/midori/cmakeWin32fixes
Merge into: lp:midori
Diff against target: 76 lines (+28/-9)
3 files modified
CMakeLists.txt (+10/-3)
data/CMakeLists.txt (+1/-1)
midori/CMakeLists.txt (+17/-5)
To merge this branch: bzr merge lp:~midori/midori/cmakeWin32fixes
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+183367@code.launchpad.net

Commit message

Adjust cmake build for Win32

To post a comment you must log in.
Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2013-09-01 17:10:49 +0000
+++ CMakeLists.txt 2013-09-01 21:28:57 +0000
@@ -34,9 +34,12 @@
34if (UNISTD)34if (UNISTD)
35 add_definitions("-DHAVE_UNISTD_H")35 add_definitions("-DHAVE_UNISTD_H")
36endif ()36endif ()
37find_file (SIGNAL signal.h)37
38if (SIGNAL)38if (UNIX)
39 add_definitions("-DHAVE_SIGNAL_H")39 find_file (SIGNAL signal.h)
40 if (SIGNAL)
41 add_definitions("-DHAVE_SIGNAL_H")
42 endif ()
40endif ()43endif ()
4144
42find_library (X11 X11)45find_library (X11 X11)
@@ -175,6 +178,10 @@
175set(CFLAGS "-w -Wno-deprecated-declarations")178set(CFLAGS "-w -Wno-deprecated-declarations")
176set(LIBMIDORI "${CMAKE_PROJECT_NAME}-core")179set(LIBMIDORI "${CMAKE_PROJECT_NAME}-core")
177180
181# CMake provides no uninstall target by design
182add_custom_target (uninstall
183 COMMAND "xargs" "rm" "-v" "<" "install_manifest.txt")
184
178add_subdirectory (midori)185add_subdirectory (midori)
179add_subdirectory (po)186add_subdirectory (po)
180add_subdirectory (icons)187add_subdirectory (icons)
181188
=== modified file 'data/CMakeLists.txt'
--- data/CMakeLists.txt 2013-08-22 22:53:09 +0000
+++ data/CMakeLists.txt 2013-09-01 21:28:57 +0000
@@ -15,7 +15,7 @@
15 string(FIND ${FILE} "midori." MIDORI_FILE)15 string(FIND ${FILE} "midori." MIDORI_FILE)
16 string(FIND ${FILE} ".desktop" DESKTOP_FILE)16 string(FIND ${FILE} ".desktop" DESKTOP_FILE)
17 if (FAQ_FILE GREATER -1)17 if (FAQ_FILE GREATER -1)
18 elseif (DESKTOP_FILE GREATER -1)18 elseif (DESKTOP_FILE GREATER -1 AND NOT WIN32)
19 string(SUBSTRING ${FILE} 0 ${DESKTOP_FILE} DESKTOP_ID)19 string(SUBSTRING ${FILE} 0 ${DESKTOP_FILE} DESKTOP_ID)
20 INTLTOOL_MERGE_DESKTOP (${DESKTOP_ID} po)20 INTLTOOL_MERGE_DESKTOP (${DESKTOP_ID} po)
21 elseif(MIDORI_FILE GREATER -1)21 elseif(MIDORI_FILE GREATER -1)
2222
=== modified file 'midori/CMakeLists.txt'
--- midori/CMakeLists.txt 2013-08-19 20:15:19 +0000
+++ midori/CMakeLists.txt 2013-09-01 21:28:57 +0000
@@ -49,11 +49,23 @@
49 SOVERSION 149 SOVERSION 1
50 VERSION 0.0.050 VERSION 0.0.0
51 )51 )
52install(TARGETS ${LIBMIDORI}52if (WIN32)
53 LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}53 install(TARGETS ${LIBMIDORI}
54 )54 LIBRARY DESTINATION ${CMAKE_INSTALL_BINDIR}
5555 RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
56add_executable(${CMAKE_PROJECT_NAME} main.c)56 )
57else ()
58 install(TARGETS ${LIBMIDORI}
59 LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
60 )
61endif ()
62
63if (WIN32)
64 add_executable(${CMAKE_PROJECT_NAME} WIN32 main.c "${CMAKE_SOURCE_DIR}/data/midori.rc")
65else()
66 add_executable(${CMAKE_PROJECT_NAME} main.c)
67endif()
68
57target_link_libraries(${CMAKE_PROJECT_NAME}69target_link_libraries(${CMAKE_PROJECT_NAME}
58 ${LIBMIDORI})70 ${LIBMIDORI})
59set_target_properties(${CMAKE_PROJECT_NAME} PROPERTIES71set_target_properties(${CMAKE_PROJECT_NAME} PROPERTIES

Subscribers

People subscribed via source and target branches

to all changes: