Merge lp:~midori/midori/cmakeWin32fixes into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6375
Merged at revision: 6371
Proposed branch: lp:~midori/midori/cmakeWin32fixes
Merge into: lp:midori
Diff against target: 76 lines (+28/-9)
3 files modified
CMakeLists.txt (+10/-3)
data/CMakeLists.txt (+1/-1)
midori/CMakeLists.txt (+17/-5)
To merge this branch: bzr merge lp:~midori/midori/cmakeWin32fixes
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+183367@code.launchpad.net

Commit message

Adjust cmake build for Win32

To post a comment you must log in.
Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2013-09-01 17:10:49 +0000
3+++ CMakeLists.txt 2013-09-01 21:28:57 +0000
4@@ -34,9 +34,12 @@
5 if (UNISTD)
6 add_definitions("-DHAVE_UNISTD_H")
7 endif ()
8-find_file (SIGNAL signal.h)
9-if (SIGNAL)
10- add_definitions("-DHAVE_SIGNAL_H")
11+
12+if (UNIX)
13+ find_file (SIGNAL signal.h)
14+ if (SIGNAL)
15+ add_definitions("-DHAVE_SIGNAL_H")
16+ endif ()
17 endif ()
18
19 find_library (X11 X11)
20@@ -175,6 +178,10 @@
21 set(CFLAGS "-w -Wno-deprecated-declarations")
22 set(LIBMIDORI "${CMAKE_PROJECT_NAME}-core")
23
24+# CMake provides no uninstall target by design
25+add_custom_target (uninstall
26+ COMMAND "xargs" "rm" "-v" "<" "install_manifest.txt")
27+
28 add_subdirectory (midori)
29 add_subdirectory (po)
30 add_subdirectory (icons)
31
32=== modified file 'data/CMakeLists.txt'
33--- data/CMakeLists.txt 2013-08-22 22:53:09 +0000
34+++ data/CMakeLists.txt 2013-09-01 21:28:57 +0000
35@@ -15,7 +15,7 @@
36 string(FIND ${FILE} "midori." MIDORI_FILE)
37 string(FIND ${FILE} ".desktop" DESKTOP_FILE)
38 if (FAQ_FILE GREATER -1)
39- elseif (DESKTOP_FILE GREATER -1)
40+ elseif (DESKTOP_FILE GREATER -1 AND NOT WIN32)
41 string(SUBSTRING ${FILE} 0 ${DESKTOP_FILE} DESKTOP_ID)
42 INTLTOOL_MERGE_DESKTOP (${DESKTOP_ID} po)
43 elseif(MIDORI_FILE GREATER -1)
44
45=== modified file 'midori/CMakeLists.txt'
46--- midori/CMakeLists.txt 2013-08-19 20:15:19 +0000
47+++ midori/CMakeLists.txt 2013-09-01 21:28:57 +0000
48@@ -49,11 +49,23 @@
49 SOVERSION 1
50 VERSION 0.0.0
51 )
52-install(TARGETS ${LIBMIDORI}
53- LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
54- )
55-
56-add_executable(${CMAKE_PROJECT_NAME} main.c)
57+if (WIN32)
58+ install(TARGETS ${LIBMIDORI}
59+ LIBRARY DESTINATION ${CMAKE_INSTALL_BINDIR}
60+ RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
61+ )
62+else ()
63+ install(TARGETS ${LIBMIDORI}
64+ LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
65+ )
66+endif ()
67+
68+if (WIN32)
69+ add_executable(${CMAKE_PROJECT_NAME} WIN32 main.c "${CMAKE_SOURCE_DIR}/data/midori.rc")
70+else()
71+ add_executable(${CMAKE_PROJECT_NAME} main.c)
72+endif()
73+
74 target_link_libraries(${CMAKE_PROJECT_NAME}
75 ${LIBMIDORI})
76 set_target_properties(${CMAKE_PROJECT_NAME} PROPERTIES

Subscribers

People subscribed via source and target branches

to all changes: