Code review comment for lp:~midori/midori/availactions

Revision history for this message
Cory J. Geesaman (cory-g) wrote :

Christian,
Thanks for the update, but there are still some items that are visible with the flag -e available-actions=none:

Back
Forward
Stop
Refresh
Inspect Element
Undo Close Tab
Open in New Window
Add Bookmark

The Back/Forward/Stop/Refresh buttons should go since they can control the flow of an application (it would be nice if the shortcuts extension could disable F5/Refresh but that one isn't so bad), Inspect Element/Undo Close Tab/Open in New Window/Add Bookmark can definitely be used to circumvent a kiosk setup.

With ctrl+right-click the items visible are:

Undo Close Tab
Open in New Window
Add Bookmark
Inspect Element

Like you said, the ctrl+right-click one looks a bit better, but the command doesn't remove all the menu items.

« Back to merge proposal