Code review comment for lp:~michihenning/unity/phablet-coverage-tests

Revision history for this message
Michael Zanetti (mzanetti) wrote :

69 -#####################################################################
70 -# Enable code coverage calculation with gcov/gcovr/lcov
71 -# Usage:
72 -# * Switch build type to coverage (use ccmake or cmake-gui)
73 -# * Invoke make, make test, make coverage (or ninja if you use that backend)
74 -# * Find html report in subdir coveragereport
75 -# * Find xml report feasible for jenkins in coverage.xml
76 -#####################################################################
77 -if(cmake_build_type_lower MATCHES coverage)
78 - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --coverage" )
79 - set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} --coverage" )
80 - set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} --coverage" )
81 - set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} --coverage" )
82 - ENABLE_COVERAGE_REPORT(TARGETS ${SHELL_APP})
83 -endif()

Removing this will break coverage measurements in jenkins.

review: Needs Fixing

« Back to merge proposal