Code review comment for lp:~michihenning/unity-scopes-api/signal-before-unlock

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Ok sure, apart from the one removed from ScopeLoader.cpp, all mutexes are unlocked implicitly almost immediately. This is fine provided that the methods stay this way. If one of these methods were extended further, or a complex temporary were added and required clean up, we could cause the mutex to be held longer unintentionally in the future. Its your call really, just putting it out there :) The fix is correct and working.

« Back to merge proposal