Code review comment for lp:~michihenning/unity-scopes-api/scope-cache-dir

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

I am going to approve this, for my part. I did glance through the code and made a couple of inline comments. While I do think the approach here couples the scope type with security policy more than is required, I understand that this is temporary until we have the libapparmor query interface up and running for files. For now, we only have leaf-net and unconfined and this MR handles that. By the looks of it, it shouldn't be difficult to transition away from ConfinementType when you move to the apparmor query API, and after you do, maintenance of that bit of code shouldn't be much more than managing an 'if/else if/else' statement.

review: Approve

« Back to merge proposal