Code review comment for lp:~michihenning/unity-scopes-api/scope-cache-dir

Revision history for this message
Michi Henning (michihenning) wrote :

> > Yes, the directory needs to be created as part of the installation.
> >
> > Still not solved afaict, without it, this branch is useless.
>
> The leaf-net, leaf-fs, or aggregator directories can all be unconditionally
> created by the scope click hook if they don't already exist. The scope click
> hook could also consider a new 'Type' field added to ScopeConfig (see below
> for discussion), but I don't think it needs to (just create all 3 and be done
> with it).

One thing I don't understand here: because the dir is underneath $HOME, that means the click hook would have to create the dir for *all* users of the device? What if a user is added later, after a scope was installed? In that case, whatever script runs to add a user would have to make sure that this directory is create along with everything else.

Unless I'm missing something, this seems brittle to me.

« Back to merge proposal