Code review comment for lp:~michihenning/unity-scopes-api/scope-cache-dir

Revision history for this message
Michi Henning (michihenning) wrote :

> 602 virtual void start(std::string const& scope_id, RegistryProxy
> const& registry);
>
> The point of keeping this was to preserve ABI compatibility, but with the
> introduction of AbstractScopeBase that is moot, so feel free to get rid of it.

OK, done.

> Also, since it is breaking the ABI, we probably want to merge the 4.9 branch
> as well before the next "release" to distro?

Is the default gcc in distro 4.9 now? It would be good to merge, yes, but we also need to merge the 4.9 unity-api. And, once we've done that, there will essentially be no going back :-)

The (now inappropriately named) set-env-vars should also be merged in the same batch, because it adds another virtual to AbstractScopeBase.

« Back to merge proposal