Code review comment for lp:~michihenning/unity-scopes-api/scope-cache-dir
Revision history for this message
| Michal Hruby (mhr3) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
602 virtual void start(std::string const& scope_id, RegistryProxy const& registry);
The point of keeping this was to preserve ABI compatibility, but with the introduction of AbstractScopeBase that is moot, so feel free to get rid of it.
Also, since it is breaking the ABI, we probably want to merge the 4.9 branch as well before the next "release" to distro?