Code review comment for lp:~michihenning/unity-scopes-api/loop-fix

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looks good, thank you! It's a pitty we don't pass CannedQuery everywhere, that would greatly simplify the creation of "details" variant (and also would transparently support anything we may throw into CannedQuery in the future). We need to remember to updated loop detection whenever we add any other extra parameter to search queries.

review: Approve

« Back to merge proposal