Merge lp:~michihenning/unity-scopes-api/gtest-fixes into lp:unity-scopes-api/devel

Proposed by Michi Henning
Status: Merged
Approved by: Marcus Tomlinson
Approved revision: 701
Merged at revision: 694
Proposed branch: lp:~michihenning/unity-scopes-api/gtest-fixes
Merge into: lp:unity-scopes-api/devel
Diff against target: 3454 lines (+639/-368)
113 files modified
HACKING (+4/-4)
debian/changelog (+6/-0)
debian/control (+4/-118)
debian/control.in (+2/-0)
include/unity/scopes/testing/MockObject.h (+3/-0)
include/unity/scopes/testing/MockPreviewReply.h (+3/-0)
include/unity/scopes/testing/MockQueryCtrl.h (+3/-0)
include/unity/scopes/testing/MockRegistry.h (+3/-0)
include/unity/scopes/testing/MockScope.h (+3/-0)
include/unity/scopes/testing/MockSearchReply.h (+3/-0)
include/unity/scopes/testing/TypedScopeFixture.h (+3/-0)
src/scopes/internal/Utils.cpp (+14/-1)
test/gtest/CMakeLists.txt (+1/-18)
test/gtest/scopes/Activation/Activation_test.cpp (+5/-1)
test/gtest/scopes/ActivationResponse/ActivationResponse_test.cpp (+6/-2)
test/gtest/scopes/Aggregation/ChildScopes_test.cpp (+13/-9)
test/gtest/scopes/Aggregation/Keywords_test.cpp (+10/-6)
test/gtest/scopes/Aggregation/LoopDetection_test.cpp (+21/-18)
test/gtest/scopes/Annotation/Annotation_test.cpp (+4/-0)
test/gtest/scopes/CannedQuery/CannedQuery_test.cpp (+5/-1)
test/gtest/scopes/CategorisedResult/CategorisedResult_test.cpp (+4/-0)
test/gtest/scopes/Category/Category_test.cpp (+3/-0)
test/gtest/scopes/CategoryRenderer/CategoryRenderer_test.cpp (+4/-0)
test/gtest/scopes/ColumnLayout/ColumnLayout_test.cpp (+4/-0)
test/gtest/scopes/DateTimePickerFilter/DateTimePickerFilter_test.cpp (+4/-0)
test/gtest/scopes/Department/Department_test.cpp (+4/-0)
test/gtest/scopes/Filters/Filters_test.cpp (+5/-1)
test/gtest/scopes/IdleShutdown/IdleShutdown_test.cpp (+4/-0)
test/gtest/scopes/Invocation/Invocation_test.cpp (+3/-0)
test/gtest/scopes/Location/Location_test.cpp (+5/-1)
test/gtest/scopes/OnlineAccountClient/OnlineAccountClient_test.cpp (+8/-4)
test/gtest/scopes/OptionSelectorFilter/OptionSelectorFilter_test.cpp (+5/-0)
test/gtest/scopes/PreviewWidget/PreviewWidget_test.cpp (+4/-0)
test/gtest/scopes/QueryMetadata/QueryMetadata_test.cpp (+5/-1)
test/gtest/scopes/RadioButtonsFilter/RadioButtonsFilter_test.cpp (+4/-0)
test/gtest/scopes/RangeInputFilter/RangeInputFilter_test.cpp (+4/-0)
test/gtest/scopes/RatingFilter/RatingFilter_test.cpp (+5/-0)
test/gtest/scopes/Registry/Registry_test.cpp (+19/-15)
test/gtest/scopes/ReplyReaper/NoReplyScope.cpp (+3/-0)
test/gtest/scopes/ReplyReaper/ReplyReaper_test.cpp (+4/-0)
test/gtest/scopes/ResultCache/ResultCache_test.cpp (+39/-34)
test/gtest/scopes/Runtime/PusherScope.cpp (+3/-0)
test/gtest/scopes/Runtime/Runtime_test.cpp (+5/-2)
test/gtest/scopes/Runtime/SlowCreateScope.cpp (+3/-0)
test/gtest/scopes/Runtime/TestScope.cpp (+4/-0)
test/gtest/scopes/ScopeBase/ScopeBase_test.cpp (+3/-0)
test/gtest/scopes/ScopeExceptions/ScopeExceptions_test.cpp (+3/-0)
test/gtest/scopes/StandAloneScope/StandAloneScope_test.cpp (+3/-0)
test/gtest/scopes/StripLocation/StripLocation_test.cpp (+3/-0)
test/gtest/scopes/SwitchFilter/SwitchFilter_test.cpp (+4/-0)
test/gtest/scopes/ThrowingClient/ThrowingClient_test.cpp (+12/-9)
test/gtest/scopes/ThrowingScope/ThrowingScope_test.cpp (+14/-11)
test/gtest/scopes/ValueSliderFilter/ValueSliderFilter_test.cpp (+6/-2)
test/gtest/scopes/Variant/Variant_test.cpp (+5/-2)
test/gtest/scopes/VariantBuilder/VariantBuilder_test.cpp (+5/-1)
test/gtest/scopes/Version/Version_test.cpp (+3/-0)
test/gtest/scopes/internal/CategoryRegistry/CategoryRegistry_test.cpp (+3/-0)
test/gtest/scopes/internal/ConfigBase/ConfigBase_test.cpp (+3/-0)
test/gtest/scopes/internal/DynamicLoader/DynamicLoader_test.cpp (+3/-0)
test/gtest/scopes/internal/IniSettingsSchema/IniSettingsSchema_test.cpp (+9/-6)
test/gtest/scopes/internal/JsonNode/JsonNode_test.cpp (+4/-0)
test/gtest/scopes/internal/JsonSettingsSchema/JsonSettingsSchema_test.cpp (+7/-4)
test/gtest/scopes/internal/Logger/Logger_test.cpp (+5/-0)
test/gtest/scopes/internal/MiddlewareFactory/MiddlewareFactory_test.cpp (+3/-0)
test/gtest/scopes/internal/Reaper/Reaper_test.cpp (+17/-14)
test/gtest/scopes/internal/RegistryConfig/RegistryConfig_test.cpp (+3/-0)
test/gtest/scopes/internal/RegistryObject/RegistryObject_test.cpp (+3/-1)
test/gtest/scopes/internal/ResultReplyObject/ResultReplyObject_test.cpp (+4/-0)
test/gtest/scopes/internal/RuntimeConfig/RuntimeConfig_test.cpp (+3/-0)
test/gtest/scopes/internal/RuntimeImpl/RuntimeImpl_test.cpp (+4/-0)
test/gtest/scopes/internal/ScopeConfig/ScopeConfig_test.cpp (+9/-6)
test/gtest/scopes/internal/ScopeLoader/ScopeLoader_test.cpp (+3/-0)
test/gtest/scopes/internal/ScopeMetadataImpl/ScopeMetadataImpl_test.cpp (+5/-2)
test/gtest/scopes/internal/SettingsDB/SettingsDB_test.cpp (+25/-21)
test/gtest/scopes/internal/ThreadPool/ThreadPool_test.cpp (+4/-0)
test/gtest/scopes/internal/ThreadSafeQueue/ThreadSafeQueue_test.cpp (+3/-0)
test/gtest/scopes/internal/UniqueID/UniqueID_test.cpp (+3/-0)
test/gtest/scopes/internal/Utils/Utils_test.cpp (+21/-5)
test/gtest/scopes/internal/gobj_ptr/gobj_ptr_test.cpp (+12/-8)
test/gtest/scopes/internal/safe_strerror/safe_strerror_test.cpp (+4/-0)
test/gtest/scopes/internal/smartscopes/HttpClient/HttpClient_test.cpp (+4/-0)
test/gtest/scopes/internal/smartscopes/SSConfig/SSConfig_test.cpp (+3/-0)
test/gtest/scopes/internal/smartscopes/SmartScopesClient/SmartScopesClient_test.cpp (+24/-20)
test/gtest/scopes/internal/smartscopes/smartscopesproxy/smartscopesproxy_test.cpp (+11/-7)
test/gtest/scopes/internal/zmq_middleware/ConnectionPool/ConnectionPool_test.cpp (+3/-0)
test/gtest/scopes/internal/zmq_middleware/ObjectAdapter/ObjectAdapter_test.cpp (+4/-0)
test/gtest/scopes/internal/zmq_middleware/PubSub/PubSub_test.cpp (+4/-0)
test/gtest/scopes/internal/zmq_middleware/RegistryI/RegistryI_test.cpp (+4/-1)
test/gtest/scopes/internal/zmq_middleware/ServantBase/ServantBase_test.cpp (+3/-0)
test/gtest/scopes/internal/zmq_middleware/StopPublisher/StopPublisher_test.cpp (+3/-0)
test/gtest/scopes/internal/zmq_middleware/Util/Util_test.cpp (+4/-0)
test/gtest/scopes/internal/zmq_middleware/VariantConverter/VariantConverter_test.cpp (+5/-1)
test/gtest/scopes/internal/zmq_middleware/ZmqMiddleware/ZmqMiddleware_test.cpp (+3/-0)
test/gtest/scopes/qt/JsonAsyncReader/JsonAsyncReader_test.cpp (+5/-1)
test/gtest/scopes/qt/XmlAsyncReader/XmlAsyncReader_test.cpp (+3/-0)
test/gtest/scopes/qt/qt-bindings/QActionMetadata_test.cpp (+3/-0)
test/gtest/scopes/qt/qt-bindings/QCannedQuery_test.cpp (+4/-1)
test/gtest/scopes/qt/qt-bindings/QCategorisedResult_test.cpp (+3/-0)
test/gtest/scopes/qt/qt-bindings/QColumnLayout_test.cpp (+5/-2)
test/gtest/scopes/qt/qt-bindings/QDepartment_test.cpp (+4/-1)
test/gtest/scopes/qt/qt-bindings/QPreviewQueryBaseAPI_test.cpp (+3/-1)
test/gtest/scopes/qt/qt-bindings/QPreviewWidget_test.cpp (+3/-0)
test/gtest/scopes/qt/qt-bindings/QScopeBaseAPIImpl_test.cpp (+3/-1)
test/gtest/scopes/qt/qt-bindings/QScopeCreation_test.cpp (+4/-0)
test/gtest/scopes/qt/qt-bindings/QSearchMetadata_test.cpp (+3/-0)
test/gtest/scopes/qt/qt-bindings/QSearchQueryBaseAPI_test.cpp (+3/-1)
test/gtest/scopes/qt/qt-bindings/QUtils_test.cpp (+4/-1)
test/gtest/scopes/qt/qt-bindings/QVariantBuilder_test.cpp (+3/-0)
test/gtest/scopes/stress/scopes-stress.cpp (+6/-2)
test/gtest/scopes/testing/IsolatedScope/IsolatedScope_test.cpp (+3/-0)
test/gtest/scopes/testing/IsolatedScopeBenchmark/IsolatedScopeBenchmark_test.cpp (+3/-0)
test/gtest/scopes/testing/Statistics/Statistics_test.cpp (+3/-0)
test/gtest/scopes/utility/BufferedResultForwarder/BufferedResultForwarder_test.cpp (+4/-0)
To merge this branch: bzr merge lp:~michihenning/unity-scopes-api/gtest-fixes
Reviewer Review Type Date Requested Status
Marcus Tomlinson (community) Approve
unity-api-1-bot continuous-integration Approve
Review via email: mp+311790@code.launchpad.net

Commit message

Changed tests to use cmake-extras for gtest/gmock 1.8.
Fixed tons of warnings caused by new gtest for private ctors.
Fixed tons of warnings about signed/unsigned comparison.
Fixed segfault in the Utils test.
Fixed test failure in the SettingsDB test.
Fixed lots of places where gtest macros had their arguments in the wrong order.
Added missing dependency for language-pack-tr to control.in.
Replaced debian/control with a minimal dummy so people don't endlessly edit the wrong file (control instead of control.in) by mistake.

Description of the change

Changed tests to use cmake-extras for gtest/gmock 1.8.
Fixed tons of warnings caused by new gtest for private ctors.
Fixed tons of warnings about signed/unsigned comparison.
Fixed segfault in the Utils test.
Fixed test failure in the SettingsDB test.
Fixed lots of places where gtest macros had their arguments in the wrong order.
Added missing dependency for language-pack-tr to control.in.
Replaced debian/control with a minimal dummy so people don't endlessly edit the wrong file (control instead of control.in) by mistake.

To post a comment you must log in.
Revision history for this message
Michi Henning (michihenning) wrote :

I set this to "work in progress" because we need to wait for the cmake-extras changes to land before this will pass its tests.

Revision history for this message
Michi Henning (michihenning) wrote :

I've upgraded the chroots on the slaves, so zesty builds should work with gtest 1.8 now.

694. By Michi Henning

Added missing dependency on language-pack-tr to control.in.

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :
review: Needs Fixing (continuous-integration)
695. By Michi Henning

Merged devel.

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :
review: Needs Fixing (continuous-integration)
696. By Michi Henning

Addedd missing cmake-extras to control.in.

697. By Michi Henning

Replaced debian/control with a minimully dummy, so people don't
endlessly edit control instead of control.in by mistake.

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:696
https://jenkins.canonical.com/unity-api-1/job/lp-unity-scopes-api-ci/60/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1184/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1191
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/977
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/977/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/977
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/977/artifact/output/*zip*/output.zip
    ABORTED: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/977/console
    ABORTED: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/977/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/977
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/977/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/977
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/977/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-unity-scopes-api-ci/60/rebuild

review: Needs Fixing (continuous-integration)
698. By Michi Henning

Updated HACKING.

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:697
https://jenkins.canonical.com/unity-api-1/job/lp-unity-scopes-api-ci/61/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1185
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1192
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/978
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/978/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/978
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/978/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/978
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/978/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/978
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/978/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/978
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/978/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/978
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/978/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-unity-scopes-api-ci/61/rebuild

review: Approve (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:698
https://jenkins.canonical.com/unity-api-1/job/lp-unity-scopes-api-ci/62/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1186
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1193
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/979
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/979/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/979
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/979/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/979
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/979/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/979
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/979/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/979
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/979/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/979
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/979/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-unity-scopes-api-ci/62/rebuild

review: Approve (continuous-integration)
699. By Michi Henning

Relaxed cmake-extras version requirement. 0.4 is good enough.

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:699
https://jenkins.canonical.com/unity-api-1/job/lp-unity-scopes-api-ci/63/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1187
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1194
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/980
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/980/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/980
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/980/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/980
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/980/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/980
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/980/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/980
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/980/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/980
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/980/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-unity-scopes-api-ci/63/rebuild

review: Approve (continuous-integration)
700. By Michi Henning

Unset LC_ALL after test if it wasn't set initially.

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:700
https://jenkins.canonical.com/unity-api-1/job/lp-unity-scopes-api-ci/64/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1192
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1199
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/985
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/985/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/985
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/985/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/985
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/985/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/985
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/985/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/985
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/985/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/985
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/985/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-unity-scopes-api-ci/64/rebuild

review: Approve (continuous-integration)
701. By Michi Henning

Fix typo.

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:701
https://jenkins.canonical.com/unity-api-1/job/lp-unity-scopes-api-ci/65/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1194
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1201
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/987
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/987/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/987
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/987/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/987
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/987/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/987
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/987/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/987
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/987/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/987
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/987/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-unity-scopes-api-ci/65/rebuild

review: Approve (continuous-integration)
Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Looks good Michi, thanks!

P.S. On the topic of whether cppcheck finds anything the compiler doesn't, here's the sort of stuff cppcheck complains about for this project: http://pastebin.ubuntu.com/23552147/ (nothing serious really, but different nonetheless)

review: Approve
Revision history for this message
Michi Henning (michihenning) wrote :

Thanks for that. Interesting. Last time I ran cppcheck (quite some time ago), we didn't get any of that (or we certainly didn't get most of it). Looks like cppcheck is more thorough now. Might run it over some of our other stuff then, too.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'HACKING'
--- HACKING 2016-09-09 06:57:47 +0000
+++ HACKING 2016-11-28 10:48:16 +0000
@@ -205,13 +205,13 @@
205205
206 - QT-VERSION206 - QT-VERSION
207207
208 The full version number parts for libunity-scopes-qt.208 The full version number for libunity-scopes-qt.
209209
210 - *If* the soname changes, you need to add the outdated210 - *If* the soname changes, you need to add the outdated
211 versions to the "Replaces:" and "Conflicts:" entries211 versions to the "Replaces:" and "Conflicts:" entries
212 in control and control.in. (You need an extra212 in control.in. (You need an extra entry for each Vivid and
213 entry for each Vivid and Wily/Xenial andlater. See213 Wily/Xenial and later.)
214 bileto_pre_release_hook for the sed scripts that append a214 See bileto_pre_release_hook for the sed scripts that append a
215 line to the stanza if the soname is changed. This also may apply215 line to the stanza if the soname is changed. This also may apply
216 if the soname of the Qt library changes, in which case216 if the soname of the Qt library changes, in which case
217 bileto_pre_release_hook needs a corresponding update.217 bileto_pre_release_hook needs a corresponding update.
218218
=== modified file 'debian/changelog'
--- debian/changelog 2016-09-21 03:51:32 +0000
+++ debian/changelog 2016-11-28 10:48:16 +0000
@@ -1,3 +1,9 @@
1unity-scopes-api (1.0.7+17.04.20161115-0ubuntu1) zesty; urgency=medium
2
3 * Be stricter on user-configurable idle timeout (1s to 5min).
4
5 -- Marcus Tomlinson <marcus.tomlinson@canonical.com> Tue, 15 Nov 2016 06:09:04 +0000
6
1unity-scopes-api (1.0.7+16.10.20160921-0ubuntu1) yakkety; urgency=medium7unity-scopes-api (1.0.7+16.10.20160921-0ubuntu1) yakkety; urgency=medium
28
3 [ Marcus Tomlinson ]9 [ Marcus Tomlinson ]
410
=== modified file 'debian/control'
--- debian/control 2016-10-07 15:42:53 +0000
+++ debian/control 2016-11-28 10:48:16 +0000
@@ -4,124 +4,10 @@
4# This file is regenerated automatically by bileto.4# This file is regenerated automatically by bileto.
5#5#
6Source: unity-scopes-api6Source: unity-scopes-api
7Priority: optional7
8Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>8# DO NOT EDIT THIS FILE. WE REALLY MEAN IT!
9Build-Depends: abigail-tools <!nocheck> | libabigail-tools <!nocheck>,
10 binutils:native,
11 capnproto,
12 click-dev (>= 0.2.2),
13 cmake,
14 dbus-test-runner,
15 debhelper (>= 9),
16 devscripts,
17 doxygen,
18 exuberant-ctags,
19 google-mock,
20 graphviz,
21 language-pack-tr,
22 libaccounts-glib-dev,
23 libapparmor-dev,
24 libboost-filesystem-dev,
25 libboost-regex-dev,
26 libboost-serialization-dev,
27 libboost-thread-dev,
28 libcapnp-dev (>= 0.4.0),
29 libdbustest1-dev,
30 libjson-glib-dev,
31 liblttng-ust-dev,
32 libnet-cpp-dev (>= 1.2.0),
33 libprocess-cpp-dev (>= 1.0.1),
34 libsignon-glib-dev,
35 libunity-api-dev (>= 7.80.7~),
36 libzmq3-dev,
37 libzmqpp-dev,
38 lsb-release,
39 lttng-tools,
40 pkg-config,
41 python3 <!nocheck>,
42 python3-dbusmock <!nocheck>,
43 python-tornado <!nocheck>,
44 valgrind,
45Standards-Version: 3.9.6
46XS-Testsuite: autopkgtest
47Section: libs
48Homepage: https://launchpad.net/unity-scopes-api
49# if you don't have have commit access to this branch but would like to upload
50# directly to Ubuntu, don't worry: your changes will be merged back into the
51# upstream branch
52Vcs-Bzr: lp:unity-scopes-api
53Vcs-Browser: https://code.launchpad.net/unity-scopes-api
549
55Package: libunity-scopes1.010Package: libunity-scopes1.0
56Architecture: any11Architecture: any
57Multi-Arch: same12Description: DO NOT EDIT THIS FILE, IT IS GENERATED FROM control.in
58Pre-Depends: ${misc:Pre-Depends},13 DO NOT EDIT THIS FILE
59Depends: ${misc:Depends},
60 ${shlibs:Depends},
61Replaces: libunity-scopes0,
62 libunity-scopes3,
63 libunity-scopes1,
64 libunity-scopes2,
65Conflicts: libunity-scopes0,
66 libunity-scopes3,
67 libunity-scopes1,
68 libunity-scopes2,
69Description: API for Unity scopes integration
70 Library to integrate scopes with the Unity shell
71
72Package: libunity-scopes-dev
73Section: libdevel
74Architecture: any
75Multi-Arch: same
76Depends: libproperties-cpp-dev,
77 libunity-api-dev,
78 libunity-scopes1.0 (= ${binary:Version}),
79 ${misc:Depends},
80Description: Header files for Unity scopes API
81 Library to integrate scopes with the Unity shell (dev files)
82
83Package: libunity-scopes-cli
84Section: devel
85Architecture: any
86Multi-Arch: foreign
87Depends: libunity-scopes1.0 (= ${binary:Version}),
88 ${misc:Depends},
89 ${shlibs:Depends},
90Description: Client utility for Unity scopes API
91 Commandline client utility for querying Unity scopes, useful for testing.
92
93Package: libunity-scopes-doc
94Section: doc
95Architecture: all
96Multi-Arch: foreign
97Depends: ${misc:Depends},
98Description: Documentation for Unity scopes API
99 Library to integrate scopes with the Unity shell (documentation)
100
101Package: libunity-scopes-qt0.2
102Architecture: any
103Multi-Arch: same
104Pre-Depends: ${misc:Pre-Depends},
105Depends: ${misc:Depends},
106 ${shlibs:Depends},
107Description: Qt library for Unity scopes API
108 Library that integrates classes based on Qt for convenience
109
110Package: libunity-scopes-qt-dev
111Section: libdevel
112Architecture: any
113Multi-Arch: same
114Depends: libunity-scopes-dev (= ${binary:Version}),
115 libunity-scopes-qt0.2 (= ${binary:Version}),
116 libnet-cpp-dev (>=1.2.0),
117 ${misc:Depends},
118Description: Header files for Qt library for Unity scopes API
119 Library that integrates classes based on Qt for convenience (dev files)
120
121Package: libunity-scopes-qt-doc
122Section: doc
123Architecture: all
124Multi-Arch: foreign
125Depends: ${misc:Depends},
126Description: Documentation for Unity Qt library
127 Library that integrates classes based on Qt for convenience (documentation)
12814
=== modified file 'debian/control.in'
--- debian/control.in 2016-07-25 05:35:44 +0000
+++ debian/control.in 2016-11-28 10:48:16 +0000
@@ -6,6 +6,7 @@
6 capnproto,6 capnproto,
7 click-dev (>= 0.2.2),7 click-dev (>= 0.2.2),
8 cmake,8 cmake,
9 cmake-extras (>= 0.4),
9 dbus-test-runner,10 dbus-test-runner,
10 debhelper (>= 9),11 debhelper (>= 9),
11 devscripts,12 devscripts,
@@ -13,6 +14,7 @@
13 exuberant-ctags,14 exuberant-ctags,
14 google-mock,15 google-mock,
15 graphviz,16 graphviz,
17 language-pack-tr,
16 libaccounts-glib-dev,18 libaccounts-glib-dev,
17 libapparmor-dev,19 libapparmor-dev,
18 libboost-filesystem-dev,20 libboost-filesystem-dev,
1921
=== modified file 'include/unity/scopes/testing/MockObject.h'
--- include/unity/scopes/testing/MockObject.h 2015-04-01 11:28:32 +0000
+++ include/unity/scopes/testing/MockObject.h 2016-11-28 10:48:16 +0000
@@ -20,7 +20,10 @@
2020
21#include <unity/scopes/Object.h>21#include <unity/scopes/Object.h>
2222
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
23#include <gmock/gmock.h>25#include <gmock/gmock.h>
26#pragma GCC diagnostic pop
2427
25namespace unity28namespace unity
26{29{
2730
=== modified file 'include/unity/scopes/testing/MockPreviewReply.h'
--- include/unity/scopes/testing/MockPreviewReply.h 2015-04-10 10:10:06 +0000
+++ include/unity/scopes/testing/MockPreviewReply.h 2016-11-28 10:48:16 +0000
@@ -22,7 +22,10 @@
2222
23#include <unity/scopes/testing/MockObject.h>23#include <unity/scopes/testing/MockObject.h>
2424
25#pragma GCC diagnostic push
26#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
25#include <gmock/gmock.h>27#include <gmock/gmock.h>
28#pragma GCC diagnostic pop
2629
27namespace unity30namespace unity
28{31{
2932
=== modified file 'include/unity/scopes/testing/MockQueryCtrl.h'
--- include/unity/scopes/testing/MockQueryCtrl.h 2014-11-03 05:31:30 +0000
+++ include/unity/scopes/testing/MockQueryCtrl.h 2016-11-28 10:48:16 +0000
@@ -22,7 +22,10 @@
2222
23#include <unity/scopes/testing/MockObject.h>23#include <unity/scopes/testing/MockObject.h>
2424
25#pragma GCC diagnostic push
26#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
25#include <gmock/gmock.h>27#include <gmock/gmock.h>
28#pragma GCC diagnostic pop
2629
27namespace unity30namespace unity
28{31{
2932
=== modified file 'include/unity/scopes/testing/MockRegistry.h'
--- include/unity/scopes/testing/MockRegistry.h 2015-02-06 00:25:05 +0000
+++ include/unity/scopes/testing/MockRegistry.h 2016-11-28 10:48:16 +0000
@@ -21,7 +21,10 @@
21#include <unity/scopes/Registry.h>21#include <unity/scopes/Registry.h>
22#include <unity/scopes/testing/MockObject.h>22#include <unity/scopes/testing/MockObject.h>
2323
24#pragma GCC diagnostic push
25#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gmock/gmock.h>26#include <gmock/gmock.h>
27#pragma GCC diagnostic pop
2528
26namespace unity29namespace unity
27{30{
2831
=== modified file 'include/unity/scopes/testing/MockScope.h'
--- include/unity/scopes/testing/MockScope.h 2016-09-08 08:22:37 +0000
+++ include/unity/scopes/testing/MockScope.h 2016-11-28 10:48:16 +0000
@@ -24,7 +24,10 @@
2424
25#include <unity/scopes/testing/MockObject.h>25#include <unity/scopes/testing/MockObject.h>
2626
27#pragma GCC diagnostic push
28#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
27#include <gmock/gmock.h>29#include <gmock/gmock.h>
30#pragma GCC diagnostic pop
2831
29namespace unity32namespace unity
30{33{
3134
=== modified file 'include/unity/scopes/testing/MockSearchReply.h'
--- include/unity/scopes/testing/MockSearchReply.h 2016-06-14 14:19:25 +0000
+++ include/unity/scopes/testing/MockSearchReply.h 2016-11-28 10:48:16 +0000
@@ -24,7 +24,10 @@
2424
25#include <unity/scopes/testing/MockObject.h>25#include <unity/scopes/testing/MockObject.h>
2626
27#pragma GCC diagnostic push
28#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
27#include <gmock/gmock.h>29#include <gmock/gmock.h>
30#pragma GCC diagnostic pop
2831
29namespace unity32namespace unity
30{33{
3134
=== modified file 'include/unity/scopes/testing/TypedScopeFixture.h'
--- include/unity/scopes/testing/TypedScopeFixture.h 2016-03-09 04:01:35 +0000
+++ include/unity/scopes/testing/TypedScopeFixture.h 2016-11-28 10:48:16 +0000
@@ -22,7 +22,10 @@
2222
23#include <unity/scopes/testing/MockRegistry.h>23#include <unity/scopes/testing/MockRegistry.h>
2424
25#pragma GCC diagnostic push
26#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
25#include <gtest/gtest.h>27#include <gtest/gtest.h>
28#pragma GCC diagnostic pop
2629
27#include <memory>30#include <memory>
2831
2932
=== modified file 'src/scopes/internal/Utils.cpp'
--- src/scopes/internal/Utils.cpp 2016-10-07 15:42:53 +0000
+++ src/scopes/internal/Utils.cpp 2016-11-28 10:48:16 +0000
@@ -266,7 +266,20 @@
266 }266 }
267 else267 else
268 {268 {
269 result += custom_exec_arg + " ";269 // The path provided is already absolute. Ensure that the SNAP env var is honored.
270
271 char const* sroot = getenv("SNAP");
272 std::string snap_root;
273 if (sroot)
274 {
275 snap_root = sroot;
276 if (!snap_root.empty() && snap_root[snap_root.size() - 1] != '/')
277 {
278 snap_root += '/';
279 }
280 }
281
282 result += snap_root + custom_exec_arg + " ";
270 }283 }
271 }284 }
272 result.resize(result.size() - 1);285 result.resize(result.size() - 1);
273286
=== modified file 'test/gtest/CMakeLists.txt'
--- test/gtest/CMakeLists.txt 2014-12-02 02:00:57 +0000
+++ test/gtest/CMakeLists.txt 2016-11-28 10:48:16 +0000
@@ -1,21 +1,4 @@
1if (NOT DEFINED GMOCK_ROOT)1find_package(GMock)
2 set(GMOCK_ROOT /usr/src/gmock)
3endif()
4
5add_subdirectory(${GMOCK_ROOT} gmock)
6
7# Selectively switch off warnings about missing field initializers when building gmock and gtest
8set_property(TARGET gmock APPEND_STRING PROPERTY COMPILE_FLAGS " -Wno-missing-field-initializers -Wno-old-style-cast")
9set_property(TARGET gmock_main APPEND_STRING PROPERTY COMPILE_FLAGS " -Wno-missing-field-initializers -Wno-old-style-cast")
10set_property(TARGET gtest APPEND_STRING PROPERTY COMPILE_FLAGS " -Wno-missing-field-initializers -Wno-old-style-cast")
11
12# Make sure we always build gtest/gmock with debug info, otherwise we don't
13# get line numbers for the code that is dragged in by the test macros.
14set_property(TARGET gmock APPEND_STRING PROPERTY COMPILE_FLAGS " -g")
15set_property(TARGET gmock_main APPEND_STRING PROPERTY COMPILE_FLAGS " -g")
16set_property(TARGET gtest APPEND_STRING PROPERTY COMPILE_FLAGS " -g")
17
18include_directories(${GMOCK_ROOT}/gtest/include)
192
20set(LIBGTEST gtest gmock gmock_main)3set(LIBGTEST gtest gmock gmock_main)
21set(TESTLIBS ${TESTLIBS} ${LIBGTEST} boost_regex)4set(TESTLIBS ${TESTLIBS} ${LIBGTEST} boost_regex)
225
=== modified file 'test/gtest/scopes/Activation/Activation_test.cpp'
--- test/gtest/scopes/Activation/Activation_test.cpp 2015-06-08 14:05:12 +0000
+++ test/gtest/scopes/Activation/Activation_test.cpp 2016-11-28 10:48:16 +0000
@@ -28,10 +28,14 @@
28#include <unity/scopes/ActionMetadata.h>28#include <unity/scopes/ActionMetadata.h>
29#include <unity/UnityExceptions.h>29#include <unity/UnityExceptions.h>
30#include <functional>30#include <functional>
31#include <gtest/gtest.h>
32#include <unity/scopes/testing/Result.h>31#include <unity/scopes/testing/Result.h>
33#include <TestScope.h>32#include <TestScope.h>
3433
34#pragma GCC diagnostic push
35#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
36#include <gtest/gtest.h>
37#pragma GCC diagnostic pop
38
35using namespace unity::scopes;39using namespace unity::scopes;
36using namespace unity::scopes::internal;40using namespace unity::scopes::internal;
3741
3842
=== modified file 'test/gtest/scopes/ActivationResponse/ActivationResponse_test.cpp'
--- test/gtest/scopes/ActivationResponse/ActivationResponse_test.cpp 2015-07-14 15:11:48 +0000
+++ test/gtest/scopes/ActivationResponse/ActivationResponse_test.cpp 2016-11-28 10:48:16 +0000
@@ -22,7 +22,11 @@
22#include <unity/scopes/internal/ResultImpl.h>22#include <unity/scopes/internal/ResultImpl.h>
23#include <unity/scopes/internal/RuntimeImpl.h>23#include <unity/scopes/internal/RuntimeImpl.h>
24#include <unity/UnityExceptions.h>24#include <unity/UnityExceptions.h>
25
26#pragma GCC diagnostic push
27#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
25#include <gtest/gtest.h>28#include <gtest/gtest.h>
29#pragma GCC diagnostic pop
2630
27using namespace unity::scopes;31using namespace unity::scopes;
28using namespace unity::scopes::internal;32using namespace unity::scopes::internal;
@@ -107,7 +111,7 @@
107111
108 ActivationResponse resp(widgets);112 ActivationResponse resp(widgets);
109 EXPECT_EQ(ActivationResponse::Status::UpdatePreview, resp.status());113 EXPECT_EQ(ActivationResponse::Status::UpdatePreview, resp.status());
110 EXPECT_EQ(1, resp.updated_widgets().size());114 EXPECT_EQ(1u, resp.updated_widgets().size());
111 EXPECT_EQ("w1", resp.updated_widgets().begin()->id());115 EXPECT_EQ("w1", resp.updated_widgets().begin()->id());
112 }116 }
113117
@@ -170,7 +174,7 @@
170174
171 ActivationResponse resp2 = internal::ActivationResponseImpl::create(var, runtime.get());175 ActivationResponse resp2 = internal::ActivationResponseImpl::create(var, runtime.get());
172 EXPECT_EQ(ActivationResponse::Status::UpdatePreview, resp2.status());176 EXPECT_EQ(ActivationResponse::Status::UpdatePreview, resp2.status());
173 EXPECT_EQ(1, resp2.updated_widgets().size());177 EXPECT_EQ(1u, resp2.updated_widgets().size());
174 EXPECT_EQ("w1", resp2.updated_widgets().begin()->id());178 EXPECT_EQ("w1", resp2.updated_widgets().begin()->id());
175 }179 }
176}180}
177181
=== modified file 'test/gtest/scopes/Aggregation/ChildScopes_test.cpp'
--- test/gtest/scopes/Aggregation/ChildScopes_test.cpp 2015-12-18 09:21:53 +0000
+++ test/gtest/scopes/Aggregation/ChildScopes_test.cpp 2016-11-28 10:48:16 +0000
@@ -26,7 +26,11 @@
2626
27#include <boost/filesystem/operations.hpp>27#include <boost/filesystem/operations.hpp>
28#include <fstream>28#include <fstream>
29
30#pragma GCC diagnostic push
31#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
29#include <gtest/gtest.h>32#include <gtest/gtest.h>
33#pragma GCC diagnostic pop
3034
31using namespace boost;35using namespace boost;
32using namespace testing;36using namespace testing;
@@ -152,7 +156,7 @@
152156
153 // 1st TestScope::find_child_scopes() returns: "A,B,C"157 // 1st TestScope::find_child_scopes() returns: "A,B,C"
154 ChildScopeList return_list = test_scope->child_scopes();158 ChildScopeList return_list = test_scope->child_scopes();
155 ASSERT_EQ(3, return_list.size());159 ASSERT_EQ(3u, return_list.size());
156 EXPECT_EQ("ScopeA", return_list[0].id);160 EXPECT_EQ("ScopeA", return_list[0].id);
157 EXPECT_TRUE(return_list[0].enabled);161 EXPECT_TRUE(return_list[0].enabled);
158 EXPECT_EQ("ScopeB", return_list[1].id);162 EXPECT_EQ("ScopeB", return_list[1].id);
@@ -168,7 +172,7 @@
168172
169 // 2nd TestScope::find_child_scopes() returns: "D,A,B,C,E"173 // 2nd TestScope::find_child_scopes() returns: "D,A,B,C,E"
170 return_list = test_scope->child_scopes();174 return_list = test_scope->child_scopes();
171 ASSERT_EQ(5, return_list.size());175 ASSERT_EQ(5u, return_list.size());
172 EXPECT_EQ("ScopeD", return_list[0].id);176 EXPECT_EQ("ScopeD", return_list[0].id);
173 EXPECT_FALSE(return_list[0].enabled);177 EXPECT_FALSE(return_list[0].enabled);
174 EXPECT_EQ("ScopeA", return_list[1].id);178 EXPECT_EQ("ScopeA", return_list[1].id);
@@ -182,7 +186,7 @@
182186
183 // 3rd+ TestScope::find_child_scopes() returns: "D,A,B"187 // 3rd+ TestScope::find_child_scopes() returns: "D,A,B"
184 return_list = test_scope->child_scopes();188 return_list = test_scope->child_scopes();
185 ASSERT_EQ(3, return_list.size());189 ASSERT_EQ(3u, return_list.size());
186 EXPECT_EQ("ScopeD", return_list[0].id);190 EXPECT_EQ("ScopeD", return_list[0].id);
187 EXPECT_FALSE(return_list[0].enabled);191 EXPECT_FALSE(return_list[0].enabled);
188 EXPECT_EQ("ScopeA", return_list[1].id);192 EXPECT_EQ("ScopeA", return_list[1].id);
@@ -199,7 +203,7 @@
199203
200 // 3rd+ TestScope::find_child_scopes() returns: "D,A,B"204 // 3rd+ TestScope::find_child_scopes() returns: "D,A,B"
201 return_list = test_scope->child_scopes();205 return_list = test_scope->child_scopes();
202 ASSERT_EQ(3, return_list.size());206 ASSERT_EQ(3u, return_list.size());
203 EXPECT_EQ("ScopeD", return_list[0].id);207 EXPECT_EQ("ScopeD", return_list[0].id);
204 EXPECT_TRUE(return_list[0].enabled);208 EXPECT_TRUE(return_list[0].enabled);
205 EXPECT_EQ("ScopeA", return_list[1].id);209 EXPECT_EQ("ScopeA", return_list[1].id);
@@ -216,7 +220,7 @@
216220
217 // 1st TestScope::find_child_scopes() returns: "A,B,C"221 // 1st TestScope::find_child_scopes() returns: "A,B,C"
218 ChildScopeList return_list = test_scope->child_scopes();222 ChildScopeList return_list = test_scope->child_scopes();
219 ASSERT_EQ(3, return_list.size());223 ASSERT_EQ(3u, return_list.size());
220 EXPECT_EQ("ScopeA", return_list[0].id);224 EXPECT_EQ("ScopeA", return_list[0].id);
221 EXPECT_FALSE(return_list[0].enabled);225 EXPECT_FALSE(return_list[0].enabled);
222 EXPECT_EQ("ScopeB", return_list[1].id);226 EXPECT_EQ("ScopeB", return_list[1].id);
@@ -242,7 +246,7 @@
242246
243 // 1st TestScope::find_child_scopes() returns: "A,B,C"247 // 1st TestScope::find_child_scopes() returns: "A,B,C"
244 ChildScopeList return_list = test_scope->child_scopes();248 ChildScopeList return_list = test_scope->child_scopes();
245 ASSERT_EQ(3, return_list.size());249 ASSERT_EQ(3u, return_list.size());
246 EXPECT_EQ("ScopeA", return_list[0].id);250 EXPECT_EQ("ScopeA", return_list[0].id);
247 EXPECT_TRUE(return_list[0].enabled);251 EXPECT_TRUE(return_list[0].enabled);
248 EXPECT_EQ("ScopeB", return_list[1].id);252 EXPECT_EQ("ScopeB", return_list[1].id);
@@ -263,7 +267,7 @@
263267
264 // 1st TestScope::find_child_scopes() returns: "A,B,C"268 // 1st TestScope::find_child_scopes() returns: "A,B,C"
265 ChildScopeList return_list = test_scope->child_scopes();269 ChildScopeList return_list = test_scope->child_scopes();
266 ASSERT_EQ(3, return_list.size());270 ASSERT_EQ(3u, return_list.size());
267 EXPECT_EQ("ScopeA", return_list[0].id);271 EXPECT_EQ("ScopeA", return_list[0].id);
268 EXPECT_TRUE(return_list[0].enabled);272 EXPECT_TRUE(return_list[0].enabled);
269 EXPECT_EQ("ScopeB", return_list[1].id);273 EXPECT_EQ("ScopeB", return_list[1].id);
@@ -278,7 +282,7 @@
278282
279 // Check that nothing crashes and we simply get the list from the scope as is283 // Check that nothing crashes and we simply get the list from the scope as is
280 return_list = test_scope->child_scopes();284 return_list = test_scope->child_scopes();
281 ASSERT_EQ(3, return_list.size());285 ASSERT_EQ(3u, return_list.size());
282 EXPECT_EQ("ScopeA", return_list[0].id);286 EXPECT_EQ("ScopeA", return_list[0].id);
283 EXPECT_TRUE(return_list[0].enabled);287 EXPECT_TRUE(return_list[0].enabled);
284 EXPECT_EQ("ScopeB", return_list[1].id);288 EXPECT_EQ("ScopeB", return_list[1].id);
@@ -293,7 +297,7 @@
293297
294 // Check that nothing crashes and we simply get the list from the scope as is298 // Check that nothing crashes and we simply get the list from the scope as is
295 return_list = test_scope->child_scopes();299 return_list = test_scope->child_scopes();
296 ASSERT_EQ(3, return_list.size());300 ASSERT_EQ(3u, return_list.size());
297 EXPECT_EQ("ScopeA", return_list[0].id);301 EXPECT_EQ("ScopeA", return_list[0].id);
298 EXPECT_TRUE(return_list[0].enabled);302 EXPECT_TRUE(return_list[0].enabled);
299 EXPECT_EQ("ScopeB", return_list[1].id);303 EXPECT_EQ("ScopeB", return_list[1].id);
300304
=== modified file 'test/gtest/scopes/Aggregation/Keywords_test.cpp'
--- test/gtest/scopes/Aggregation/Keywords_test.cpp 2015-12-18 09:21:53 +0000
+++ test/gtest/scopes/Aggregation/Keywords_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,7 +21,11 @@
21#include <unity/scopes/testing/ScopeMetadataBuilder.h>21#include <unity/scopes/testing/ScopeMetadataBuilder.h>
2222
23#include <boost/filesystem/operations.hpp>23#include <boost/filesystem/operations.hpp>
24
25#pragma GCC diagnostic push
26#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>27#include <gtest/gtest.h>
28#pragma GCC diagnostic pop
2529
26#include "AggTestScope.h"30#include "AggTestScope.h"
2731
@@ -157,7 +161,7 @@
157161
158 // Should see all scopes' results here as all children are enabled by default162 // Should see all scopes' results here as all children are enabled by default
159 auto r = receiver->results();163 auto r = receiver->results();
160 EXPECT_EQ(4, r.size());164 EXPECT_EQ(4u, r.size());
161 EXPECT_TRUE(r.find("A") != r.end());165 EXPECT_TRUE(r.find("A") != r.end());
162 EXPECT_TRUE(r.find("B") != r.end());166 EXPECT_TRUE(r.find("B") != r.end());
163 EXPECT_TRUE(r.find("C") != r.end());167 EXPECT_TRUE(r.find("C") != r.end());
@@ -178,7 +182,7 @@
178182
179 // Should not see scope C's results here as it has been disabled183 // Should not see scope C's results here as it has been disabled
180 r = receiver->results();184 r = receiver->results();
181 EXPECT_EQ(3, r.size());185 EXPECT_EQ(3u, r.size());
182 EXPECT_TRUE(r.find("A") != r.end());186 EXPECT_TRUE(r.find("A") != r.end());
183 EXPECT_TRUE(r.find("B") != r.end());187 EXPECT_TRUE(r.find("B") != r.end());
184 EXPECT_TRUE(r.find("D") != r.end());188 EXPECT_TRUE(r.find("D") != r.end());
@@ -198,7 +202,7 @@
198202
199 // Should not see scope C and D's results here as they are disabled203 // Should not see scope C and D's results here as they are disabled
200 r = receiver->results();204 r = receiver->results();
201 EXPECT_EQ(2, r.size());205 EXPECT_EQ(2u, r.size());
202 EXPECT_TRUE(r.find("A") != r.end());206 EXPECT_TRUE(r.find("A") != r.end());
203 EXPECT_TRUE(r.find("B") != r.end());207 EXPECT_TRUE(r.find("B") != r.end());
204208
@@ -217,7 +221,7 @@
217221
218 // Should not see scope D's results here as it is still disabled222 // Should not see scope D's results here as it is still disabled
219 r = receiver->results();223 r = receiver->results();
220 EXPECT_EQ(3, r.size());224 EXPECT_EQ(3u, r.size());
221 EXPECT_TRUE(r.find("A") != r.end());225 EXPECT_TRUE(r.find("A") != r.end());
222 EXPECT_TRUE(r.find("B") != r.end());226 EXPECT_TRUE(r.find("B") != r.end());
223 EXPECT_TRUE(r.find("C") != r.end());227 EXPECT_TRUE(r.find("C") != r.end());
@@ -237,7 +241,7 @@
237241
238 // Should see all scopes' results here as all children are enabled again242 // Should see all scopes' results here as all children are enabled again
239 r = receiver->results();243 r = receiver->results();
240 EXPECT_EQ(4, r.size());244 EXPECT_EQ(4u, r.size());
241 EXPECT_TRUE(r.find("A") != r.end());245 EXPECT_TRUE(r.find("A") != r.end());
242 EXPECT_TRUE(r.find("B") != r.end());246 EXPECT_TRUE(r.find("B") != r.end());
243 EXPECT_TRUE(r.find("C") != r.end());247 EXPECT_TRUE(r.find("C") != r.end());
@@ -267,7 +271,7 @@
267271
268 // Should see all scopes' results here as all children are enabled by default272 // Should see all scopes' results here as all children are enabled by default
269 auto r = receiver->results();273 auto r = receiver->results();
270 EXPECT_EQ(4, r.size());274 EXPECT_EQ(4u, r.size());
271 EXPECT_TRUE(r.find("A") != r.end());275 EXPECT_TRUE(r.find("A") != r.end());
272 EXPECT_TRUE(r.find("B") != r.end());276 EXPECT_TRUE(r.find("B") != r.end());
273 EXPECT_TRUE(r.find("C") != r.end());277 EXPECT_TRUE(r.find("C") != r.end());
274278
=== modified file 'test/gtest/scopes/Aggregation/LoopDetection_test.cpp'
--- test/gtest/scopes/Aggregation/LoopDetection_test.cpp 2015-11-23 10:09:11 +0000
+++ test/gtest/scopes/Aggregation/LoopDetection_test.cpp 2016-11-28 10:48:16 +0000
@@ -20,7 +20,10 @@
20#include <unity/scopes/internal/RuntimeImpl.h>20#include <unity/scopes/internal/RuntimeImpl.h>
21#include <unity/scopes/SearchMetadata.h>21#include <unity/scopes/SearchMetadata.h>
2222
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
23#include <gtest/gtest.h>25#include <gtest/gtest.h>
26#pragma GCC diagnostic pop
2427
25#include "AggTestScope.h"28#include "AggTestScope.h"
2629
@@ -124,7 +127,7 @@
124 receiver->wait_until_finished();127 receiver->wait_until_finished();
125128
126 auto r = receiver->results();129 auto r = receiver->results();
127 EXPECT_EQ(3, r.size());130 EXPECT_EQ(3u, r.size());
128 EXPECT_TRUE(r.find("A") != r.end());131 EXPECT_TRUE(r.find("A") != r.end());
129 EXPECT_TRUE(r.find("B") != r.end());132 EXPECT_TRUE(r.find("B") != r.end());
130 EXPECT_TRUE(r.find("C") != r.end());133 EXPECT_TRUE(r.find("C") != r.end());
@@ -141,12 +144,12 @@
141 receiver->wait_until_finished();144 receiver->wait_until_finished();
142145
143 auto r = receiver->results();146 auto r = receiver->results();
144 EXPECT_EQ(4, r.size());147 EXPECT_EQ(4u, r.size());
145 EXPECT_TRUE(r.find("A") != r.end());148 EXPECT_TRUE(r.find("A") != r.end());
146 EXPECT_TRUE(r.find("B") != r.end());149 EXPECT_TRUE(r.find("B") != r.end());
147 EXPECT_TRUE(r.find("C") != r.end());150 EXPECT_TRUE(r.find("C") != r.end());
148 EXPECT_TRUE(r.find("D") != r.end());151 EXPECT_TRUE(r.find("D") != r.end());
149 EXPECT_EQ(2, r.find("D")->second.size()); // B, and C each forwarded to D, so there must be 2 results.152 EXPECT_EQ(2u, r.find("D")->second.size()); // B, and C each forwarded to D, so there must be 2 results.
150}153}
151154
152TEST_F(LoopDetectionTest, immediate_loop)155TEST_F(LoopDetectionTest, immediate_loop)
@@ -157,8 +160,8 @@
157 receiver->wait_until_finished();160 receiver->wait_until_finished();
158161
159 auto r = receiver->results();162 auto r = receiver->results();
160 EXPECT_EQ(1, r.size());163 EXPECT_EQ(1u, r.size());
161 EXPECT_EQ(3, r.find("A")->second.size()); // "A" has sent the query twice to itself, second attempt stops loop164 EXPECT_EQ(3u, r.find("A")->second.size()); // "A" has sent the query twice to itself, second attempt stops loop
162}165}
163166
164TEST_F(LoopDetectionTest, intermediate_loop)167TEST_F(LoopDetectionTest, intermediate_loop)
@@ -171,10 +174,10 @@
171 receiver->wait_until_finished();174 receiver->wait_until_finished();
172175
173 auto r = receiver->results();176 auto r = receiver->results();
174 EXPECT_EQ(3, r.size());177 EXPECT_EQ(3u, r.size());
175 EXPECT_EQ(2, r.find("A")->second.size()); // "A" got results from B and C178 EXPECT_EQ(2u, r.find("A")->second.size()); // "A" got results from B and C
176 EXPECT_EQ(2, r.find("B")->second.size()); // "B" got results from C and A179 EXPECT_EQ(2u, r.find("B")->second.size()); // "B" got results from C and A
177 EXPECT_EQ(1, r.find("C")->second.size()); // "C" got result from A180 EXPECT_EQ(1u, r.find("C")->second.size()); // "C" got result from A
178}181}
179182
180TEST_F(LoopDetectionTest, repeated_search_on_leaf)183TEST_F(LoopDetectionTest, repeated_search_on_leaf)
@@ -188,11 +191,11 @@
188 receiver->wait_until_finished();191 receiver->wait_until_finished();
189192
190 auto r = receiver->results();193 auto r = receiver->results();
191 EXPECT_EQ(4, r.size());194 EXPECT_EQ(4u, r.size());
192 EXPECT_EQ(1, r.find("A")->second.size());195 EXPECT_EQ(1u, r.find("A")->second.size());
193 EXPECT_EQ(1, r.find("B")->second.size());196 EXPECT_EQ(1u, r.find("B")->second.size());
194 EXPECT_EQ(1, r.find("C")->second.size());197 EXPECT_EQ(1u, r.find("C")->second.size());
195 EXPECT_EQ(3, r.find("D")->second.size());198 EXPECT_EQ(3u, r.find("D")->second.size());
196}199}
197200
198TEST_F(LoopDetectionTest, repeated_search_on_aggregator)201TEST_F(LoopDetectionTest, repeated_search_on_aggregator)
@@ -206,10 +209,10 @@
206 receiver->wait_until_finished();209 receiver->wait_until_finished();
207210
208 auto r = receiver->results();211 auto r = receiver->results();
209 EXPECT_EQ(3, r.size());212 EXPECT_EQ(3u, r.size());
210 EXPECT_EQ(1, r.find("A")->second.size());213 EXPECT_EQ(1u, r.find("A")->second.size());
211 EXPECT_EQ(1, r.find("B")->second.size());214 EXPECT_EQ(1u, r.find("B")->second.size());
212 EXPECT_EQ(1, r.find("C")->second.size());215 EXPECT_EQ(1u, r.find("C")->second.size());
213}216}
214217
215#pragma GCC diagnostic pop218#pragma GCC diagnostic pop
216219
=== modified file 'test/gtest/scopes/Annotation/Annotation_test.cpp'
--- test/gtest/scopes/Annotation/Annotation_test.cpp 2014-11-18 07:04:04 +0000
+++ test/gtest/scopes/Annotation/Annotation_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,11 @@
16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
23
20#include <unity/scopes/Annotation.h>24#include <unity/scopes/Annotation.h>
21#include <unity/scopes/CannedQuery.h>25#include <unity/scopes/CannedQuery.h>
22#include <unity/scopes/internal/CannedQueryImpl.h>26#include <unity/scopes/internal/CannedQueryImpl.h>
2327
=== modified file 'test/gtest/scopes/CannedQuery/CannedQuery_test.cpp'
--- test/gtest/scopes/CannedQuery/CannedQuery_test.cpp 2015-02-27 09:43:40 +0000
+++ test/gtest/scopes/CannedQuery/CannedQuery_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,11 @@
16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
23
20#include <unity/scopes/CannedQuery.h>24#include <unity/scopes/CannedQuery.h>
21#include <unity/scopes/internal/CannedQueryImpl.h>25#include <unity/scopes/internal/CannedQueryImpl.h>
22#include <unity/scopes/OptionSelectorFilter.h>26#include <unity/scopes/OptionSelectorFilter.h>
@@ -278,7 +282,7 @@
278 filter->add_option("o1", "Option 1");282 filter->add_option("o1", "Option 1");
279 filter->add_option("o2", "Option 2");283 filter->add_option("o2", "Option 2");
280 auto actopts = filter->active_options(fstate);284 auto actopts = filter->active_options(fstate);
281 EXPECT_EQ(1, actopts.size());285 EXPECT_EQ(1u, actopts.size());
282 EXPECT_EQ("o1", (*(actopts.begin()))->id());286 EXPECT_EQ("o1", (*(actopts.begin()))->id());
283 }287 }
284 {288 {
285289
=== modified file 'test/gtest/scopes/CategorisedResult/CategorisedResult_test.cpp'
--- test/gtest/scopes/CategorisedResult/CategorisedResult_test.cpp 2015-07-15 15:49:05 +0000
+++ test/gtest/scopes/CategorisedResult/CategorisedResult_test.cpp 2016-11-28 10:48:16 +0000
@@ -23,7 +23,11 @@
23#include <unity/scopes/internal/ReplyObject.h>23#include <unity/scopes/internal/ReplyObject.h>
24#include <unity/scopes/internal/CategorisedResultImpl.h>24#include <unity/scopes/internal/CategorisedResultImpl.h>
25#include <unity/UnityExceptions.h>25#include <unity/UnityExceptions.h>
26
27#pragma GCC diagnostic push
28#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
26#include <gtest/gtest.h>29#include <gtest/gtest.h>
30#pragma GCC diagnostic pop
2731
28using namespace unity::scopes;32using namespace unity::scopes;
29using namespace unity::scopes::internal;33using namespace unity::scopes::internal;
3034
=== modified file 'test/gtest/scopes/Category/Category_test.cpp'
--- test/gtest/scopes/Category/Category_test.cpp 2014-07-02 09:36:34 +0000
+++ test/gtest/scopes/Category/Category_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,7 +21,10 @@
21#include <unity/UnityExceptions.h>21#include <unity/UnityExceptions.h>
22#include <unity/scopes/Variant.h>22#include <unity/scopes/Variant.h>
2323
24#pragma GCC diagnostic push
25#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>26#include <gtest/gtest.h>
27#pragma GCC diagnostic pop
2528
26using namespace std;29using namespace std;
27using namespace unity;30using namespace unity;
2831
=== modified file 'test/gtest/scopes/CategoryRenderer/CategoryRenderer_test.cpp'
--- test/gtest/scopes/CategoryRenderer/CategoryRenderer_test.cpp 2014-07-07 23:53:36 +0000
+++ test/gtest/scopes/CategoryRenderer/CategoryRenderer_test.cpp 2016-11-28 10:48:16 +0000
@@ -19,7 +19,11 @@
19#include <unity/scopes/CategoryRenderer.h>19#include <unity/scopes/CategoryRenderer.h>
20#include <unity/UnityExceptions.h>20#include <unity/UnityExceptions.h>
21#include <fstream>21#include <fstream>
22
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
22#include <gtest/gtest.h>25#include <gtest/gtest.h>
26#pragma GCC diagnostic pop
2327
24using namespace unity::scopes;28using namespace unity::scopes;
25using namespace unity::scopes::internal;29using namespace unity::scopes::internal;
2630
=== modified file 'test/gtest/scopes/ColumnLayout/ColumnLayout_test.cpp'
--- test/gtest/scopes/ColumnLayout/ColumnLayout_test.cpp 2014-02-25 12:08:41 +0000
+++ test/gtest/scopes/ColumnLayout/ColumnLayout_test.cpp 2016-11-28 10:48:16 +0000
@@ -19,7 +19,11 @@
19#include <unity/scopes/ColumnLayout.h>19#include <unity/scopes/ColumnLayout.h>
20#include <unity/scopes/internal/ColumnLayoutImpl.h>20#include <unity/scopes/internal/ColumnLayoutImpl.h>
21#include <unity/UnityExceptions.h>21#include <unity/UnityExceptions.h>
22
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
22#include <gtest/gtest.h>25#include <gtest/gtest.h>
26#pragma GCC diagnostic pop
2327
24using namespace unity::scopes;28using namespace unity::scopes;
25using namespace unity::scopes::internal;29using namespace unity::scopes::internal;
2630
=== modified file 'test/gtest/scopes/DateTimePickerFilter/DateTimePickerFilter_test.cpp'
--- test/gtest/scopes/DateTimePickerFilter/DateTimePickerFilter_test.cpp 2015-11-12 12:45:41 +0000
+++ test/gtest/scopes/DateTimePickerFilter/DateTimePickerFilter_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,11 @@
16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
23
20#include <unity/scopes/FilterState.h>24#include <unity/scopes/FilterState.h>
21#include <unity/scopes/DateTimePickerFilter.h>25#include <unity/scopes/DateTimePickerFilter.h>
22#include <unity/scopes/internal/DateTimePickerFilterImpl.h>26#include <unity/scopes/internal/DateTimePickerFilterImpl.h>
2327
=== modified file 'test/gtest/scopes/Department/Department_test.cpp'
--- test/gtest/scopes/Department/Department_test.cpp 2014-05-28 13:52:22 +0000
+++ test/gtest/scopes/Department/Department_test.cpp 2016-11-28 10:48:16 +0000
@@ -20,7 +20,11 @@
20#include <unity/scopes/internal/DepartmentImpl.h>20#include <unity/scopes/internal/DepartmentImpl.h>
21#include <unity/scopes/CannedQuery.h>21#include <unity/scopes/CannedQuery.h>
22#include <unity/UnityExceptions.h>22#include <unity/UnityExceptions.h>
23
24#pragma GCC diagnostic push
25#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
23#include <gtest/gtest.h>26#include <gtest/gtest.h>
27#pragma GCC diagnostic pop
2428
25using namespace unity::scopes;29using namespace unity::scopes;
26using namespace unity::scopes::internal;30using namespace unity::scopes::internal;
2731
=== modified file 'test/gtest/scopes/Filters/Filters_test.cpp'
--- test/gtest/scopes/Filters/Filters_test.cpp 2016-06-14 14:54:15 +0000
+++ test/gtest/scopes/Filters/Filters_test.cpp 2016-11-28 10:48:16 +0000
@@ -31,8 +31,12 @@
31#include <unity/scopes/ValueSliderLabels.h>31#include <unity/scopes/ValueSliderLabels.h>
32#include <unity/scopes/SearchMetadata.h>32#include <unity/scopes/SearchMetadata.h>
33#include <unity/UnityExceptions.h>33#include <unity/UnityExceptions.h>
34#include <TestScope.h>
35
36#pragma GCC diagnostic push
37#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
34#include <gtest/gtest.h>38#include <gtest/gtest.h>
35#include <TestScope.h>39#pragma GCC diagnostic pop
3640
37using namespace unity::scopes;41using namespace unity::scopes;
38using namespace unity::scopes::experimental;42using namespace unity::scopes::experimental;
3943
=== modified file 'test/gtest/scopes/IdleShutdown/IdleShutdown_test.cpp'
--- test/gtest/scopes/IdleShutdown/IdleShutdown_test.cpp 2015-01-09 03:16:51 +0000
+++ test/gtest/scopes/IdleShutdown/IdleShutdown_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,7 +21,11 @@
21#include <unity/scopes/internal/RuntimeImpl.h>21#include <unity/scopes/internal/RuntimeImpl.h>
22#include <unity/scopes/internal/ScopeImpl.h>22#include <unity/scopes/internal/ScopeImpl.h>
2323
24
25#pragma GCC diagnostic push
26#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>27#include <gtest/gtest.h>
28#pragma GCC diagnostic pop
2529
26#include "SlowSearchScope.h"30#include "SlowSearchScope.h"
2731
2832
=== modified file 'test/gtest/scopes/Invocation/Invocation_test.cpp'
--- test/gtest/scopes/Invocation/Invocation_test.cpp 2015-01-09 03:16:51 +0000
+++ test/gtest/scopes/Invocation/Invocation_test.cpp 2016-11-28 10:48:16 +0000
@@ -30,7 +30,10 @@
3030
31#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.31#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.
3232
33#pragma GCC diagnostic push
34#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
33#include <gtest/gtest.h>35#include <gtest/gtest.h>
36#pragma GCC diagnostic pop
3437
35#include "EmptyScope.h"38#include "EmptyScope.h"
36#include "TestScope.h"39#include "TestScope.h"
3740
=== modified file 'test/gtest/scopes/Location/Location_test.cpp'
--- test/gtest/scopes/Location/Location_test.cpp 2015-03-06 07:56:37 +0000
+++ test/gtest/scopes/Location/Location_test.cpp 2016-11-28 10:48:16 +0000
@@ -18,8 +18,12 @@
1818
19#include <unity/scopes/ScopeExceptions.h>19#include <unity/scopes/ScopeExceptions.h>
20#include <unity/scopes/Location.h>20#include <unity/scopes/Location.h>
21#include <unity/UnityExceptions.h>
22
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
21#include <gtest/gtest.h>25#include <gtest/gtest.h>
22#include <unity/UnityExceptions.h>26#pragma GCC diagnostic pop
2327
24using namespace unity;28using namespace unity;
25using namespace unity::scopes;29using namespace unity::scopes;
2630
=== modified file 'test/gtest/scopes/OnlineAccountClient/OnlineAccountClient_test.cpp'
--- test/gtest/scopes/OnlineAccountClient/OnlineAccountClient_test.cpp 2016-03-16 09:52:22 +0000
+++ test/gtest/scopes/OnlineAccountClient/OnlineAccountClient_test.cpp 2016-11-28 10:48:16 +0000
@@ -28,11 +28,15 @@
28#include <boost/filesystem/operations.hpp>28#include <boost/filesystem/operations.hpp>
29#include <condition_variable>29#include <condition_variable>
30#include <functional>30#include <functional>
31#include <gtest/gtest.h>
32#include <libaccounts-glib/accounts-glib.h>31#include <libaccounts-glib/accounts-glib.h>
33#include <libdbustest/dbus-test.h>32#include <libdbustest/dbus-test.h>
34#include <thread>33#include <thread>
3534
35#pragma GCC diagnostic push
36#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
37#include <gtest/gtest.h>
38#pragma GCC diagnostic pop
39
36using namespace unity;40using namespace unity;
37using namespace unity::scopes;41using namespace unity::scopes;
38using namespace unity::scopes::testing;42using namespace unity::scopes::testing;
@@ -421,13 +425,13 @@
421TEST_F(OnlineAccountClientTest, refresh_services_main_loop)425TEST_F(OnlineAccountClientTest, refresh_services_main_loop)
422{426{
423 auto statuses = oa_client()->get_service_statuses();427 auto statuses = oa_client()->get_service_statuses();
424 EXPECT_EQ(0, statuses.size());428 EXPECT_EQ(0u, statuses.size());
425429
426 create_account();430 create_account();
427 oa_client()->refresh_service_statuses();431 oa_client()->refresh_service_statuses();
428432
429 statuses = oa_client()->get_service_statuses();433 statuses = oa_client()->get_service_statuses();
430 EXPECT_EQ(1, statuses.size());434 EXPECT_EQ(1u, statuses.size());
431 EXPECT_FALSE(statuses[0].service_enabled);435 EXPECT_FALSE(statuses[0].service_enabled);
432436
433 enable_service();437 enable_service();
@@ -464,7 +468,7 @@
464 oa_client()->refresh_service_statuses();468 oa_client()->refresh_service_statuses();
465469
466 statuses = oa_client()->get_service_statuses();470 statuses = oa_client()->get_service_statuses();
467 EXPECT_EQ(0, statuses.size());471 EXPECT_EQ(0u, statuses.size());
468}472}
469473
470TEST_F(OnlineAccountClientTest, service_update_callback)474TEST_F(OnlineAccountClientTest, service_update_callback)
471475
=== modified file 'test/gtest/scopes/OptionSelectorFilter/OptionSelectorFilter_test.cpp'
--- test/gtest/scopes/OptionSelectorFilter/OptionSelectorFilter_test.cpp 2016-03-09 12:06:02 +0000
+++ test/gtest/scopes/OptionSelectorFilter/OptionSelectorFilter_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,12 @@
16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>
17 */17 */
1818
19
20#pragma GCC diagnostic push
21#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>22#include <gtest/gtest.h>
23#pragma GCC diagnostic pop
24
20#include <unity/scopes/FilterState.h>25#include <unity/scopes/FilterState.h>
21#include <unity/scopes/OptionSelectorFilter.h>26#include <unity/scopes/OptionSelectorFilter.h>
22#include <unity/scopes/internal/OptionSelectorFilterImpl.h>27#include <unity/scopes/internal/OptionSelectorFilterImpl.h>
2328
=== modified file 'test/gtest/scopes/PreviewWidget/PreviewWidget_test.cpp'
--- test/gtest/scopes/PreviewWidget/PreviewWidget_test.cpp 2014-08-29 14:11:24 +0000
+++ test/gtest/scopes/PreviewWidget/PreviewWidget_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,7 +21,11 @@
21#include <unity/UnityExceptions.h>21#include <unity/UnityExceptions.h>
22#include <unity/scopes/Variant.h>22#include <unity/scopes/Variant.h>
23#include <unity/scopes/internal/JsonCppNode.h>23#include <unity/scopes/internal/JsonCppNode.h>
24
25#pragma GCC diagnostic push
26#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>27#include <gtest/gtest.h>
28#pragma GCC diagnostic pop
2529
26using namespace unity::scopes;30using namespace unity::scopes;
27using namespace unity::scopes::internal;31using namespace unity::scopes::internal;
2832
=== modified file 'test/gtest/scopes/QueryMetadata/QueryMetadata_test.cpp'
--- test/gtest/scopes/QueryMetadata/QueryMetadata_test.cpp 2015-10-29 06:24:06 +0000
+++ test/gtest/scopes/QueryMetadata/QueryMetadata_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,8 +21,12 @@
21#include <unity/scopes/ActionMetadata.h>21#include <unity/scopes/ActionMetadata.h>
22#include <unity/scopes/internal/ActionMetadataImpl.h>22#include <unity/scopes/internal/ActionMetadataImpl.h>
23#include <unity/scopes/internal/SearchMetadataImpl.h>23#include <unity/scopes/internal/SearchMetadataImpl.h>
24#include <unity/UnityExceptions.h>
25
26#pragma GCC diagnostic push
27#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>28#include <gtest/gtest.h>
25#include <unity/UnityExceptions.h>29#pragma GCC diagnostic pop
2630
27using namespace unity;31using namespace unity;
28using namespace unity::scopes;32using namespace unity::scopes;
2933
=== modified file 'test/gtest/scopes/RadioButtonsFilter/RadioButtonsFilter_test.cpp'
--- test/gtest/scopes/RadioButtonsFilter/RadioButtonsFilter_test.cpp 2015-11-12 12:45:41 +0000
+++ test/gtest/scopes/RadioButtonsFilter/RadioButtonsFilter_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,11 @@
16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
23
20#include <unity/scopes/FilterState.h>24#include <unity/scopes/FilterState.h>
21#include <unity/scopes/RadioButtonsFilter.h>25#include <unity/scopes/RadioButtonsFilter.h>
22#include <unity/UnityExceptions.h>26#include <unity/UnityExceptions.h>
2327
=== modified file 'test/gtest/scopes/RangeInputFilter/RangeInputFilter_test.cpp'
--- test/gtest/scopes/RangeInputFilter/RangeInputFilter_test.cpp 2016-03-09 11:33:52 +0000
+++ test/gtest/scopes/RangeInputFilter/RangeInputFilter_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,11 @@
16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
23
20#include <cmath>24#include <cmath>
21#include <unity/scopes/FilterState.h>25#include <unity/scopes/FilterState.h>
22#include <unity/scopes/RangeInputFilter.h>26#include <unity/scopes/RangeInputFilter.h>
2327
=== modified file 'test/gtest/scopes/RatingFilter/RatingFilter_test.cpp'
--- test/gtest/scopes/RatingFilter/RatingFilter_test.cpp 2014-06-17 10:30:03 +0000
+++ test/gtest/scopes/RatingFilter/RatingFilter_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,12 @@
16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>
17 */17 */
1818
19
20#pragma GCC diagnostic push
21#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>22#include <gtest/gtest.h>
23#pragma GCC diagnostic pop
24
20#include <unity/scopes/FilterState.h>25#include <unity/scopes/FilterState.h>
21#include <unity/scopes/RatingFilter.h>26#include <unity/scopes/RatingFilter.h>
22#include <unity/UnityExceptions.h>27#include <unity/UnityExceptions.h>
2328
=== modified file 'test/gtest/scopes/Registry/Registry_test.cpp'
--- test/gtest/scopes/Registry/Registry_test.cpp 2016-03-31 09:27:33 +0000
+++ test/gtest/scopes/Registry/Registry_test.cpp 2016-11-28 10:48:16 +0000
@@ -24,7 +24,11 @@
24#include <unity/scopes/SearchMetadata.h>24#include <unity/scopes/SearchMetadata.h>
2525
26#include <boost/filesystem/operations.hpp>26#include <boost/filesystem/operations.hpp>
27
28#pragma GCC diagnostic push
29#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
27#include <gtest/gtest.h>30#include <gtest/gtest.h>
31#pragma GCC diagnostic pop
2832
29#include <chrono>33#include <chrono>
30#include <condition_variable>34#include <condition_variable>
@@ -96,7 +100,7 @@
96 EXPECT_EQ("scope-A.SearchHint", meta.search_hint());100 EXPECT_EQ("scope-A.SearchHint", meta.search_hint());
97 EXPECT_EQ(TEST_RUNTIME_PATH "/scopes/testscopeA", meta.scope_directory());101 EXPECT_EQ(TEST_RUNTIME_PATH "/scopes/testscopeA", meta.scope_directory());
98 auto defs = meta.settings_definitions();102 auto defs = meta.settings_definitions();
99 ASSERT_EQ(2, defs.size());103 ASSERT_EQ(2u, defs.size());
100 EXPECT_EQ("locationSetting", defs[0].get_dict()["id"].get_string());104 EXPECT_EQ("locationSetting", defs[0].get_dict()["id"].get_string());
101 EXPECT_EQ("Location", defs[0].get_dict()["displayName"].get_string());105 EXPECT_EQ("Location", defs[0].get_dict()["displayName"].get_string());
102 EXPECT_EQ("string", defs[0].get_dict()["type"].get_string());106 EXPECT_EQ("string", defs[0].get_dict()["type"].get_string());
@@ -144,10 +148,10 @@
144 EXPECT_EQ("scope-B.SearchHint", meta.search_hint());148 EXPECT_EQ("scope-B.SearchHint", meta.search_hint());
145 EXPECT_EQ(TEST_RUNTIME_PATH "/scopes/testscopeB", meta.scope_directory());149 EXPECT_EQ(TEST_RUNTIME_PATH "/scopes/testscopeB", meta.scope_directory());
146 defs = meta.settings_definitions();150 defs = meta.settings_definitions();
147 EXPECT_EQ(0, defs.size());151 EXPECT_EQ(0u, defs.size());
148 EXPECT_FALSE(meta.location_data_needed());152 EXPECT_FALSE(meta.location_data_needed());
149 EXPECT_EQ(0, meta.child_scope_ids().size());153 EXPECT_EQ(0u, meta.child_scope_ids().size());
150 EXPECT_EQ(0, meta.keywords().size());154 EXPECT_EQ(0u, meta.keywords().size());
151 EXPECT_EQ(0, meta.version());155 EXPECT_EQ(0, meta.version());
152 EXPECT_FALSE(meta.is_aggregator());156 EXPECT_FALSE(meta.is_aggregator());
153}157}
@@ -211,7 +215,7 @@
211215
212 auto meta = r->get_metadata("testscopeA");216 auto meta = r->get_metadata("testscopeA");
213 auto defs = meta.settings_definitions();217 auto defs = meta.settings_definitions();
214 EXPECT_EQ(2, defs.size());218 EXPECT_EQ(2u, defs.size());
215 auto sp = meta.proxy();219 auto sp = meta.proxy();
216220
217 // testscopeA should not be running at this point221 // testscopeA should not be running at this point
@@ -228,7 +232,7 @@
228232
229 meta = r->get_metadata("testscopeB");233 meta = r->get_metadata("testscopeB");
230 defs = meta.settings_definitions();234 defs = meta.settings_definitions();
231 EXPECT_EQ(0, defs.size());235 EXPECT_EQ(0u, defs.size());
232 sp = meta.proxy();236 sp = meta.proxy();
233237
234 // testscopeB should not be running at this point238 // testscopeB should not be running at this point
@@ -478,7 +482,7 @@
478482
479 // First check that we have 2 scopes registered483 // First check that we have 2 scopes registered
480 MetadataMap list = r->list();484 MetadataMap list = r->list();
481 EXPECT_EQ(2, list.size());485 EXPECT_EQ(2u, list.size());
482 EXPECT_NE(list.end(), list.find("testscopeA"));486 EXPECT_NE(list.end(), list.find("testscopeA"));
483 EXPECT_NE(list.end(), list.find("testscopeB"));487 EXPECT_NE(list.end(), list.find("testscopeB"));
484 EXPECT_EQ(list.end(), list.find("testscopeC"));488 EXPECT_EQ(list.end(), list.find("testscopeC"));
@@ -496,7 +500,7 @@
496500
497 // Now check that we have 3 scopes registered501 // Now check that we have 3 scopes registered
498 list = r->list();502 list = r->list();
499 EXPECT_EQ(3, list.size());503 EXPECT_EQ(3u, list.size());
500 EXPECT_NE(list.end(), list.find("testscopeA"));504 EXPECT_NE(list.end(), list.find("testscopeA"));
501 EXPECT_NE(list.end(), list.find("testscopeB"));505 EXPECT_NE(list.end(), list.find("testscopeB"));
502 EXPECT_NE(list.end(), list.find("testscopeC"));506 EXPECT_NE(list.end(), list.find("testscopeC"));
@@ -540,7 +544,7 @@
540544
541 // First check that we have 2 scopes registered545 // First check that we have 2 scopes registered
542 MetadataMap list = r->list();546 MetadataMap list = r->list();
543 EXPECT_EQ(2, list.size());547 EXPECT_EQ(2u, list.size());
544 EXPECT_NE(list.end(), list.find("testscopeA"));548 EXPECT_NE(list.end(), list.find("testscopeA"));
545 EXPECT_NE(list.end(), list.find("testscopeB"));549 EXPECT_NE(list.end(), list.find("testscopeB"));
546 EXPECT_EQ(list.end(), list.find("testscopeC"));550 EXPECT_EQ(list.end(), list.find("testscopeC"));
@@ -559,7 +563,7 @@
559563
560 // Now check that we have 3 scopes registered564 // Now check that we have 3 scopes registered
561 list = r->list();565 list = r->list();
562 EXPECT_EQ(3, list.size());566 EXPECT_EQ(3u, list.size());
563 EXPECT_NE(list.end(), list.find("testscopeA"));567 EXPECT_NE(list.end(), list.find("testscopeA"));
564 EXPECT_NE(list.end(), list.find("testscopeB"));568 EXPECT_NE(list.end(), list.find("testscopeB"));
565 EXPECT_NE(list.end(), list.find("testscopeC"));569 EXPECT_NE(list.end(), list.find("testscopeC"));
@@ -617,7 +621,7 @@
617621
618 // Now check that we have 3 scopes registered again622 // Now check that we have 3 scopes registered again
619 list = r->list();623 list = r->list();
620 EXPECT_EQ(3, list.size());624 EXPECT_EQ(3u, list.size());
621 EXPECT_NE(list.end(), list.find("testscopeA"));625 EXPECT_NE(list.end(), list.find("testscopeA"));
622 EXPECT_NE(list.end(), list.find("testscopeB"));626 EXPECT_NE(list.end(), list.find("testscopeB"));
623 EXPECT_EQ(list.end(), list.find("testscopeC"));627 EXPECT_EQ(list.end(), list.find("testscopeC"));
@@ -632,7 +636,7 @@
632636
633 // Now check that we are back to having 2 scopes registered637 // Now check that we are back to having 2 scopes registered
634 list = r->list();638 list = r->list();
635 EXPECT_EQ(2, list.size());639 EXPECT_EQ(2u, list.size());
636 EXPECT_NE(list.end(), list.find("testscopeA"));640 EXPECT_NE(list.end(), list.find("testscopeA"));
637 EXPECT_NE(list.end(), list.find("testscopeB"));641 EXPECT_NE(list.end(), list.find("testscopeB"));
638 EXPECT_EQ(list.end(), list.find("testscopeC"));642 EXPECT_EQ(list.end(), list.find("testscopeC"));
@@ -645,7 +649,7 @@
645649
646 // Check that no scopes were registered650 // Check that no scopes were registered
647 list = r->list();651 list = r->list();
648 EXPECT_EQ(2, list.size());652 EXPECT_EQ(2u, list.size());
649 EXPECT_NE(list.end(), list.find("testscopeA"));653 EXPECT_NE(list.end(), list.find("testscopeA"));
650 EXPECT_NE(list.end(), list.find("testscopeB"));654 EXPECT_NE(list.end(), list.find("testscopeB"));
651 EXPECT_EQ(list.end(), list.find("testscopeC"));655 EXPECT_EQ(list.end(), list.find("testscopeC"));
@@ -660,7 +664,7 @@
660664
661 // Now check that we have 3 scopes registered665 // Now check that we have 3 scopes registered
662 list = r->list();666 list = r->list();
663 EXPECT_EQ(3, list.size());667 EXPECT_EQ(3u, list.size());
664 EXPECT_NE(list.end(), list.find("testscopeA"));668 EXPECT_NE(list.end(), list.find("testscopeA"));
665 EXPECT_NE(list.end(), list.find("testscopeB"));669 EXPECT_NE(list.end(), list.find("testscopeB"));
666 EXPECT_NE(list.end(), list.find("testscopeC"));670 EXPECT_NE(list.end(), list.find("testscopeC"));
@@ -675,7 +679,7 @@
675679
676 // Now check that we are back to having 2 scopes registered680 // Now check that we are back to having 2 scopes registered
677 list = r->list();681 list = r->list();
678 EXPECT_EQ(2, list.size());682 EXPECT_EQ(2u, list.size());
679 EXPECT_NE(list.end(), list.find("testscopeA"));683 EXPECT_NE(list.end(), list.find("testscopeA"));
680 EXPECT_NE(list.end(), list.find("testscopeB"));684 EXPECT_NE(list.end(), list.find("testscopeB"));
681 EXPECT_EQ(list.end(), list.find("testscopeC"));685 EXPECT_EQ(list.end(), list.find("testscopeC"));
682686
=== modified file 'test/gtest/scopes/ReplyReaper/NoReplyScope.cpp'
--- test/gtest/scopes/ReplyReaper/NoReplyScope.cpp 2014-07-29 05:50:14 +0000
+++ test/gtest/scopes/ReplyReaper/NoReplyScope.cpp 2016-11-28 10:48:16 +0000
@@ -22,7 +22,10 @@
2222
23#include <thread>23#include <thread>
2424
25#pragma GCC diagnostic push
26#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
25#include <gtest/gtest.h>27#include <gtest/gtest.h>
28#pragma GCC diagnostic pop
2629
27using namespace std;30using namespace std;
28using namespace unity::scopes;31using namespace unity::scopes;
2932
=== modified file 'test/gtest/scopes/ReplyReaper/ReplyReaper_test.cpp'
--- test/gtest/scopes/ReplyReaper/ReplyReaper_test.cpp 2015-01-09 03:16:51 +0000
+++ test/gtest/scopes/ReplyReaper/ReplyReaper_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,7 +21,11 @@
21#include <unity/scopes/internal/ScopeImpl.h>21#include <unity/scopes/internal/ScopeImpl.h>
2222
23#include <boost/algorithm/string.hpp>23#include <boost/algorithm/string.hpp>
24
25#pragma GCC diagnostic push
26#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>27#include <gtest/gtest.h>
28#pragma GCC diagnostic pop
2529
26#include "NoReplyScope.h"30#include "NoReplyScope.h"
27#include <stdexcept>31#include <stdexcept>
2832
=== modified file 'test/gtest/scopes/ResultCache/ResultCache_test.cpp'
--- test/gtest/scopes/ResultCache/ResultCache_test.cpp 2016-06-14 14:54:15 +0000
+++ test/gtest/scopes/ResultCache/ResultCache_test.cpp 2016-11-28 10:48:16 +0000
@@ -23,7 +23,12 @@
23#include <unity/scopes/OptionSelectorFilter.h>23#include <unity/scopes/OptionSelectorFilter.h>
2424
25#include <boost/filesystem.hpp>25#include <boost/filesystem.hpp>
26
27#pragma GCC diagnostic push
28#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
26#include <gtest/gtest.h>29#include <gtest/gtest.h>
30#pragma GCC diagnostic pop
31
27#include <cstdint>32#include <cstdint>
2833
29#include "CacheScope.h"34#include "CacheScope.h"
@@ -145,7 +150,7 @@
145 receiver->wait_until_finished();150 receiver->wait_until_finished();
146151
147 auto r = receiver->result();152 auto r = receiver->result();
148 EXPECT_EQ(r, nullptr);153 EXPECT_EQ(nullptr, r);
149}154}
150155
151TEST_F(CacheScopeTest, non_surfacing_query)156TEST_F(CacheScopeTest, non_surfacing_query)
@@ -157,11 +162,11 @@
157 receiver->wait_until_finished();162 receiver->wait_until_finished();
158163
159 auto r = receiver->result();164 auto r = receiver->result();
160 EXPECT_EQ(r->title(), "some query");165 EXPECT_EQ("some query", r->title());
161 auto d = receiver->dept();166 auto d = receiver->dept();
162 EXPECT_EQ(d->id(), "");167 EXPECT_EQ("", d->id());
163 auto sd = *d->subdepartments().begin();168 auto sd = *d->subdepartments().begin();
164 EXPECT_EQ(sd->id(), "subsome query");169 EXPECT_EQ("subsome query", sd->id());
165170
166 // Non-empty query, so there must be no cache file.171 // Non-empty query, so there must be no cache file.
167 boost::system::error_code ec;172 boost::system::error_code ec;
@@ -181,13 +186,13 @@
181 receiver->wait_until_finished();186 receiver->wait_until_finished();
182187
183 auto r = receiver->result();188 auto r = receiver->result();
184 EXPECT_EQ(r->title(), "");189 EXPECT_EQ("", r->title());
185 EXPECT_EQ(r->value("int64value").get_int64_t(), 1);190 EXPECT_EQ(1, r->value("int64value").get_int64_t());
186 EXPECT_EQ(r->value("int64value2").get_int64_t(), INT64_MAX);191 EXPECT_EQ(INT64_MAX, r->value("int64value2").get_int64_t());
187 auto d = receiver->dept();192 auto d = receiver->dept();
188 EXPECT_EQ(d->id(), "");193 EXPECT_EQ("", d->id());
189 auto sd = *d->subdepartments().begin();194 auto sd = *d->subdepartments().begin();
190 EXPECT_EQ(sd->id(), "sub");195 EXPECT_EQ("sub", sd->id());
191196
192 // Empty query, so there must be a cache file.197 // Empty query, so there must be a cache file.
193 boost::system::error_code ec;198 boost::system::error_code ec;
@@ -207,11 +212,11 @@
207 receiver->wait_until_finished();212 receiver->wait_until_finished();
208213
209 auto r = receiver->result();214 auto r = receiver->result();
210 EXPECT_EQ(r->title(), "some other query");215 EXPECT_EQ("some other query", r->title());
211 auto d = receiver->dept();216 auto d = receiver->dept();
212 EXPECT_EQ(d->id(), "");217 EXPECT_EQ("", d->id());
213 auto sd = *d->subdepartments().begin();218 auto sd = *d->subdepartments().begin();
214 EXPECT_EQ(sd->id(), "subsome other query");219 EXPECT_EQ("subsome other query", sd->id());
215220
216 // Cache file must still be there.221 // Cache file must still be there.
217 boost::system::error_code ec;222 boost::system::error_code ec;
@@ -225,15 +230,15 @@
225 receiver->wait_until_finished();230 receiver->wait_until_finished();
226231
227 auto r = receiver->result();232 auto r = receiver->result();
228 EXPECT_EQ(r->title(), "");233 EXPECT_EQ("", r->title());
229 EXPECT_EQ(r->value("int64value").get_int(), 1);234 EXPECT_EQ(1, r->value("int64value").get_int());
230 EXPECT_EQ(r->value("int64value2").get_int64_t(), INT64_MAX);235 EXPECT_EQ(INT64_MAX, r->value("int64value2").get_int64_t());
231 auto d = receiver->dept();236 auto d = receiver->dept();
232 EXPECT_EQ(d->id(), "");237 EXPECT_EQ("", d->id());
233 auto sd = *d->subdepartments().begin();238 auto sd = *d->subdepartments().begin();
234 EXPECT_EQ(sd->id(), "sub");239 EXPECT_EQ("sub", sd->id());
235 auto filters = receiver->filters();240 auto filters = receiver->filters();
236 ASSERT_EQ(1, filters.size());241 ASSERT_EQ(1u, filters.size());
237 auto f = *filters.begin();242 auto f = *filters.begin();
238 EXPECT_EQ("option_selector", f->filter_type());243 EXPECT_EQ("option_selector", f->filter_type());
239 EXPECT_EQ(nullptr, f->filter_group());244 EXPECT_EQ(nullptr, f->filter_group());
@@ -262,15 +267,15 @@
262267
263 auto r = receiver->result();268 auto r = receiver->result();
264 ASSERT_TRUE(r != nullptr);269 ASSERT_TRUE(r != nullptr);
265 EXPECT_EQ(r->title(), "");270 EXPECT_EQ("", r->title());
266 EXPECT_EQ(r->value("int64value").get_int(), 1);271 EXPECT_EQ(1, r->value("int64value").get_int());
267 EXPECT_EQ(r->value("int64value2").get_int64_t(), INT64_MAX);272 EXPECT_EQ(INT64_MAX, r->value("int64value2").get_int64_t());
268 auto d = receiver->dept();273 auto d = receiver->dept();
269 EXPECT_EQ(d->id(), "");274 EXPECT_EQ("", d->id());
270 auto sd = *d->subdepartments().begin();275 auto sd = *d->subdepartments().begin();
271 EXPECT_EQ(sd->id(), "sub");276 EXPECT_EQ("sub", sd->id());
272 auto filters = receiver->filters();277 auto filters = receiver->filters();
273 ASSERT_EQ(1, filters.size());278 ASSERT_EQ(1u, filters.size());
274 auto f = *filters.begin();279 auto f = *filters.begin();
275 EXPECT_EQ("option_selector", f->filter_type());280 EXPECT_EQ("option_selector", f->filter_type());
276 ASSERT_TRUE(f->filter_group() != nullptr);281 ASSERT_TRUE(f->filter_group() != nullptr);
@@ -317,14 +322,14 @@
317 receiver->wait_until_finished();322 receiver->wait_until_finished();
318323
319 auto r = receiver->result();324 auto r = receiver->result();
320 EXPECT_EQ(r->title(), "");325 EXPECT_EQ("", r->title());
321 EXPECT_EQ(r->value("int64value").get_int64_t(), 1);326 EXPECT_EQ(1, r->value("int64value").get_int64_t());
322 auto d = receiver->dept();327 auto d = receiver->dept();
323 EXPECT_EQ(d->id(), "");328 EXPECT_EQ("", d->id());
324 auto sd = *d->subdepartments().begin();329 auto sd = *d->subdepartments().begin();
325 EXPECT_EQ(sd->id(), "sub");330 EXPECT_EQ("sub", sd->id());
326 auto filters = receiver->filters();331 auto filters = receiver->filters();
327 ASSERT_EQ(1, filters.size());332 ASSERT_EQ(1u, filters.size());
328 auto f = *filters.begin();333 auto f = *filters.begin();
329 EXPECT_EQ("option_selector", f->filter_type());334 EXPECT_EQ("option_selector", f->filter_type());
330 auto osf = dynamic_pointer_cast<OptionSelectorFilter const>(f);335 auto osf = dynamic_pointer_cast<OptionSelectorFilter const>(f);
@@ -342,7 +347,7 @@
342 auto receiver = make_shared<Receiver>();347 auto receiver = make_shared<Receiver>();
343 scope()->search("", SearchMetadata("unused", "unused"), receiver);348 scope()->search("", SearchMetadata("unused", "unused"), receiver);
344 receiver->wait_until_finished();349 receiver->wait_until_finished();
345 EXPECT_EQ(receiver->result(), nullptr);350 EXPECT_EQ(nullptr, receiver->result());
346 ::chmod(TEST_RUNTIME_PATH "/unconfined/CacheScope/.surfacing_cache", 0600);351 ::chmod(TEST_RUNTIME_PATH "/unconfined/CacheScope/.surfacing_cache", 0600);
347352
348 // Cache file must still be there, but read will have failed.353 // Cache file must still be there, but read will have failed.
@@ -362,7 +367,7 @@
362 auto receiver = make_shared<Receiver>();367 auto receiver = make_shared<Receiver>();
363 scope()->search("", SearchMetadata("unused", "unused"), receiver);368 scope()->search("", SearchMetadata("unused", "unused"), receiver);
364 receiver->wait_until_finished();369 receiver->wait_until_finished();
365 EXPECT_EQ(receiver->result(), nullptr);370 EXPECT_EQ(nullptr, receiver->result());
366371
367 // Cache file must still be there, but decode will have failed.372 // Cache file must still be there, but decode will have failed.
368 boost::system::error_code ec;373 boost::system::error_code ec;
@@ -376,7 +381,7 @@
376 auto receiver = make_shared<Receiver>();381 auto receiver = make_shared<Receiver>();
377 scope()->search("", SearchMetadata("unused", "unused"), receiver);382 scope()->search("", SearchMetadata("unused", "unused"), receiver);
378 receiver->wait_until_finished();383 receiver->wait_until_finished();
379 EXPECT_EQ(receiver->result(), nullptr);384 EXPECT_EQ(nullptr, receiver->result());
380385
381 // Cache file must still be there, but decode will have failed.386 // Cache file must still be there, but decode will have failed.
382 boost::system::error_code ec;387 boost::system::error_code ec;
@@ -390,7 +395,7 @@
390 auto receiver = make_shared<Receiver>();395 auto receiver = make_shared<Receiver>();
391 scope()->search("", SearchMetadata("unused", "unused"), receiver);396 scope()->search("", SearchMetadata("unused", "unused"), receiver);
392 receiver->wait_until_finished();397 receiver->wait_until_finished();
393 EXPECT_EQ(receiver->result(), nullptr);398 EXPECT_EQ(nullptr, receiver->result());
394399
395 // Cache file must still be there, but decode will have failed.400 // Cache file must still be there, but decode will have failed.
396 boost::system::error_code ec;401 boost::system::error_code ec;
@@ -404,7 +409,7 @@
404 auto receiver = make_shared<Receiver>();409 auto receiver = make_shared<Receiver>();
405 scope()->search("", SearchMetadata("unused", "unused"), receiver);410 scope()->search("", SearchMetadata("unused", "unused"), receiver);
406 receiver->wait_until_finished();411 receiver->wait_until_finished();
407 EXPECT_EQ(receiver->result(), nullptr);412 EXPECT_EQ(nullptr, receiver->result());
408413
409 // Cache file must still be there, but decode will have failed.414 // Cache file must still be there, but decode will have failed.
410 boost::system::error_code ec;415 boost::system::error_code ec;
411416
=== modified file 'test/gtest/scopes/Runtime/PusherScope.cpp'
--- test/gtest/scopes/Runtime/PusherScope.cpp 2014-07-30 20:39:04 +0000
+++ test/gtest/scopes/Runtime/PusherScope.cpp 2016-11-28 10:48:16 +0000
@@ -25,7 +25,10 @@
2525
26#include <atomic>26#include <atomic>
2727
28#pragma GCC diagnostic push
29#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
28#include <gtest/gtest.h>30#include <gtest/gtest.h>
31#pragma GCC diagnostic pop
2932
30using namespace std;33using namespace std;
31using namespace unity::scopes;34using namespace unity::scopes;
3235
=== modified file 'test/gtest/scopes/Runtime/Runtime_test.cpp'
--- test/gtest/scopes/Runtime/Runtime_test.cpp 2015-01-09 03:16:51 +0000
+++ test/gtest/scopes/Runtime/Runtime_test.cpp 2016-11-28 10:48:16 +0000
@@ -28,7 +28,10 @@
28#include <unity/scopes/SearchMetadata.h>28#include <unity/scopes/SearchMetadata.h>
29#include <unity/UnityExceptions.h>29#include <unity/UnityExceptions.h>
3030
31#pragma GCC diagnostic push
32#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
31#include <gtest/gtest.h>33#include <gtest/gtest.h>
34#pragma GCC diagnostic pop
3235
33#include "PusherScope.h"36#include "PusherScope.h"
34#include "SlowCreateScope.h"37#include "SlowCreateScope.h"
@@ -113,7 +116,7 @@
113 EXPECT_EQ(1, annotation_count_);116 EXPECT_EQ(1, annotation_count_);
114 EXPECT_EQ(2, info_count_);117 EXPECT_EQ(2, info_count_);
115118
116 EXPECT_EQ(2, details.info_list().size());119 EXPECT_EQ(2u, details.info_list().size());
117 if (details.info_list().size() == 2)120 if (details.info_list().size() == 2)
118 {121 {
119 EXPECT_EQ(OperationInfo::NoInternet, details.info_list()[0].code());122 EXPECT_EQ(OperationInfo::NoInternet, details.info_list()[0].code());
@@ -201,7 +204,7 @@
201 EXPECT_EQ(2, data_pushes_);204 EXPECT_EQ(2, data_pushes_);
202 EXPECT_EQ(2, info_count_);205 EXPECT_EQ(2, info_count_);
203206
204 EXPECT_EQ(2, details.info_list().size());207 EXPECT_EQ(2u, details.info_list().size());
205 if (details.info_list().size() == 2)208 if (details.info_list().size() == 2)
206 {209 {
207 EXPECT_EQ(OperationInfo::NoLocationData, details.info_list()[0].code());210 EXPECT_EQ(OperationInfo::NoLocationData, details.info_list()[0].code());
208211
=== modified file 'test/gtest/scopes/Runtime/SlowCreateScope.cpp'
--- test/gtest/scopes/Runtime/SlowCreateScope.cpp 2014-09-08 05:55:39 +0000
+++ test/gtest/scopes/Runtime/SlowCreateScope.cpp 2016-11-28 10:48:16 +0000
@@ -24,7 +24,10 @@
24#include <mutex>24#include <mutex>
25#include <thread>25#include <thread>
2626
27#pragma GCC diagnostic push
28#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
27#include <gtest/gtest.h>29#include <gtest/gtest.h>
30#pragma GCC diagnostic pop
2831
29using namespace std;32using namespace std;
30using namespace unity::scopes;33using namespace unity::scopes;
3134
=== modified file 'test/gtest/scopes/Runtime/TestScope.cpp'
--- test/gtest/scopes/Runtime/TestScope.cpp 2014-07-30 20:39:04 +0000
+++ test/gtest/scopes/Runtime/TestScope.cpp 2016-11-28 10:48:16 +0000
@@ -25,7 +25,11 @@
25#include <unity/scopes/ScopeBase.h>25#include <unity/scopes/ScopeBase.h>
26#include <unity/scopes/SearchReply.h>26#include <unity/scopes/SearchReply.h>
27#include <unity/UnityExceptions.h>27#include <unity/UnityExceptions.h>
28
29#pragma GCC diagnostic push
30#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
28#include <gtest/gtest.h>31#include <gtest/gtest.h>
32#pragma GCC diagnostic pop
2933
30#include "TestScope.h"34#include "TestScope.h"
3135
3236
=== modified file 'test/gtest/scopes/ScopeBase/ScopeBase_test.cpp'
--- test/gtest/scopes/ScopeBase/ScopeBase_test.cpp 2014-07-10 06:39:03 +0000
+++ test/gtest/scopes/ScopeBase/ScopeBase_test.cpp 2016-11-28 10:48:16 +0000
@@ -20,7 +20,10 @@
20#include <unity/scopes/internal/DynamicLoader.h>20#include <unity/scopes/internal/DynamicLoader.h>
21#include <unity/UnityExceptions.h>21#include <unity/UnityExceptions.h>
2222
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
23#include <gtest/gtest.h>25#include <gtest/gtest.h>
26#pragma GCC diagnostic pop
2427
25using namespace unity::scopes;28using namespace unity::scopes;
26using namespace unity::scopes::internal;29using namespace unity::scopes::internal;
2730
=== modified file 'test/gtest/scopes/ScopeExceptions/ScopeExceptions_test.cpp'
--- test/gtest/scopes/ScopeExceptions/ScopeExceptions_test.cpp 2014-04-17 01:36:29 +0000
+++ test/gtest/scopes/ScopeExceptions/ScopeExceptions_test.cpp 2016-11-28 10:48:16 +0000
@@ -18,7 +18,10 @@
1818
19#include <unity/scopes/ScopeExceptions.h>19#include <unity/scopes/ScopeExceptions.h>
2020
21#pragma GCC diagnostic push
22#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
21#include <gtest/gtest.h>23#include <gtest/gtest.h>
24#pragma GCC diagnostic pop
2225
23using namespace std;26using namespace std;
24using namespace unity::scopes;27using namespace unity::scopes;
2528
=== modified file 'test/gtest/scopes/StandAloneScope/StandAloneScope_test.cpp'
--- test/gtest/scopes/StandAloneScope/StandAloneScope_test.cpp 2015-08-05 05:59:00 +0000
+++ test/gtest/scopes/StandAloneScope/StandAloneScope_test.cpp 2016-11-28 10:48:16 +0000
@@ -22,7 +22,10 @@
22#include <unity/scopes/SearchListenerBase.h>22#include <unity/scopes/SearchListenerBase.h>
23#include <unity/scopes/SearchMetadata.h>23#include <unity/scopes/SearchMetadata.h>
2424
25#pragma GCC diagnostic push
26#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
25#include <gtest/gtest.h>27#include <gtest/gtest.h>
28#pragma GCC diagnostic pop
2629
27#include <chrono>30#include <chrono>
28#include <condition_variable>31#include <condition_variable>
2932
=== modified file 'test/gtest/scopes/StripLocation/StripLocation_test.cpp'
--- test/gtest/scopes/StripLocation/StripLocation_test.cpp 2015-03-02 07:04:42 +0000
+++ test/gtest/scopes/StripLocation/StripLocation_test.cpp 2016-11-28 10:48:16 +0000
@@ -20,7 +20,10 @@
20#include <unity/scopes/internal/RuntimeImpl.h>20#include <unity/scopes/internal/RuntimeImpl.h>
21#include <unity/scopes/SearchMetadata.h>21#include <unity/scopes/SearchMetadata.h>
2222
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
23#include <gtest/gtest.h>25#include <gtest/gtest.h>
26#pragma GCC diagnostic pop
2427
25using namespace std;28using namespace std;
26using namespace unity::scopes;29using namespace unity::scopes;
2730
=== modified file 'test/gtest/scopes/SwitchFilter/SwitchFilter_test.cpp'
--- test/gtest/scopes/SwitchFilter/SwitchFilter_test.cpp 2015-11-12 12:45:41 +0000
+++ test/gtest/scopes/SwitchFilter/SwitchFilter_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,11 @@
16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
23
20#include <unity/scopes/FilterState.h>24#include <unity/scopes/FilterState.h>
21#include <unity/scopes/SwitchFilter.h>25#include <unity/scopes/SwitchFilter.h>
22#include <unity/scopes/internal/SwitchFilterImpl.h>26#include <unity/scopes/internal/SwitchFilterImpl.h>
2327
=== modified file 'test/gtest/scopes/ThrowingClient/ThrowingClient_test.cpp'
--- test/gtest/scopes/ThrowingClient/ThrowingClient_test.cpp 2015-11-26 05:48:01 +0000
+++ test/gtest/scopes/ThrowingClient/ThrowingClient_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,7 +21,10 @@
2121
22#include <unity/UnityExceptions.h>22#include <unity/UnityExceptions.h>
2323
24#pragma GCC diagnostic push
25#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>26#include <gtest/gtest.h>
27#pragma GCC diagnostic pop
2528
26#include <condition_variable>29#include <condition_variable>
2730
@@ -325,7 +328,7 @@
325 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());328 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
326 EXPECT_EQ("", receiver->completion_msg());329 EXPECT_EQ("", receiver->completion_msg());
327 auto r = receiver->results();330 auto r = receiver->results();
328 ASSERT_EQ(1, r.size());331 ASSERT_EQ(1u, r.size());
329 EXPECT_EQ("success", r[0].title());332 EXPECT_EQ("success", r[0].title());
330}333}
331334
@@ -413,7 +416,7 @@
413 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());416 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
414 EXPECT_EQ("", receiver->completion_msg());417 EXPECT_EQ("", receiver->completion_msg());
415 auto r = receiver->results();418 auto r = receiver->results();
416 ASSERT_EQ(1, r.size());419 ASSERT_EQ(1u, r.size());
417 EXPECT_EQ(r[0].title(), "success");420 EXPECT_EQ(r[0].title(), "success");
418421
419 auto plistener = make_shared<PreviewListener>();422 auto plistener = make_shared<PreviewListener>();
@@ -433,7 +436,7 @@
433 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());436 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
434 EXPECT_EQ("", receiver->completion_msg());437 EXPECT_EQ("", receiver->completion_msg());
435 auto r = receiver->results();438 auto r = receiver->results();
436 ASSERT_EQ(1, r.size());439 ASSERT_EQ(1u, r.size());
437 EXPECT_EQ(r[0].title(), "success");440 EXPECT_EQ(r[0].title(), "success");
438441
439 auto plistener = make_shared<PreviewListener>("throw from preview push layout");442 auto plistener = make_shared<PreviewListener>("throw from preview push layout");
@@ -454,7 +457,7 @@
454 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());457 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
455 EXPECT_EQ("", receiver->completion_msg());458 EXPECT_EQ("", receiver->completion_msg());
456 auto r = receiver->results();459 auto r = receiver->results();
457 ASSERT_EQ(1, r.size());460 ASSERT_EQ(1u, r.size());
458 EXPECT_EQ(r[0].title(), "success");461 EXPECT_EQ(r[0].title(), "success");
459462
460 auto plistener = make_shared<PreviewListener>("throw from preview push widget");463 auto plistener = make_shared<PreviewListener>("throw from preview push widget");
@@ -475,7 +478,7 @@
475 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());478 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
476 EXPECT_EQ("", receiver->completion_msg());479 EXPECT_EQ("", receiver->completion_msg());
477 auto r = receiver->results();480 auto r = receiver->results();
478 ASSERT_EQ(1, r.size());481 ASSERT_EQ(1u, r.size());
479 EXPECT_EQ(r[0].title(), "success");482 EXPECT_EQ(r[0].title(), "success");
480483
481 auto plistener = make_shared<PreviewListener>("throw from preview push attribute");484 auto plistener = make_shared<PreviewListener>("throw from preview push attribute");
@@ -496,7 +499,7 @@
496 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());499 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
497 EXPECT_EQ("", receiver->completion_msg());500 EXPECT_EQ("", receiver->completion_msg());
498 auto r = receiver->results();501 auto r = receiver->results();
499 ASSERT_EQ(1, r.size());502 ASSERT_EQ(1u, r.size());
500 EXPECT_EQ(r[0].title(), "success");503 EXPECT_EQ(r[0].title(), "success");
501504
502 auto plistener = make_shared<PreviewListener>("throw from preview finished");505 auto plistener = make_shared<PreviewListener>("throw from preview finished");
@@ -516,7 +519,7 @@
516 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());519 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
517 EXPECT_EQ("", receiver->completion_msg());520 EXPECT_EQ("", receiver->completion_msg());
518 auto r = receiver->results();521 auto r = receiver->results();
519 ASSERT_EQ(1, r.size());522 ASSERT_EQ(1u, r.size());
520 EXPECT_EQ(r[0].title(), "success");523 EXPECT_EQ(r[0].title(), "success");
521524
522 auto alistener = make_shared<ActivationListener>();525 auto alistener = make_shared<ActivationListener>();
@@ -536,7 +539,7 @@
536 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());539 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
537 EXPECT_EQ("", receiver->completion_msg());540 EXPECT_EQ("", receiver->completion_msg());
538 auto r = receiver->results();541 auto r = receiver->results();
539 ASSERT_EQ(1, r.size());542 ASSERT_EQ(1u, r.size());
540 EXPECT_EQ(r[0].title(), "success");543 EXPECT_EQ(r[0].title(), "success");
541544
542 auto alistener = make_shared<ActivationListener>("throw from activation activate");545 auto alistener = make_shared<ActivationListener>("throw from activation activate");
@@ -557,7 +560,7 @@
557 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());560 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
558 EXPECT_EQ("", receiver->completion_msg());561 EXPECT_EQ("", receiver->completion_msg());
559 auto r = receiver->results();562 auto r = receiver->results();
560 ASSERT_EQ(1, r.size());563 ASSERT_EQ(1u, r.size());
561 EXPECT_EQ(r[0].title(), "success");564 EXPECT_EQ(r[0].title(), "success");
562565
563 auto alistener = make_shared<ActivationListener>("throw from activation finished");566 auto alistener = make_shared<ActivationListener>("throw from activation finished");
564567
=== modified file 'test/gtest/scopes/ThrowingScope/ThrowingScope_test.cpp'
--- test/gtest/scopes/ThrowingScope/ThrowingScope_test.cpp 2015-02-06 06:33:23 +0000
+++ test/gtest/scopes/ThrowingScope/ThrowingScope_test.cpp 2016-11-28 10:48:16 +0000
@@ -20,7 +20,10 @@
20#include <unity/scopes/QueryCtrl.h>20#include <unity/scopes/QueryCtrl.h>
21#include <unity/scopes/Runtime.h>21#include <unity/scopes/Runtime.h>
2222
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
23#include <gtest/gtest.h>25#include <gtest/gtest.h>
26#pragma GCC diagnostic pop
2427
25#include <condition_variable>28#include <condition_variable>
26#include <thread>29#include <thread>
@@ -240,7 +243,7 @@
240 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());243 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
241 EXPECT_EQ("", receiver->completion_msg());244 EXPECT_EQ("", receiver->completion_msg());
242 auto r = receiver->results();245 auto r = receiver->results();
243 EXPECT_EQ(1, r.size());246 EXPECT_EQ(1u, r.size());
244}247}
245248
246TEST_F(ThrowingScopeTest, throw_from_search)249TEST_F(ThrowingScopeTest, throw_from_search)
@@ -255,7 +258,7 @@
255 " unity::ResourceException: exception from search",258 " unity::ResourceException: exception from search",
256 receiver->completion_msg());259 receiver->completion_msg());
257 auto r = receiver->results();260 auto r = receiver->results();
258 EXPECT_EQ(0, r.size());261 EXPECT_EQ(0u, r.size());
259}262}
260263
261TEST_F(ThrowingScopeTest, throw_from_run)264TEST_F(ThrowingScopeTest, throw_from_run)
@@ -267,7 +270,7 @@
267 EXPECT_EQ(CompletionDetails::CompletionStatus::Error, receiver->completion_status());270 EXPECT_EQ(CompletionDetails::CompletionStatus::Error, receiver->completion_status());
268 EXPECT_EQ("QueryBase::run(): unity::ResourceException: exception from run", receiver->completion_msg());271 EXPECT_EQ("QueryBase::run(): unity::ResourceException: exception from run", receiver->completion_msg());
269 auto r = receiver->results();272 auto r = receiver->results();
270 EXPECT_EQ(0, r.size());273 EXPECT_EQ(0u, r.size());
271}274}
272275
273TEST_F(ThrowingScopeTest, throw_from_cancelled)276TEST_F(ThrowingScopeTest, throw_from_cancelled)
@@ -280,7 +283,7 @@
280 receiver->wait_until_finished();283 receiver->wait_until_finished();
281284
282 auto r = receiver->results();285 auto r = receiver->results();
283 EXPECT_EQ(0, r.size());286 EXPECT_EQ(0u, r.size());
284287
285 EXPECT_EQ(CompletionDetails::CompletionStatus::Cancelled, receiver->completion_status());288 EXPECT_EQ(CompletionDetails::CompletionStatus::Cancelled, receiver->completion_status());
286 // No exception string here because we short-cut the cancellation on the client side.289 // No exception string here because we short-cut the cancellation on the client side.
@@ -297,7 +300,7 @@
297 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());300 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
298 EXPECT_EQ("", receiver->completion_msg());301 EXPECT_EQ("", receiver->completion_msg());
299 auto r = receiver->results();302 auto r = receiver->results();
300 EXPECT_EQ(1, r.size());303 EXPECT_EQ(1u, r.size());
301304
302 auto plistener = make_shared<PreviewListener>();305 auto plistener = make_shared<PreviewListener>();
303 scope()->preview(r[0], ActionMetadata("unused", "unused"), plistener);306 scope()->preview(r[0], ActionMetadata("unused", "unused"), plistener);
@@ -319,7 +322,7 @@
319 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());322 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
320 EXPECT_EQ("", receiver->completion_msg());323 EXPECT_EQ("", receiver->completion_msg());
321 auto r = receiver->results();324 auto r = receiver->results();
322 EXPECT_EQ(1, r.size());325 EXPECT_EQ(1u, r.size());
323326
324 auto plistener = make_shared<PreviewListener>();327 auto plistener = make_shared<PreviewListener>();
325 scope()->preview(r[0], ActionMetadata("unused", "unused"), plistener);328 scope()->preview(r[0], ActionMetadata("unused", "unused"), plistener);
@@ -338,7 +341,7 @@
338 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());341 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
339 EXPECT_EQ("", receiver->completion_msg());342 EXPECT_EQ("", receiver->completion_msg());
340 auto r = receiver->results();343 auto r = receiver->results();
341 EXPECT_EQ(1, r.size());344 EXPECT_EQ(1u, r.size());
342345
343 auto plistener = make_shared<PreviewListener>();346 auto plistener = make_shared<PreviewListener>();
344 auto ctrl = scope()->preview(r[0], ActionMetadata("unused", "unused"), plistener);347 auto ctrl = scope()->preview(r[0], ActionMetadata("unused", "unused"), plistener);
@@ -361,7 +364,7 @@
361 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());364 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
362 EXPECT_EQ("", receiver->completion_msg());365 EXPECT_EQ("", receiver->completion_msg());
363 auto r = receiver->results();366 auto r = receiver->results();
364 EXPECT_EQ(1, r.size());367 EXPECT_EQ(1u, r.size());
365368
366 auto alistener = make_shared<ActivationListener>();369 auto alistener = make_shared<ActivationListener>();
367 scope()->activate(r[0], ActionMetadata("unused", "unused"), alistener);370 scope()->activate(r[0], ActionMetadata("unused", "unused"), alistener);
@@ -383,7 +386,7 @@
383 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());386 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
384 EXPECT_EQ("", receiver->completion_msg());387 EXPECT_EQ("", receiver->completion_msg());
385 auto r = receiver->results();388 auto r = receiver->results();
386 EXPECT_EQ(1, r.size());389 EXPECT_EQ(1u, r.size());
387390
388 auto alistener = make_shared<ActivationListener>();391 auto alistener = make_shared<ActivationListener>();
389 scope()->activate(r[0], ActionMetadata("unused", "unused"), alistener);392 scope()->activate(r[0], ActionMetadata("unused", "unused"), alistener);
@@ -403,7 +406,7 @@
403 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());406 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
404 EXPECT_EQ("", receiver->completion_msg());407 EXPECT_EQ("", receiver->completion_msg());
405 auto r = receiver->results();408 auto r = receiver->results();
406 EXPECT_EQ(1, r.size());409 EXPECT_EQ(1u, r.size());
407410
408 auto alistener = make_shared<ActivationListener>();411 auto alistener = make_shared<ActivationListener>();
409 auto ctrl = scope()->activate(r[0], ActionMetadata("unused", "unused"), alistener);412 auto ctrl = scope()->activate(r[0], ActionMetadata("unused", "unused"), alistener);
@@ -426,7 +429,7 @@
426 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());429 EXPECT_EQ(CompletionDetails::CompletionStatus::OK, receiver->completion_status());
427 EXPECT_EQ("", receiver->completion_msg());430 EXPECT_EQ("", receiver->completion_msg());
428 auto r = receiver->results();431 auto r = receiver->results();
429 EXPECT_EQ(1, r.size());432 EXPECT_EQ(1u, r.size());
430433
431 auto alistener = make_shared<ActivationListener>();434 auto alistener = make_shared<ActivationListener>();
432 scope()->perform_action(r[0], ActionMetadata("unused", "unused"), "", "", alistener);435 scope()->perform_action(r[0], ActionMetadata("unused", "unused"), "", "", alistener);
433436
=== modified file 'test/gtest/scopes/ValueSliderFilter/ValueSliderFilter_test.cpp'
--- test/gtest/scopes/ValueSliderFilter/ValueSliderFilter_test.cpp 2016-03-11 13:21:36 +0000
+++ test/gtest/scopes/ValueSliderFilter/ValueSliderFilter_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,11 @@
16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
23
20#include <unity/scopes/FilterState.h>24#include <unity/scopes/FilterState.h>
21#include <unity/scopes/ValueSliderFilter.h>25#include <unity/scopes/ValueSliderFilter.h>
22#include <unity/scopes/ValueSliderLabels.h>26#include <unity/scopes/ValueSliderLabels.h>
@@ -45,7 +49,7 @@
45 EXPECT_EQ("f1", filter1->id());49 EXPECT_EQ("f1", filter1->id());
46 EXPECT_EQ("Min", filter1->labels().min_label());50 EXPECT_EQ("Min", filter1->labels().min_label());
47 EXPECT_EQ("Max", filter1->labels().max_label());51 EXPECT_EQ("Max", filter1->labels().max_label());
48 EXPECT_EQ(2, filter1->labels().extra_labels().size());52 EXPECT_EQ(2u, filter1->labels().extra_labels().size());
49 EXPECT_EQ("Ten", filter1->labels().extra_labels()[0].second);53 EXPECT_EQ("Ten", filter1->labels().extra_labels()[0].second);
50 EXPECT_EQ("Fifty", filter1->labels().extra_labels()[1].second);54 EXPECT_EQ("Fifty", filter1->labels().extra_labels()[1].second);
51 EXPECT_EQ(50, filter1->default_value());55 EXPECT_EQ(50, filter1->default_value());
@@ -115,7 +119,7 @@
115 EXPECT_EQ("f1", filter2->id());119 EXPECT_EQ("f1", filter2->id());
116 EXPECT_EQ("Min", filter2->labels().min_label());120 EXPECT_EQ("Min", filter2->labels().min_label());
117 EXPECT_EQ("Max", filter2->labels().max_label());121 EXPECT_EQ("Max", filter2->labels().max_label());
118 EXPECT_EQ(1, filter2->labels().extra_labels().size());122 EXPECT_EQ(1u, filter2->labels().extra_labels().size());
119 EXPECT_EQ(10, filter2->labels().extra_labels()[0].first);123 EXPECT_EQ(10, filter2->labels().extra_labels()[0].first);
120 EXPECT_EQ("Ten", filter2->labels().extra_labels()[0].second);124 EXPECT_EQ("Ten", filter2->labels().extra_labels()[0].second);
121 EXPECT_EQ(1, filter2->min());125 EXPECT_EQ(1, filter2->min());
122126
=== modified file 'test/gtest/scopes/Variant/Variant_test.cpp'
--- test/gtest/scopes/Variant/Variant_test.cpp 2015-06-17 10:15:34 +0000
+++ test/gtest/scopes/Variant/Variant_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,7 +21,10 @@
2121
22#include <boost/variant.hpp>22#include <boost/variant.hpp>
2323
24#pragma GCC diagnostic push
25#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>26#include <gtest/gtest.h>
27#pragma GCC diagnostic pop
2528
26using namespace std;29using namespace std;
27using namespace unity;30using namespace unity;
@@ -292,12 +295,12 @@
292295
293 v = Variant::deserialize_json("{\"foo\": \"bar\"}");296 v = Variant::deserialize_json("{\"foo\": \"bar\"}");
294 VariantMap vm = v.get_dict();297 VariantMap vm = v.get_dict();
295 EXPECT_EQ(1, vm.size());298 EXPECT_EQ(1u, vm.size());
296 EXPECT_EQ("bar", vm.at("foo").get_string());299 EXPECT_EQ("bar", vm.at("foo").get_string());
297300
298 v = Variant::deserialize_json("[1, \"two\"]");301 v = Variant::deserialize_json("[1, \"two\"]");
299 VariantArray va = v.get_array();302 VariantArray va = v.get_array();
300 EXPECT_EQ(2, va.size());303 EXPECT_EQ(2u, va.size());
301 EXPECT_EQ(1, va[0].get_int());304 EXPECT_EQ(1, va[0].get_int());
302 EXPECT_EQ("two", va[1].get_string());305 EXPECT_EQ("two", va[1].get_string());
303}306}
304307
=== modified file 'test/gtest/scopes/VariantBuilder/VariantBuilder_test.cpp'
--- test/gtest/scopes/VariantBuilder/VariantBuilder_test.cpp 2014-02-25 12:08:41 +0000
+++ test/gtest/scopes/VariantBuilder/VariantBuilder_test.cpp 2016-11-28 10:48:16 +0000
@@ -17,8 +17,12 @@
17*/17*/
1818
19#include <unity/scopes/VariantBuilder.h>19#include <unity/scopes/VariantBuilder.h>
20#include <unity/UnityExceptions.h>
21
22#pragma GCC diagnostic push
23#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
20#include <gtest/gtest.h>24#include <gtest/gtest.h>
21#include <unity/UnityExceptions.h>25#pragma GCC diagnostic pop
2226
23using namespace unity;27using namespace unity;
24using namespace unity::scopes;28using namespace unity::scopes;
2529
=== modified file 'test/gtest/scopes/Version/Version_test.cpp'
--- test/gtest/scopes/Version/Version_test.cpp 2014-01-07 12:22:29 +0000
+++ test/gtest/scopes/Version/Version_test.cpp 2016-11-28 10:48:16 +0000
@@ -18,7 +18,10 @@
1818
19#include <unity/scopes/Version.h>19#include <unity/scopes/Version.h>
2020
21#pragma GCC diagnostic push
22#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
21#include <gtest/gtest.h>23#include <gtest/gtest.h>
24#pragma GCC diagnostic pop
2225
23using namespace unity::scopes;26using namespace unity::scopes;
2427
2528
=== modified file 'test/gtest/scopes/internal/CategoryRegistry/CategoryRegistry_test.cpp'
--- test/gtest/scopes/internal/CategoryRegistry/CategoryRegistry_test.cpp 2014-07-02 09:36:34 +0000
+++ test/gtest/scopes/internal/CategoryRegistry/CategoryRegistry_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,7 +21,10 @@
21#include <unity/UnityExceptions.h>21#include <unity/UnityExceptions.h>
22#include <unity/scopes/Variant.h>22#include <unity/scopes/Variant.h>
2323
24#pragma GCC diagnostic push
25#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>26#include <gtest/gtest.h>
27#pragma GCC diagnostic pop
2528
26using namespace std;29using namespace std;
27using namespace unity;30using namespace unity;
2831
=== modified file 'test/gtest/scopes/internal/ConfigBase/ConfigBase_test.cpp'
--- test/gtest/scopes/internal/ConfigBase/ConfigBase_test.cpp 2014-07-07 23:53:36 +0000
+++ test/gtest/scopes/internal/ConfigBase/ConfigBase_test.cpp 2016-11-28 10:48:16 +0000
@@ -20,7 +20,10 @@
20#include <unity/scopes/ScopeExceptions.h>20#include <unity/scopes/ScopeExceptions.h>
21#include <unity/UnityExceptions.h>21#include <unity/UnityExceptions.h>
2222
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
23#include <gtest/gtest.h>25#include <gtest/gtest.h>
26#pragma GCC diagnostic pop
2427
25using namespace std;28using namespace std;
26using namespace unity;29using namespace unity;
2730
=== modified file 'test/gtest/scopes/internal/DynamicLoader/DynamicLoader_test.cpp'
--- test/gtest/scopes/internal/DynamicLoader/DynamicLoader_test.cpp 2014-08-28 00:20:56 +0000
+++ test/gtest/scopes/internal/DynamicLoader/DynamicLoader_test.cpp 2016-11-28 10:48:16 +0000
@@ -19,7 +19,10 @@
19#include <unity/scopes/internal/DynamicLoader.h>19#include <unity/scopes/internal/DynamicLoader.h>
20#include <unity/UnityExceptions.h>20#include <unity/UnityExceptions.h>
2121
22#pragma GCC diagnostic push
23#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
22#include <gtest/gtest.h>24#include <gtest/gtest.h>
25#pragma GCC diagnostic pop
2326
24#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.27#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.
25using namespace std;28using namespace std;
2629
=== modified file 'test/gtest/scopes/internal/IniSettingsSchema/IniSettingsSchema_test.cpp'
--- test/gtest/scopes/internal/IniSettingsSchema/IniSettingsSchema_test.cpp 2014-11-20 21:33:33 +0000
+++ test/gtest/scopes/internal/IniSettingsSchema/IniSettingsSchema_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,7 +21,10 @@
21#include <unity/UnityExceptions.h>21#include <unity/UnityExceptions.h>
2222
23#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.23#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.
24#pragma GCC diagnostic push
25#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>26#include <gtest/gtest.h>
27#pragma GCC diagnostic pop
2528
26using namespace unity;29using namespace unity;
27using namespace unity::scopes;30using namespace unity::scopes;
@@ -34,7 +37,7 @@
34 s->add_location_setting();37 s->add_location_setting();
3538
36 auto defs = s->definitions();39 auto defs = s->definitions();
37 ASSERT_EQ(9, defs.size());40 ASSERT_EQ(9u, defs.size());
3841
39 EXPECT_EQ("location", defs[0].get_dict()["id"].get_string());42 EXPECT_EQ("location", defs[0].get_dict()["id"].get_string());
40 EXPECT_EQ("string", defs[0].get_dict()["type"].get_string());43 EXPECT_EQ("string", defs[0].get_dict()["type"].get_string());
@@ -45,7 +48,7 @@
45 EXPECT_EQ("list", defs[1].get_dict()["type"].get_string());48 EXPECT_EQ("list", defs[1].get_dict()["type"].get_string());
46 EXPECT_EQ("Temperature Unit", defs[1].get_dict()["displayName"].get_string());49 EXPECT_EQ("Temperature Unit", defs[1].get_dict()["displayName"].get_string());
47 EXPECT_EQ(1, defs[1].get_dict()["defaultValue"].get_int());50 EXPECT_EQ(1, defs[1].get_dict()["defaultValue"].get_int());
48 ASSERT_EQ(2, defs[1].get_dict()["displayValues"].get_array().size());51 ASSERT_EQ(2u, defs[1].get_dict()["displayValues"].get_array().size());
49 EXPECT_EQ("Celsius", defs[1].get_dict()["displayValues"].get_array()[0].get_string());52 EXPECT_EQ("Celsius", defs[1].get_dict()["displayValues"].get_array()[0].get_string());
50 EXPECT_EQ("Fahrenheit", defs[1].get_dict()["displayValues"].get_array()[1].get_string());53 EXPECT_EQ("Fahrenheit", defs[1].get_dict()["displayValues"].get_array()[1].get_string());
5154
@@ -204,7 +207,7 @@
204207
205 EXPECT_EQ("tempUnit", defs[1].get_dict()["id"].get_string());208 EXPECT_EQ("tempUnit", defs[1].get_dict()["id"].get_string());
206 EXPECT_EQ("testTemperature Unit", defs[1].get_dict()["displayName"].get_string());209 EXPECT_EQ("testTemperature Unit", defs[1].get_dict()["displayName"].get_string());
207 ASSERT_EQ(2, defs[1].get_dict()["displayValues"].get_array().size());210 ASSERT_EQ(2u, defs[1].get_dict()["displayValues"].get_array().size());
208 EXPECT_EQ("testCelsius", defs[1].get_dict()["displayValues"].get_array()[0].get_string());211 EXPECT_EQ("testCelsius", defs[1].get_dict()["displayValues"].get_array()[0].get_string());
209 EXPECT_EQ("testFahrenheit", defs[1].get_dict()["displayValues"].get_array()[1].get_string());212 EXPECT_EQ("testFahrenheit", defs[1].get_dict()["displayValues"].get_array()[1].get_string());
210 }213 }
@@ -215,11 +218,11 @@
215 auto s = IniSettingsSchema::create(TEST_SRC_DIR "/locale_fallback.ini");218 auto s = IniSettingsSchema::create(TEST_SRC_DIR "/locale_fallback.ini");
216219
217 auto defs = s->definitions();220 auto defs = s->definitions();
218 ASSERT_EQ(1, defs.size());221 ASSERT_EQ(1u, defs.size());
219222
220 EXPECT_EQ("tempUnit", defs[0].get_dict()["id"].get_string());223 EXPECT_EQ("tempUnit", defs[0].get_dict()["id"].get_string());
221 EXPECT_EQ("Temperature Unit", defs[0].get_dict()["displayName"].get_string());224 EXPECT_EQ("Temperature Unit", defs[0].get_dict()["displayName"].get_string());
222 ASSERT_EQ(2, defs[0].get_dict()["displayValues"].get_array().size());225 ASSERT_EQ(2u, defs[0].get_dict()["displayValues"].get_array().size());
223 EXPECT_EQ("Celsius", defs[0].get_dict()["displayValues"].get_array()[0].get_string());226 EXPECT_EQ("Celsius", defs[0].get_dict()["displayValues"].get_array()[0].get_string());
224 EXPECT_EQ("Fahrenheit", defs[0].get_dict()["displayValues"].get_array()[1].get_string());227 EXPECT_EQ("Fahrenheit", defs[0].get_dict()["displayValues"].get_array()[1].get_string());
225 }228 }
@@ -235,7 +238,7 @@
235 s->add_location_setting();238 s->add_location_setting();
236 {239 {
237 auto defs = s->definitions();240 auto defs = s->definitions();
238 ASSERT_EQ(1, defs.size());241 ASSERT_EQ(1u, defs.size());
239242
240 EXPECT_EQ("internal.location", defs[0].get_dict()["id"].get_string());243 EXPECT_EQ("internal.location", defs[0].get_dict()["id"].get_string());
241 EXPECT_EQ("Enable location data", defs[0].get_dict()["displayName"].get_string());244 EXPECT_EQ("Enable location data", defs[0].get_dict()["displayName"].get_string());
242245
=== modified file 'test/gtest/scopes/internal/JsonNode/JsonNode_test.cpp'
--- test/gtest/scopes/internal/JsonNode/JsonNode_test.cpp 2016-05-27 11:26:53 +0000
+++ test/gtest/scopes/internal/JsonNode/JsonNode_test.cpp 2016-11-28 10:48:16 +0000
@@ -20,7 +20,11 @@
20#include <unity/UnityExceptions.h>20#include <unity/UnityExceptions.h>
21#include <unity/scopes/Variant.h>21#include <unity/scopes/Variant.h>
2222
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
23#include <gtest/gtest.h>25#include <gtest/gtest.h>
26#pragma GCC diagnostic pop
27
24#include <memory>28#include <memory>
25#include <algorithm>29#include <algorithm>
2630
2731
=== modified file 'test/gtest/scopes/internal/JsonSettingsSchema/JsonSettingsSchema_test.cpp'
--- test/gtest/scopes/internal/JsonSettingsSchema/JsonSettingsSchema_test.cpp 2016-05-27 11:03:57 +0000
+++ test/gtest/scopes/internal/JsonSettingsSchema/JsonSettingsSchema_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,7 +21,10 @@
21#include <unity/UnityExceptions.h>21#include <unity/UnityExceptions.h>
22#include <unity/util/FileIO.h>22#include <unity/util/FileIO.h>
2323
24#pragma GCC diagnostic push
25#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>26#include <gtest/gtest.h>
27#pragma GCC diagnostic pop
2528
26using namespace unity;29using namespace unity;
27using namespace unity::scopes;30using namespace unity::scopes;
@@ -118,7 +121,7 @@
118 auto s = JsonSettingsSchema::create(ok_schema);121 auto s = JsonSettingsSchema::create(ok_schema);
119122
120 auto defs = s->definitions();123 auto defs = s->definitions();
121 EXPECT_EQ(11, defs.size());124 EXPECT_EQ(11u, defs.size());
122125
123 EXPECT_EQ("location", defs[0].get_dict()["id"].get_string());126 EXPECT_EQ("location", defs[0].get_dict()["id"].get_string());
124 EXPECT_EQ("string", defs[0].get_dict()["type"].get_string());127 EXPECT_EQ("string", defs[0].get_dict()["type"].get_string());
@@ -129,7 +132,7 @@
129 EXPECT_EQ("list", defs[1].get_dict()["type"].get_string());132 EXPECT_EQ("list", defs[1].get_dict()["type"].get_string());
130 EXPECT_EQ("Temperature Units", defs[1].get_dict()["displayName"].get_string());133 EXPECT_EQ("Temperature Units", defs[1].get_dict()["displayName"].get_string());
131 EXPECT_EQ(1, defs[1].get_dict()["defaultValue"].get_int());134 EXPECT_EQ(1, defs[1].get_dict()["defaultValue"].get_int());
132 EXPECT_EQ(2, defs[1].get_dict()["displayValues"].get_array().size());135 EXPECT_EQ(2u, defs[1].get_dict()["displayValues"].get_array().size());
133 EXPECT_EQ("Celsius", defs[1].get_dict()["displayValues"].get_array()[0].get_string());136 EXPECT_EQ("Celsius", defs[1].get_dict()["displayValues"].get_array()[0].get_string());
134 EXPECT_EQ("Fahrenheit", defs[1].get_dict()["displayValues"].get_array()[1].get_string());137 EXPECT_EQ("Fahrenheit", defs[1].get_dict()["displayValues"].get_array()[1].get_string());
135138
@@ -181,7 +184,7 @@
181 auto s = JsonSettingsSchema::create(schema);184 auto s = JsonSettingsSchema::create(schema);
182185
183 auto defs = s->definitions();186 auto defs = s->definitions();
184 EXPECT_EQ(2, defs.size());187 EXPECT_EQ(2u, defs.size());
185188
186 EXPECT_EQ(3.14, defs[0].get_dict()["defaultValue"].get_double());189 EXPECT_EQ(3.14, defs[0].get_dict()["defaultValue"].get_double());
187 EXPECT_EQ(2147483648, defs[1].get_dict()["defaultValue"].get_double());190 EXPECT_EQ(2147483648, defs[1].get_dict()["defaultValue"].get_double());
@@ -705,7 +708,7 @@
705 s->add_location_setting();708 s->add_location_setting();
706 {709 {
707 auto defs = s->definitions();710 auto defs = s->definitions();
708 ASSERT_EQ(1, defs.size());711 ASSERT_EQ(1u, defs.size());
709712
710 EXPECT_EQ("internal.location", defs[0].get_dict()["id"].get_string());713 EXPECT_EQ("internal.location", defs[0].get_dict()["id"].get_string());
711 EXPECT_EQ("Enable location data", defs[0].get_dict()["displayName"].get_string());714 EXPECT_EQ("Enable location data", defs[0].get_dict()["displayName"].get_string());
712715
=== modified file 'test/gtest/scopes/internal/Logger/Logger_test.cpp'
--- test/gtest/scopes/internal/Logger/Logger_test.cpp 2016-02-22 04:35:26 +0000
+++ test/gtest/scopes/internal/Logger/Logger_test.cpp 2016-11-28 10:48:16 +0000
@@ -19,7 +19,12 @@
19#include <unity/scopes/internal/Logger.h>19#include <unity/scopes/internal/Logger.h>
2020
21#include <boost/algorithm/string.hpp>21#include <boost/algorithm/string.hpp>
22
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
22#include <gtest/gtest.h>25#include <gtest/gtest.h>
26#pragma GCC diagnostic pop
27
23#include <unity/UnityExceptions.h>28#include <unity/UnityExceptions.h>
2429
25using namespace std;30using namespace std;
2631
=== modified file 'test/gtest/scopes/internal/MiddlewareFactory/MiddlewareFactory_test.cpp'
--- test/gtest/scopes/internal/MiddlewareFactory/MiddlewareFactory_test.cpp 2014-12-02 00:16:04 +0000
+++ test/gtest/scopes/internal/MiddlewareFactory/MiddlewareFactory_test.cpp 2016-11-28 10:48:16 +0000
@@ -19,7 +19,10 @@
19#include <unity/scopes/internal/MiddlewareFactory.h>19#include <unity/scopes/internal/MiddlewareFactory.h>
20#include <unity/scopes/ScopeExceptions.h>20#include <unity/scopes/ScopeExceptions.h>
2121
22#pragma GCC diagnostic push
23#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
22#include <gtest/gtest.h>24#include <gtest/gtest.h>
25#pragma GCC diagnostic pop
2326
24using namespace std;27using namespace std;
25using namespace unity::scopes;28using namespace unity::scopes;
2629
=== modified file 'test/gtest/scopes/internal/Reaper/Reaper_test.cpp'
--- test/gtest/scopes/internal/Reaper/Reaper_test.cpp 2014-11-05 05:00:38 +0000
+++ test/gtest/scopes/internal/Reaper/Reaper_test.cpp 2016-11-28 10:48:16 +0000
@@ -20,7 +20,10 @@
2020
21#include <unity/UnityExceptions.h>21#include <unity/UnityExceptions.h>
2222
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
23#include <gtest/gtest.h>25#include <gtest/gtest.h>
26#pragma GCC diagnostic pop
2427
25using namespace std;28using namespace std;
26using namespace unity::scopes;29using namespace unity::scopes;
@@ -200,17 +203,17 @@
200 auto e1 = r->add([]{});203 auto e1 = r->add([]{});
201 auto e2 = r->add([]{});204 auto e2 = r->add([]{});
202 auto e3 = r->add([]{});205 auto e3 = r->add([]{});
203 EXPECT_EQ(3, r->size());206 EXPECT_EQ(3u, r->size());
204 e2->cancel();207 e2->cancel();
205 EXPECT_EQ(2, r->size());208 EXPECT_EQ(2u, r->size());
206209
207 r->destroy();210 r->destroy();
208211
209 EXPECT_EQ(2, r->size());212 EXPECT_EQ(2u, r->size());
210 e3->cancel();213 e3->cancel();
211 EXPECT_EQ(1, r->size());214 EXPECT_EQ(1u, r->size());
212 e1->cancel();215 e1->cancel();
213 EXPECT_EQ(0, r->size());216 EXPECT_EQ(0u, r->size());
214 }217 }
215}218}
216219
@@ -326,7 +329,7 @@
326 // Now we destroy the reaper, *before* the pass at t == 6.0.329 // Now we destroy the reaper, *before* the pass at t == 6.0.
327 // Because CallbackOnDestroy is set, e3 is reaped.330 // Because CallbackOnDestroy is set, e3 is reaped.
328 r->destroy();331 r->destroy();
329 EXPECT_EQ(0, r->size());332 EXPECT_EQ(0u, r->size());
330 EXPECT_EQ(1, c1.get());333 EXPECT_EQ(1, c1.get());
331 EXPECT_EQ(0, c2.get());334 EXPECT_EQ(0, c2.get());
332 EXPECT_EQ(1, c3.get()); // Callback for e3 must have been invoked.335 EXPECT_EQ(1, c3.get()); // Callback for e3 must have been invoked.
@@ -361,7 +364,7 @@
361364
362 // e1 is oldest, so at the tail of the reap list.365 // e1 is oldest, so at the tail of the reap list.
363366
364 EXPECT_EQ(2, r->size());367 EXPECT_EQ(2u, r->size());
365 EXPECT_LT(t(), 2000);368 EXPECT_LT(t(), 2000);
366369
367 this_thread::sleep_for(chrono::milliseconds(2500)); // At t == 2.0, reaper kicks in.370 this_thread::sleep_for(chrono::milliseconds(2500)); // At t == 2.0, reaper kicks in.
@@ -370,14 +373,14 @@
370 EXPECT_GE(t(), 2500);373 EXPECT_GE(t(), 2500);
371 EXPECT_EQ(1, c1.get()); // Was reaped at t ~ 2.0 (tested by lambda on c1)374 EXPECT_EQ(1, c1.get()); // Was reaped at t ~ 2.0 (tested by lambda on c1)
372 EXPECT_EQ(0, c2.get()); // Expires at t ~ 2.0, but not reaped yet, because c1 has not completed375 EXPECT_EQ(0, c2.get()); // Expires at t ~ 2.0, but not reaped yet, because c1 has not completed
373 EXPECT_EQ(1, r->size()); // e2 must still be there376 EXPECT_EQ(1u, r->size()); // e2 must still be there
374377
375 // We null out e2 while the reaping pass is still stuck in the callback for e1.378 // We null out e2 while the reaping pass is still stuck in the callback for e1.
376 EXPECT_LT(t(), 3000);379 EXPECT_LT(t(), 3000);
377 e2 = nullptr; // Blocks until e1's callback completes at t ~ 3.0 (tested by lambda on c2)380 e2 = nullptr; // Blocks until e1's callback completes at t ~ 3.0 (tested by lambda on c2)
378 EXPECT_GE(t(), 3000);381 EXPECT_GE(t(), 3000);
379 EXPECT_EQ(0, c2.get());382 EXPECT_EQ(0, c2.get());
380 EXPECT_EQ(0, r->size());383 EXPECT_EQ(0u, r->size());
381 }384 }
382}385}
383386
@@ -419,7 +422,7 @@
419 SelfDestroy sd(r);422 SelfDestroy sd(r);
420 this_thread::sleep_for(chrono::milliseconds(1500));423 this_thread::sleep_for(chrono::milliseconds(1500));
421 EXPECT_TRUE(sd.called());424 EXPECT_TRUE(sd.called());
422 EXPECT_EQ(0, r->size());425 EXPECT_EQ(0u, r->size());
423 }426 }
424}427}
425428
@@ -441,13 +444,13 @@
441444
442 e1->refresh();445 e1->refresh();
443 e2->cancel();446 e2->cancel();
444 EXPECT_EQ(2, r->size());447 EXPECT_EQ(2u, r->size());
445 EXPECT_EQ(0, c1.get());448 EXPECT_EQ(0, c1.get());
446 EXPECT_EQ(0, c2.get());449 EXPECT_EQ(0, c2.get());
447 EXPECT_EQ(0, c3.get());450 EXPECT_EQ(0, c3.get());
448451
449 r->destroy();452 r->destroy();
450 EXPECT_EQ(0, r->size());453 EXPECT_EQ(0u, r->size());
451 EXPECT_EQ(1, c1.get());454 EXPECT_EQ(1, c1.get());
452 EXPECT_EQ(0, c2.get());455 EXPECT_EQ(0, c2.get());
453 EXPECT_EQ(1, c3.get());456 EXPECT_EQ(1, c3.get());
@@ -466,13 +469,13 @@
466469
467 e1->refresh();470 e1->refresh();
468 e2->cancel();471 e2->cancel();
469 EXPECT_EQ(2, r->size());472 EXPECT_EQ(2u, r->size());
470 EXPECT_EQ(0, c1.get());473 EXPECT_EQ(0, c1.get());
471 EXPECT_EQ(0, c2.get());474 EXPECT_EQ(0, c2.get());
472 EXPECT_EQ(0, c3.get());475 EXPECT_EQ(0, c3.get());
473476
474 r->destroy();477 r->destroy();
475 EXPECT_EQ(2, r->size());478 EXPECT_EQ(2u, r->size());
476 EXPECT_EQ(0, c1.get());479 EXPECT_EQ(0, c1.get());
477 EXPECT_EQ(0, c2.get());480 EXPECT_EQ(0, c2.get());
478 EXPECT_EQ(0, c3.get());481 EXPECT_EQ(0, c3.get());
479482
=== modified file 'test/gtest/scopes/internal/RegistryConfig/RegistryConfig_test.cpp'
--- test/gtest/scopes/internal/RegistryConfig/RegistryConfig_test.cpp 2015-08-04 04:56:01 +0000
+++ test/gtest/scopes/internal/RegistryConfig/RegistryConfig_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,7 +21,10 @@
21#include <unity/scopes/ScopeExceptions.h>21#include <unity/scopes/ScopeExceptions.h>
2222
23#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.23#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.
24#pragma GCC diagnostic push
25#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>26#include <gtest/gtest.h>
27#pragma GCC diagnostic pop
2528
26using namespace std;29using namespace std;
27using namespace unity;30using namespace unity;
2831
=== modified file 'test/gtest/scopes/internal/RegistryObject/RegistryObject_test.cpp'
--- test/gtest/scopes/internal/RegistryObject/RegistryObject_test.cpp 2015-05-29 10:17:42 +0000
+++ test/gtest/scopes/internal/RegistryObject/RegistryObject_test.cpp 2016-11-28 10:48:16 +0000
@@ -24,8 +24,10 @@
24#include <unity/UnityExceptions.h>24#include <unity/UnityExceptions.h>
25#include <unity/scopes/ScopeExceptions.h>25#include <unity/scopes/ScopeExceptions.h>
2626
27#include <gtest/gtest.h>27#pragma GCC diagnostic push
28#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
28#include <gmock/gmock.h>29#include <gmock/gmock.h>
30#pragma GCC diagnostic pop
2931
30using namespace std;32using namespace std;
31using namespace testing;33using namespace testing;
3234
=== modified file 'test/gtest/scopes/internal/ResultReplyObject/ResultReplyObject_test.cpp'
--- test/gtest/scopes/internal/ResultReplyObject/ResultReplyObject_test.cpp 2014-12-01 08:21:05 +0000
+++ test/gtest/scopes/internal/ResultReplyObject/ResultReplyObject_test.cpp 2016-11-28 10:48:16 +0000
@@ -23,7 +23,11 @@
23#include <unity/scopes/SearchListenerBase.h>23#include <unity/scopes/SearchListenerBase.h>
24#include <unity/scopes/Department.h>24#include <unity/scopes/Department.h>
25#include <unity/scopes/CategorisedResult.h>25#include <unity/scopes/CategorisedResult.h>
26
27#pragma GCC diagnostic push
28#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
26#include <gtest/gtest.h>29#include <gtest/gtest.h>
30#pragma GCC diagnostic pop
2731
28using namespace unity::scopes;32using namespace unity::scopes;
29using namespace unity::scopes::internal;33using namespace unity::scopes::internal;
3034
=== modified file 'test/gtest/scopes/internal/RuntimeConfig/RuntimeConfig_test.cpp'
--- test/gtest/scopes/internal/RuntimeConfig/RuntimeConfig_test.cpp 2016-02-22 01:29:01 +0000
+++ test/gtest/scopes/internal/RuntimeConfig/RuntimeConfig_test.cpp 2016-11-28 10:48:16 +0000
@@ -24,7 +24,10 @@
24#include <unity/UnityExceptions.h>24#include <unity/UnityExceptions.h>
2525
26#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.26#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.
27#pragma GCC diagnostic push
28#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
27#include <gtest/gtest.h>29#include <gtest/gtest.h>
30#pragma GCC diagnostic pop
2831
29using namespace std;32using namespace std;
30using namespace unity::scopes;33using namespace unity::scopes;
3134
=== modified file 'test/gtest/scopes/internal/RuntimeImpl/RuntimeImpl_test.cpp'
--- test/gtest/scopes/internal/RuntimeImpl/RuntimeImpl_test.cpp 2014-12-04 04:33:50 +0000
+++ test/gtest/scopes/internal/RuntimeImpl/RuntimeImpl_test.cpp 2016-11-28 10:48:16 +0000
@@ -25,7 +25,11 @@
2525
26#include <boost/algorithm/string.hpp>26#include <boost/algorithm/string.hpp>
27#include <boost/filesystem.hpp>27#include <boost/filesystem.hpp>
28
29#pragma GCC diagnostic push
30#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
28#include <gtest/gtest.h>31#include <gtest/gtest.h>
32#pragma GCC diagnostic pop
2933
30#include <fstream>34#include <fstream>
3135
3236
=== modified file 'test/gtest/scopes/internal/ScopeConfig/ScopeConfig_test.cpp'
--- test/gtest/scopes/internal/ScopeConfig/ScopeConfig_test.cpp 2016-10-13 11:57:05 +0000
+++ test/gtest/scopes/internal/ScopeConfig/ScopeConfig_test.cpp 2016-11-28 10:48:16 +0000
@@ -23,7 +23,10 @@
23#include <unity/UnityExceptions.h>23#include <unity/UnityExceptions.h>
2424
25#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.25#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.
26#pragma GCC diagnostic push
27#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
26#include <gtest/gtest.h>28#include <gtest/gtest.h>
29#pragma GCC diagnostic pop
2730
28using namespace unity::scopes;31using namespace unity::scopes;
29using namespace unity::scopes::internal;32using namespace unity::scopes::internal;
@@ -65,7 +68,7 @@
65 EXPECT_TRUE(cfg.is_aggregator());68 EXPECT_TRUE(cfg.is_aggregator());
6669
67 auto attrs = cfg.appearance_attributes();70 auto attrs = cfg.appearance_attributes();
68 EXPECT_EQ(5, attrs.size());71 EXPECT_EQ(5u, attrs.size());
69 EXPECT_TRUE(attrs["arbitrary_key"].get_bool());72 EXPECT_TRUE(attrs["arbitrary_key"].get_bool());
70 EXPECT_EQ("bar", attrs["another_one"].get_string());73 EXPECT_EQ("bar", attrs["another_one"].get_string());
71 EXPECT_EQ(11, attrs["num_key"].get_int());74 EXPECT_EQ(11, attrs["num_key"].get_int());
@@ -97,7 +100,7 @@
97 EXPECT_EQ(0, cfg.version());100 EXPECT_EQ(0, cfg.version());
98 EXPECT_FALSE(cfg.is_aggregator());101 EXPECT_FALSE(cfg.is_aggregator());
99102
100 EXPECT_EQ(0, cfg.appearance_attributes().size());103 EXPECT_EQ(0u, cfg.appearance_attributes().size());
101104
102 // Optional items that throw if not set105 // Optional items that throw if not set
103106
@@ -137,13 +140,13 @@
137TEST(ScopeConfig, empty_scope_ids)140TEST(ScopeConfig, empty_scope_ids)
138{141{
139 ScopeConfig cfg(EMPTY_CHILD_IDS);142 ScopeConfig cfg(EMPTY_CHILD_IDS);
140 EXPECT_EQ(cfg.child_scope_ids().size(), 0);143 EXPECT_EQ(0u, cfg.child_scope_ids().size());
141}144}
142145
143TEST(ScopeConfig, single_scope_id)146TEST(ScopeConfig, single_scope_id)
144{147{
145 ScopeConfig cfg(SINGLE_CHILD_ID);148 ScopeConfig cfg(SINGLE_CHILD_ID);
146 EXPECT_EQ(cfg.child_scope_ids().size(), 1);149 EXPECT_EQ(1u, cfg.child_scope_ids().size());
147}150}
148151
149TEST(ScopeConfig, bad_timeout)152TEST(ScopeConfig, bad_timeout)
@@ -206,13 +209,13 @@
206TEST(ScopeConfig, empty_keywords)209TEST(ScopeConfig, empty_keywords)
207{210{
208 ScopeConfig cfg(EMPTY_KEYWORDS);211 ScopeConfig cfg(EMPTY_KEYWORDS);
209 EXPECT_EQ(cfg.keywords().size(), 0);212 EXPECT_EQ(0u, cfg.keywords().size());
210}213}
211214
212TEST(ScopeConfig, single_keyword)215TEST(ScopeConfig, single_keyword)
213{216{
214 ScopeConfig cfg(SINGLE_KEYWORD);217 ScopeConfig cfg(SINGLE_KEYWORD);
215 EXPECT_EQ(cfg.keywords().size(), 1);218 EXPECT_EQ(1u, cfg.keywords().size());
216}219}
217220
218TEST(ScopeConfig, empty_display_name)221TEST(ScopeConfig, empty_display_name)
219222
=== modified file 'test/gtest/scopes/internal/ScopeLoader/ScopeLoader_test.cpp'
--- test/gtest/scopes/internal/ScopeLoader/ScopeLoader_test.cpp 2014-08-28 00:20:56 +0000
+++ test/gtest/scopes/internal/ScopeLoader/ScopeLoader_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,7 +21,10 @@
21#include <unity/scopes/internal/ScopeLoader.h>21#include <unity/scopes/internal/ScopeLoader.h>
22#include <unity/UnityExceptions.h>22#include <unity/UnityExceptions.h>
2323
24#pragma GCC diagnostic push
25#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>26#include <gtest/gtest.h>
27#pragma GCC diagnostic pop
2528
26#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.29#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.
27#include "Counters.h"30#include "Counters.h"
2831
=== modified file 'test/gtest/scopes/internal/ScopeMetadataImpl/ScopeMetadataImpl_test.cpp'
--- test/gtest/scopes/internal/ScopeMetadataImpl/ScopeMetadataImpl_test.cpp 2015-01-27 12:46:11 +0000
+++ test/gtest/scopes/internal/ScopeMetadataImpl/ScopeMetadataImpl_test.cpp 2016-11-28 10:48:16 +0000
@@ -25,7 +25,10 @@
25#include <unity/UnityExceptions.h>25#include <unity/UnityExceptions.h>
2626
27#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.27#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.
28#pragma GCC diagnostic push
29#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
28#include <gtest/gtest.h>30#include <gtest/gtest.h>
31#pragma GCC diagnostic pop
2932
30using namespace std;33using namespace std;
31using namespace unity;34using namespace unity;
@@ -61,7 +64,7 @@
61 EXPECT_EQ("display_name", m.display_name());64 EXPECT_EQ("display_name", m.display_name());
62 EXPECT_EQ("description", m.description());65 EXPECT_EQ("description", m.description());
63 EXPECT_EQ("author", m.author());66 EXPECT_EQ("author", m.author());
64 EXPECT_EQ(0, m.appearance_attributes().size());67 EXPECT_EQ(0u, m.appearance_attributes().size());
65 EXPECT_EQ(ScopeMetadata::ResultsTtlType::Medium, m.results_ttl_type());68 EXPECT_EQ(ScopeMetadata::ResultsTtlType::Medium, m.results_ttl_type());
6669
67 // Check that optional fields that are not set throw70 // Check that optional fields that are not set throw
@@ -144,7 +147,7 @@
144 EXPECT_EQ("display_name", mi2->display_name());147 EXPECT_EQ("display_name", mi2->display_name());
145 EXPECT_EQ("description", mi2->description());148 EXPECT_EQ("description", mi2->description());
146 EXPECT_EQ("author", mi2->author());149 EXPECT_EQ("author", mi2->author());
147 EXPECT_EQ(0, mi2->appearance_attributes().size());150 EXPECT_EQ(0u, mi2->appearance_attributes().size());
148 EXPECT_EQ(ScopeMetadata::ResultsTtlType::Medium, mi2->results_ttl_type());151 EXPECT_EQ(ScopeMetadata::ResultsTtlType::Medium, mi2->results_ttl_type());
149 EXPECT_EQ(0, mi2->version());152 EXPECT_EQ(0, mi2->version());
150153
151154
=== modified file 'test/gtest/scopes/internal/SettingsDB/SettingsDB_test.cpp'
--- test/gtest/scopes/internal/SettingsDB/SettingsDB_test.cpp 2016-03-15 04:36:08 +0000
+++ test/gtest/scopes/internal/SettingsDB/SettingsDB_test.cpp 2016-11-28 10:48:16 +0000
@@ -24,7 +24,11 @@
2424
25#include <boost/algorithm/string.hpp>25#include <boost/algorithm/string.hpp>
26#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.26#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.
27#pragma GCC diagnostic push
28#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
27#include <gtest/gtest.h>29#include <gtest/gtest.h>
30#pragma GCC diagnostic pop
31
28#include <fcntl.h>32#include <fcntl.h>
29#include <ctime>33#include <ctime>
30#include <thread>34#include <thread>
@@ -91,7 +95,7 @@
91 auto db = SettingsDB::create_from_ini_file(db_name, schema);95 auto db = SettingsDB::create_from_ini_file(db_name, schema);
9296
93 // If db doesn't exist, default values are returned.97 // If db doesn't exist, default values are returned.
94 EXPECT_EQ(4, db->settings().size());98 EXPECT_EQ(4u, db->settings().size());
95 EXPECT_EQ("London", db->settings()["locationSetting"].get_string());99 EXPECT_EQ("London", db->settings()["locationSetting"].get_string());
96 EXPECT_EQ(1, db->settings()["unitTempSetting"].get_int());100 EXPECT_EQ(1, db->settings()["unitTempSetting"].get_int());
97 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());101 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());
@@ -101,7 +105,7 @@
101 write_db("db_empty.ini");105 write_db("db_empty.ini");
102106
103 // Default values must still be there.107 // Default values must still be there.
104 EXPECT_EQ(4, db->settings().size());108 EXPECT_EQ(4u, db->settings().size());
105 EXPECT_EQ("London", db->settings()["locationSetting"].get_string());109 EXPECT_EQ("London", db->settings()["locationSetting"].get_string());
106 EXPECT_EQ(1, db->settings()["unitTempSetting"].get_int());110 EXPECT_EQ(1, db->settings()["unitTempSetting"].get_int());
107 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());111 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());
@@ -111,7 +115,7 @@
111 write_db("db_unknown_setting.ini");115 write_db("db_unknown_setting.ini");
112116
113 // Default values must still be there.117 // Default values must still be there.
114 EXPECT_EQ(4, db->settings().size());118 EXPECT_EQ(4u, db->settings().size());
115 EXPECT_EQ("London", db->settings()["locationSetting"].get_string());119 EXPECT_EQ("London", db->settings()["locationSetting"].get_string());
116 EXPECT_EQ(1, db->settings()["unitTempSetting"].get_int());120 EXPECT_EQ(1, db->settings()["unitTempSetting"].get_int());
117 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());121 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());
@@ -119,7 +123,7 @@
119123
120 // Change the location.124 // Change the location.
121 write_db("db_location.ini");125 write_db("db_location.ini");
122 EXPECT_EQ(4, db->settings().size());126 EXPECT_EQ(4u, db->settings().size());
123 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());127 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());
124 EXPECT_EQ(1, db->settings()["unitTempSetting"].get_int());128 EXPECT_EQ(1, db->settings()["unitTempSetting"].get_int());
125 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());129 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());
@@ -127,7 +131,7 @@
127131
128 // Change the unit.132 // Change the unit.
129 write_db("db_loctemp.ini");133 write_db("db_loctemp.ini");
130 EXPECT_EQ(4, db->settings().size());134 EXPECT_EQ(4u, db->settings().size());
131 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());135 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());
132 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());136 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());
133 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());137 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());
@@ -135,7 +139,7 @@
135139
136 // Change the age.140 // Change the age.
137 write_db("db_loctempage.ini");141 write_db("db_loctempage.ini");
138 EXPECT_EQ(4, db->settings().size());142 EXPECT_EQ(4u, db->settings().size());
139 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());143 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());
140 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());144 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());
141 EXPECT_EQ(42.0, db->settings()["ageSetting"].get_double());145 EXPECT_EQ(42.0, db->settings()["ageSetting"].get_double());
@@ -144,7 +148,7 @@
144 // Call settings again. This causes state_changed_ in the implementation148 // Call settings again. This causes state_changed_ in the implementation
145 // to remain false because the generation count hasn't changed, meaning149 // to remain false because the generation count hasn't changed, meaning
146 // that we must see the same unchanged values as last time.150 // that we must see the same unchanged values as last time.
147 EXPECT_EQ(4, db->settings().size());151 EXPECT_EQ(4u, db->settings().size());
148 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());152 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());
149 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());153 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());
150 EXPECT_EQ(42, db->settings()["ageSetting"].get_double());154 EXPECT_EQ(42, db->settings()["ageSetting"].get_double());
@@ -152,7 +156,7 @@
152156
153 // Change enabled boolean.157 // Change enabled boolean.
154 write_db("db_loctempageenabled.ini");158 write_db("db_loctempageenabled.ini");
155 EXPECT_EQ(4, db->settings().size());159 EXPECT_EQ(4u, db->settings().size());
156 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());160 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());
157 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());161 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());
158 EXPECT_EQ(42, db->settings()["ageSetting"].get_double());162 EXPECT_EQ(42, db->settings()["ageSetting"].get_double());
@@ -167,7 +171,7 @@
167 auto db = SettingsDB::create_from_ini_file(db_name, schema);171 auto db = SettingsDB::create_from_ini_file(db_name, schema);
168172
169 // Check that we now can see only the other two values. (DB doesn't exist yet.)173 // Check that we now can see only the other two values. (DB doesn't exist yet.)
170 EXPECT_EQ(2, db->settings().size());174 EXPECT_EQ(2u, db->settings().size());
171 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());175 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());
172 EXPECT_TRUE(db->settings()["enabledSetting"].get_bool());176 EXPECT_TRUE(db->settings()["enabledSetting"].get_bool());
173177
@@ -175,7 +179,7 @@
175 write_db("db_loctemp.ini");179 write_db("db_loctemp.ini");
176180
177 // Check that they are correct181 // Check that they are correct
178 EXPECT_EQ(4, db->settings().size());182 EXPECT_EQ(4u, db->settings().size());
179 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());183 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());
180 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());184 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());
181 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());185 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());
@@ -193,7 +197,7 @@
193 write_db("db_loctemp.ini");197 write_db("db_loctemp.ini");
194198
195 // Check that they are correct.199 // Check that they are correct.
196 EXPECT_EQ(4, db->settings().size());200 EXPECT_EQ(4u, db->settings().size());
197 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());201 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());
198 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());202 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());
199 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());203 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());
@@ -203,7 +207,7 @@
203 write_db("db_loctemp_bad_age.ini");207 write_db("db_loctemp_bad_age.ini");
204208
205 // Check that nothing has changed.209 // Check that nothing has changed.
206 EXPECT_EQ(4, db->settings().size());210 EXPECT_EQ(4u, db->settings().size());
207 EXPECT_EQ("Paris", db->settings()["locationSetting"].get_string());211 EXPECT_EQ("Paris", db->settings()["locationSetting"].get_string());
208 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());212 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());
209 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());213 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());
@@ -220,12 +224,12 @@
220 auto db = SettingsDB::create_from_ini_file(db_name, schema);224 auto db = SettingsDB::create_from_ini_file(db_name, schema);
221225
222 // If db doesn't exist, default values are returned.226 // If db doesn't exist, default values are returned.
223 EXPECT_EQ(1, db->settings().size());227 EXPECT_EQ(1u, db->settings().size());
224 EXPECT_EQ("çš„", db->settings()["locationSetting"].get_string());228 EXPECT_EQ("çš„", db->settings()["locationSetting"].get_string());
225229
226 // Change the location.230 // Change the location.
227 write_db("db_chinese_location.ini");231 write_db("db_chinese_location.ini");
228 EXPECT_EQ(1, db->settings().size());232 EXPECT_EQ(1u, db->settings().size());
229 EXPECT_EQ("丈", db->settings()["locationSetting"].get_string());233 EXPECT_EQ("丈", db->settings()["locationSetting"].get_string());
230 }234 }
231}235}
@@ -239,7 +243,7 @@
239 auto db = SettingsDB::create_from_ini_file(db_name, schema);243 auto db = SettingsDB::create_from_ini_file(db_name, schema);
240244
241 // If db doesn't exist, default values are returned.245 // If db doesn't exist, default values are returned.
242 EXPECT_EQ(4, db->settings().size());246 EXPECT_EQ(4u, db->settings().size());
243 EXPECT_EQ("London", db->settings()["locationSetting"].get_string());247 EXPECT_EQ("London", db->settings()["locationSetting"].get_string());
244 EXPECT_EQ(1, db->settings()["unitTempSetting"].get_int());248 EXPECT_EQ(1, db->settings()["unitTempSetting"].get_int());
245 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());249 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());
@@ -249,7 +253,7 @@
249 write_db("db_loctempageenabled.ini");253 write_db("db_loctempageenabled.ini");
250254
251 // Settings should be updated.255 // Settings should be updated.
252 EXPECT_EQ(4, db->settings().size());256 EXPECT_EQ(4u, db->settings().size());
253 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());257 EXPECT_EQ("New York", db->settings()["locationSetting"].get_string());
254 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());258 EXPECT_EQ(0, db->settings()["unitTempSetting"].get_int());
255 EXPECT_EQ(42, db->settings()["ageSetting"].get_double());259 EXPECT_EQ(42, db->settings()["ageSetting"].get_double());
@@ -259,7 +263,7 @@
259 unlink(db_name.c_str());263 unlink(db_name.c_str());
260264
261 // Default values should come back.265 // Default values should come back.
262 EXPECT_EQ(4, db->settings().size());266 EXPECT_EQ(4u, db->settings().size());
263 EXPECT_EQ("London", db->settings()["locationSetting"].get_string());267 EXPECT_EQ("London", db->settings()["locationSetting"].get_string());
264 EXPECT_EQ(1, db->settings()["unitTempSetting"].get_int());268 EXPECT_EQ(1, db->settings()["unitTempSetting"].get_int());
265 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());269 EXPECT_EQ(23, db->settings()["ageSetting"].get_double());
@@ -290,12 +294,12 @@
290 auto db = SettingsDB::create_from_json_string(db_name, ok_schema);294 auto db = SettingsDB::create_from_json_string(db_name, ok_schema);
291295
292 // If db doesn't exist, default values are returned.296 // If db doesn't exist, default values are returned.
293 EXPECT_EQ(1, db->settings().size());297 EXPECT_EQ(1u, db->settings().size());
294 EXPECT_EQ("London", db->settings()["location"].get_string());298 EXPECT_EQ("London", db->settings()["location"].get_string());
295299
296 // Change the location.300 // Change the location.
297 write_db("db_location_json.ini");301 write_db("db_location_json.ini");
298 EXPECT_EQ(1, db->settings().size());302 EXPECT_EQ(1u, db->settings().size());
299 EXPECT_EQ("New York", db->settings()["location"].get_string());303 EXPECT_EQ("New York", db->settings()["location"].get_string());
300 }304 }
301}305}
@@ -363,7 +367,7 @@
363 auto schema = TEST_SRC_DIR "/schema.ini";367 auto schema = TEST_SRC_DIR "/schema.ini";
364 auto db = SettingsDB::create_from_ini_file(db_name, schema);368 auto db = SettingsDB::create_from_ini_file(db_name, schema);
365369
366 EXPECT_EQ(4, db->settings().size());370 EXPECT_EQ(4u, db->settings().size());
367 EXPECT_EQ("Munich", db->settings()["locationSetting"].get_string());371 EXPECT_EQ("Munich", db->settings()["locationSetting"].get_string());
368372
369373
@@ -381,7 +385,7 @@
381 }385 }
382 catch (ResourceException const& e)386 catch (ResourceException const& e)
383 {387 {
384 boost::regex r("unity::ResourceException: unity::FileException: Could not load ini file .*: Key file contains line 'x' which is not a key-value pair, group, or comment \\(errno = 1\\)");388 boost::regex r("unity::ResourceException: unity::FileException: Could not load ini file .*: Key file contains line .*");
385 EXPECT_TRUE(boost::regex_match(e.what(), r)) << e.what();389 EXPECT_TRUE(boost::regex_match(e.what(), r)) << e.what();
386 }390 }
387}391}
388392
=== modified file 'test/gtest/scopes/internal/ThreadPool/ThreadPool_test.cpp'
--- test/gtest/scopes/internal/ThreadPool/ThreadPool_test.cpp 2014-09-22 05:50:56 +0000
+++ test/gtest/scopes/internal/ThreadPool/ThreadPool_test.cpp 2016-11-28 10:48:16 +0000
@@ -20,7 +20,11 @@
2020
21#include <unity/UnityExceptions.h>21#include <unity/UnityExceptions.h>
2222
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
23#include <gtest/gtest.h>25#include <gtest/gtest.h>
26#pragma GCC diagnostic pop
27
24#include <valgrind/valgrind.h>28#include <valgrind/valgrind.h>
2529
26using namespace std;30using namespace std;
2731
=== modified file 'test/gtest/scopes/internal/ThreadSafeQueue/ThreadSafeQueue_test.cpp'
--- test/gtest/scopes/internal/ThreadSafeQueue/ThreadSafeQueue_test.cpp 2014-09-08 05:55:39 +0000
+++ test/gtest/scopes/internal/ThreadSafeQueue/ThreadSafeQueue_test.cpp 2016-11-28 10:48:16 +0000
@@ -18,7 +18,10 @@
1818
19#include <unity/scopes/internal/ThreadSafeQueue.h>19#include <unity/scopes/internal/ThreadSafeQueue.h>
2020
21#pragma GCC diagnostic push
22#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
21#include <gtest/gtest.h>23#include <gtest/gtest.h>
24#pragma GCC diagnostic pop
2225
23#include <future>26#include <future>
2427
2528
=== modified file 'test/gtest/scopes/internal/UniqueID/UniqueID_test.cpp'
--- test/gtest/scopes/internal/UniqueID/UniqueID_test.cpp 2014-02-25 12:08:41 +0000
+++ test/gtest/scopes/internal/UniqueID/UniqueID_test.cpp 2016-11-28 10:48:16 +0000
@@ -18,7 +18,10 @@
1818
19#include <unity/scopes/internal/UniqueID.h>19#include <unity/scopes/internal/UniqueID.h>
2020
21#pragma GCC diagnostic push
22#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
21#include <gtest/gtest.h>23#include <gtest/gtest.h>
24#pragma GCC diagnostic pop
2225
23using namespace std;26using namespace std;
24using namespace unity::scopes::internal;27using namespace unity::scopes::internal;
2528
=== modified file 'test/gtest/scopes/internal/Utils/Utils_test.cpp'
--- test/gtest/scopes/internal/Utils/Utils_test.cpp 2016-10-07 15:42:53 +0000
+++ test/gtest/scopes/internal/Utils/Utils_test.cpp 2016-11-28 10:48:16 +0000
@@ -18,9 +18,14 @@
1818
19#include <unity/scopes/internal/Utils.h>19#include <unity/scopes/internal/Utils.h>
2020
21#include <unity/UnityExceptions.h>
22
21#include <boost/filesystem.hpp>23#include <boost/filesystem.hpp>
24
25#pragma GCC diagnostic push
26#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
22#include <gtest/gtest.h>27#include <gtest/gtest.h>
23#include <unity/UnityExceptions.h>28#pragma GCC diagnostic pop
2429
25using namespace unity::scopes;30using namespace unity::scopes;
26using namespace unity::scopes::internal;31using namespace unity::scopes::internal;
@@ -39,13 +44,24 @@
3944
40TEST(Utils, uncamelcase_turkish)45TEST(Utils, uncamelcase_turkish)
41{46{
42 char *old_locale = strdup(getenv("LC_ALL"));47 string old_locale;
48 char const* p = getenv("LC_ALL");
49 if (p)
50 {
51 old_locale = p;
52 }
43 setenv("LC_ALL", "tr_TR.UTF-8", 1);53 setenv("LC_ALL", "tr_TR.UTF-8", 1);
4454
45 EXPECT_EQ("small-i", uncamelcase("smallI"));55 EXPECT_EQ("small-i", uncamelcase("smallI"));
4656
47 setenv("LC_ALL", old_locale, 1);57 if (!old_locale.empty())
48 free(old_locale);58 {
59 setenv("LC_ALL", old_locale.c_str(), 1);
60 }
61 else
62 {
63 unsetenv("LC_ALL");
64 }
49}65}
5066
51TEST(Utils, convert_to)67TEST(Utils, convert_to)
@@ -170,7 +186,7 @@
170186
171 // Test argument splitting187 // Test argument splitting
172 auto exec_args = split_exec_args("test", "/path\\ to/exec' 'file arg \"arg 2\" arg' '3 arg\\ 4");188 auto exec_args = split_exec_args("test", "/path\\ to/exec' 'file arg \"arg 2\" arg' '3 arg\\ 4");
173 ASSERT_EQ(5, exec_args.size());189 ASSERT_EQ(5u, exec_args.size());
174 EXPECT_STREQ("\"/path to/exec file\"", exec_args[0].c_str());190 EXPECT_STREQ("\"/path to/exec file\"", exec_args[0].c_str());
175 EXPECT_STREQ("arg", exec_args[1].c_str());191 EXPECT_STREQ("arg", exec_args[1].c_str());
176 EXPECT_STREQ("\"arg 2\"", exec_args[2].c_str());192 EXPECT_STREQ("\"arg 2\"", exec_args[2].c_str());
177193
=== modified file 'test/gtest/scopes/internal/gobj_ptr/gobj_ptr_test.cpp'
--- test/gtest/scopes/internal/gobj_ptr/gobj_ptr_test.cpp 2016-03-15 04:43:56 +0000
+++ test/gtest/scopes/internal/gobj_ptr/gobj_ptr_test.cpp 2016-11-28 10:48:16 +0000
@@ -22,7 +22,11 @@
2222
23#include <unity/scopes/internal/gobj_memory.h>23#include <unity/scopes/internal/gobj_memory.h>
24#include <glib-object.h>24#include <glib-object.h>
25
26#pragma GCC diagnostic push
27#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
25#include <gtest/gtest.h>28#include <gtest/gtest.h>
29#pragma GCC diagnostic pop
2630
27using namespace std;31using namespace std;
28using namespace unity::scopes::internal;32using namespace unity::scopes::internal;
@@ -87,17 +91,17 @@
87TEST(Gobj_ptr, refcount)91TEST(Gobj_ptr, refcount)
88{92{
89 GObject* o = G_OBJECT(g_object_new(G_TYPE_OBJECT, nullptr));93 GObject* o = G_OBJECT(g_object_new(G_TYPE_OBJECT, nullptr));
90 EXPECT_EQ(1, o->ref_count);94 EXPECT_EQ(1u, o->ref_count);
91 g_object_ref(o);95 g_object_ref(o);
9296
93 {97 {
94 EXPECT_EQ(2, o->ref_count);98 EXPECT_EQ(2u, o->ref_count);
95 gobj_ptr<GObject> u(o);99 gobj_ptr<GObject> u(o);
96 EXPECT_EQ(2, o->ref_count);100 EXPECT_EQ(2u, o->ref_count);
97 // Now it dies and refcount is reduced.101 // Now it dies and refcount is reduced.
98 }102 }
99103
100 EXPECT_EQ(1, o->ref_count);104 EXPECT_EQ(1u, o->ref_count);
101 g_object_unref(o);105 g_object_unref(o);
102}106}
103107
@@ -105,14 +109,14 @@
105{109{
106 GObject* o = G_OBJECT(g_object_new(G_TYPE_OBJECT, nullptr));110 GObject* o = G_OBJECT(g_object_new(G_TYPE_OBJECT, nullptr));
107 gobj_ptr<GObject> u(o);111 gobj_ptr<GObject> u(o);
108 EXPECT_EQ(1, u->ref_count);112 EXPECT_EQ(1u, u->ref_count);
109 gobj_ptr<GObject> u2(u);113 gobj_ptr<GObject> u2(u);
110 EXPECT_EQ(2, u->ref_count);114 EXPECT_EQ(2u, u->ref_count);
111 gobj_ptr<GObject> u3 = u2;115 gobj_ptr<GObject> u3 = u2;
112 EXPECT_EQ(3, u->ref_count);116 EXPECT_EQ(3u, u->ref_count);
113 u3.reset();117 u3.reset();
114 u2.reset();118 u2.reset();
115 EXPECT_EQ(1, u->ref_count);119 EXPECT_EQ(1u, u->ref_count);
116}120}
117121
118TEST(Gobj_ptr, swap)122TEST(Gobj_ptr, swap)
119123
=== modified file 'test/gtest/scopes/internal/safe_strerror/safe_strerror_test.cpp'
--- test/gtest/scopes/internal/safe_strerror/safe_strerror_test.cpp 2014-11-17 01:29:26 +0000
+++ test/gtest/scopes/internal/safe_strerror/safe_strerror_test.cpp 2016-11-28 10:48:16 +0000
@@ -17,7 +17,11 @@
17 */17 */
1818
19#include <unity/scopes/internal/safe_strerror.h>19#include <unity/scopes/internal/safe_strerror.h>
20
21#pragma GCC diagnostic push
22#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
20#include <gtest/gtest.h>23#include <gtest/gtest.h>
24#pragma GCC diagnostic pop
2125
22using namespace unity::scopes::internal;26using namespace unity::scopes::internal;
2327
2428
=== modified file 'test/gtest/scopes/internal/smartscopes/HttpClient/HttpClient_test.cpp'
--- test/gtest/scopes/internal/smartscopes/HttpClient/HttpClient_test.cpp 2015-01-16 06:13:57 +0000
+++ test/gtest/scopes/internal/smartscopes/HttpClient/HttpClient_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,7 +21,11 @@
2121
22#include "../RaiiServer.h"22#include "../RaiiServer.h"
2323
24#pragma GCC diagnostic push
25#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>26#include <gtest/gtest.h>
27#pragma GCC diagnostic pop
28
25#include <memory>29#include <memory>
26#include <thread>30#include <thread>
2731
2832
=== modified file 'test/gtest/scopes/internal/smartscopes/SSConfig/SSConfig_test.cpp'
--- test/gtest/scopes/internal/smartscopes/SSConfig/SSConfig_test.cpp 2014-07-25 07:29:19 +0000
+++ test/gtest/scopes/internal/smartscopes/SSConfig/SSConfig_test.cpp 2016-11-28 10:48:16 +0000
@@ -21,7 +21,10 @@
21#include <unity/scopes/ScopeExceptions.h>21#include <unity/scopes/ScopeExceptions.h>
22#include <unity/UnityExceptions.h>22#include <unity/UnityExceptions.h>
2323
24#pragma GCC diagnostic push
25#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
24#include <gtest/gtest.h>26#include <gtest/gtest.h>
27#pragma GCC diagnostic pop
2528
26using namespace std;29using namespace std;
27using namespace unity;30using namespace unity;
2831
=== modified file 'test/gtest/scopes/internal/smartscopes/SmartScopesClient/SmartScopesClient_test.cpp'
--- test/gtest/scopes/internal/smartscopes/SmartScopesClient/SmartScopesClient_test.cpp 2016-03-14 07:24:54 +0000
+++ test/gtest/scopes/internal/smartscopes/SmartScopesClient/SmartScopesClient_test.cpp 2016-11-28 10:48:16 +0000
@@ -29,7 +29,11 @@
2929
30#include "../RaiiServer.h"30#include "../RaiiServer.h"
3131
32#pragma GCC diagnostic push
33#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
32#include <gtest/gtest.h>34#include <gtest/gtest.h>
35#pragma GCC diagnostic pop
36
33#include <memory>37#include <memory>
34#include <thread>38#include <thread>
3539
@@ -84,7 +88,7 @@
8488
85 // first try an invalid locale (should throw)89 // first try an invalid locale (should throw)
86 EXPECT_THROW(ssc_->get_remote_scopes(scopes, "test_FAIL", false), std::exception);90 EXPECT_THROW(ssc_->get_remote_scopes(scopes, "test_FAIL", false), std::exception);
87 ASSERT_EQ(0, scopes.size());91 ASSERT_EQ(0u, scopes.size());
8892
89 // now try an empty locale93 // now try an empty locale
90 EXPECT_TRUE(ssc_->get_remote_scopes(scopes, "", false));94 EXPECT_TRUE(ssc_->get_remote_scopes(scopes, "", false));
@@ -165,7 +169,7 @@
165 params = vm["parameters"].get_dict();169 params = vm["parameters"].get_dict();
166 EXPECT_TRUE(params["defaultValue"].get_bool());170 EXPECT_TRUE(params["defaultValue"].get_bool());
167 }171 }
168 ASSERT_EQ(4, scopes[2].keywords.size());172 ASSERT_EQ(4u, scopes[2].keywords.size());
169 EXPECT_NE(scopes[2].keywords.end(), scopes[2].keywords.find("music"));173 EXPECT_NE(scopes[2].keywords.end(), scopes[2].keywords.find("music"));
170 EXPECT_NE(scopes[2].keywords.end(), scopes[2].keywords.find("video"));174 EXPECT_NE(scopes[2].keywords.end(), scopes[2].keywords.find("video"));
171 EXPECT_NE(scopes[2].keywords.end(), scopes[2].keywords.find("news"));175 EXPECT_NE(scopes[2].keywords.end(), scopes[2].keywords.find("news"));
@@ -265,27 +269,27 @@
265269
266 // check filters270 // check filters
267 EXPECT_FALSE(filters.empty());271 EXPECT_FALSE(filters.empty());
268 EXPECT_EQ(filters.size(), 1);272 EXPECT_EQ(1u, filters.size());
269 auto filter1 = filters.front();273 auto filter1 = filters.front();
270 auto option_filter = std::dynamic_pointer_cast<const OptionSelectorFilter>(filter1);274 auto option_filter = std::dynamic_pointer_cast<const OptionSelectorFilter>(filter1);
271 EXPECT_TRUE(option_filter != nullptr);275 EXPECT_TRUE(option_filter != nullptr);
272 EXPECT_EQ(option_filter->label(), "Label");276 EXPECT_EQ("Label", option_filter->label());
273 EXPECT_EQ(option_filter->id(), "sorting_primary_filter");277 EXPECT_EQ("sorting_primary_filter", option_filter->id());
274 EXPECT_EQ(option_filter->display_hints(), FilterBase::DisplayHints::Primary);278 EXPECT_EQ(FilterBase::DisplayHints::Primary, option_filter->display_hints());
275 EXPECT_EQ(option_filter->multi_select(), false);279 EXPECT_FALSE(option_filter->multi_select());
276280
277 auto options = option_filter->options();281 auto options = option_filter->options();
278 EXPECT_EQ(options.size(), 3);282 EXPECT_EQ(3u, options.size());
279 EXPECT_EQ(options.front()->id(), "titlerank");283 EXPECT_EQ("titlerank", options.front()->id());
280 EXPECT_EQ(options.front()->label(), "Title rank");284 EXPECT_EQ("Title rank", options.front()->label());
281 EXPECT_EQ(options.back()->id(), "salesrank");285 EXPECT_EQ("salesrank", options.back()->id());
282 EXPECT_EQ(options.back()->label(), "Bestselling");286 EXPECT_EQ("Bestselling", options.back()->label());
283287
284 EXPECT_TRUE(option_filter->has_active_option(filter_state));288 EXPECT_TRUE(option_filter->has_active_option(filter_state));
285 auto active_options = option_filter->active_options(filter_state);289 auto active_options = option_filter->active_options(filter_state);
286 EXPECT_FALSE(active_options.empty());290 EXPECT_FALSE(active_options.empty());
287 auto active_option = *(active_options.begin());291 auto active_option = *(active_options.begin());
288 EXPECT_EQ(active_option->id(), "salesrank");292 EXPECT_EQ("salesrank", active_option->id());
289}293}
290294
291TEST_F(SmartScopesClientTest, filter_groups)295TEST_F(SmartScopesClientTest, filter_groups)
@@ -326,7 +330,7 @@
326330
327 // check filters331 // check filters
328 EXPECT_FALSE(filters.empty());332 EXPECT_FALSE(filters.empty());
329 EXPECT_EQ(filters.size(), 1);333 EXPECT_EQ(1u, filters.size());
330 auto filter1 = filters.front();334 auto filter1 = filters.front();
331 auto option_filter = std::dynamic_pointer_cast<const OptionSelectorFilter>(filter1);335 auto option_filter = std::dynamic_pointer_cast<const OptionSelectorFilter>(filter1);
332 EXPECT_TRUE(option_filter != nullptr);336 EXPECT_TRUE(option_filter != nullptr);
@@ -334,19 +338,19 @@
334 EXPECT_TRUE(grp != nullptr);338 EXPECT_TRUE(grp != nullptr);
335 EXPECT_EQ("g1", grp->id());339 EXPECT_EQ("g1", grp->id());
336 EXPECT_EQ("Group 1", grp->label());340 EXPECT_EQ("Group 1", grp->label());
337 EXPECT_EQ(option_filter->label(), "Label");341 EXPECT_EQ("Label", option_filter->label());
338 EXPECT_EQ(option_filter->id(), "sorting_primary_filter");342 EXPECT_EQ("sorting_primary_filter", option_filter->id());
339 EXPECT_EQ(option_filter->display_hints(), FilterBase::DisplayHints::Primary);343 EXPECT_EQ(FilterBase::DisplayHints::Primary, option_filter->display_hints());
340 EXPECT_EQ(option_filter->multi_select(), false);344 EXPECT_FALSE(option_filter->multi_select());
341345
342 auto options = option_filter->options();346 auto options = option_filter->options();
343 EXPECT_EQ(options.size(), 2);347 EXPECT_EQ(2u, options.size());
344348
345 EXPECT_TRUE(option_filter->has_active_option(filter_state));349 EXPECT_TRUE(option_filter->has_active_option(filter_state));
346 auto active_options = option_filter->active_options(filter_state);350 auto active_options = option_filter->active_options(filter_state);
347 EXPECT_FALSE(active_options.empty());351 EXPECT_FALSE(active_options.empty());
348 auto active_option = *(active_options.begin());352 auto active_option = *(active_options.begin());
349 EXPECT_EQ(active_option->id(), "salesrank");353 EXPECT_EQ("salesrank", active_option->id());
350}354}
351355
352TEST_F(SmartScopesClientTest, userAgentHeader)356TEST_F(SmartScopesClientTest, userAgentHeader)
353357
=== modified file 'test/gtest/scopes/internal/smartscopes/smartscopesproxy/smartscopesproxy_test.cpp'
--- test/gtest/scopes/internal/smartscopes/smartscopesproxy/smartscopesproxy_test.cpp 2015-04-29 17:01:02 +0000
+++ test/gtest/scopes/internal/smartscopes/smartscopesproxy/smartscopesproxy_test.cpp 2016-11-28 10:48:16 +0000
@@ -32,7 +32,11 @@
32#include "../RaiiServer.h"32#include "../RaiiServer.h"
3333
34#include <memory>34#include <memory>
35
36#pragma GCC diagnostic push
37#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
35#include <gtest/gtest.h>38#include <gtest/gtest.h>
39#pragma GCC diagnostic pop
3640
37using namespace testing;41using namespace testing;
38using namespace unity::scopes;42using namespace unity::scopes;
@@ -136,15 +140,15 @@
136 EXPECT_EQ("Dummy demo scope 3.", meta.description());140 EXPECT_EQ("Dummy demo scope 3.", meta.description());
137 EXPECT_EQ("Mr.Fake", meta.author());141 EXPECT_EQ("Mr.Fake", meta.author());
138 EXPECT_FALSE(meta.invisible());142 EXPECT_FALSE(meta.invisible());
139 EXPECT_EQ(4, meta.settings_definitions().size());143 EXPECT_EQ(4u, meta.settings_definitions().size());
140 EXPECT_EQ("unitTemp", meta.settings_definitions()[1].get_dict()["id"].get_string());144 EXPECT_EQ("unitTemp", meta.settings_definitions()[1].get_dict()["id"].get_string());
141 EXPECT_EQ("Temperature Units", meta.settings_definitions()[1].get_dict()["displayName"].get_string());145 EXPECT_EQ("Temperature Units", meta.settings_definitions()[1].get_dict()["displayName"].get_string());
142 EXPECT_EQ("list", meta.settings_definitions()[1].get_dict()["type"].get_string());146 EXPECT_EQ("list", meta.settings_definitions()[1].get_dict()["type"].get_string());
143 EXPECT_EQ(1, meta.settings_definitions()[1].get_dict()["defaultValue"].get_int());147 EXPECT_EQ(1, meta.settings_definitions()[1].get_dict()["defaultValue"].get_int());
144 EXPECT_EQ(2, meta.settings_definitions()[1].get_dict()["displayValues"].get_array().size());148 EXPECT_EQ(2u, meta.settings_definitions()[1].get_dict()["displayValues"].get_array().size());
145 EXPECT_EQ("Celsius", meta.settings_definitions()[1].get_dict()["displayValues"].get_array()[0].get_string());149 EXPECT_EQ("Celsius", meta.settings_definitions()[1].get_dict()["displayValues"].get_array()[0].get_string());
146 EXPECT_EQ("Fahrenheit", meta.settings_definitions()[1].get_dict()["displayValues"].get_array()[1].get_string());150 EXPECT_EQ("Fahrenheit", meta.settings_definitions()[1].get_dict()["displayValues"].get_array()[1].get_string());
147 ASSERT_EQ(4, meta.keywords().size());151 ASSERT_EQ(4u, meta.keywords().size());
148 EXPECT_NE(meta.keywords().end(), meta.keywords().find("music"));152 EXPECT_NE(meta.keywords().end(), meta.keywords().find("music"));
149 EXPECT_NE(meta.keywords().end(), meta.keywords().find("video"));153 EXPECT_NE(meta.keywords().end(), meta.keywords().find("video"));
150 EXPECT_NE(meta.keywords().end(), meta.keywords().find("news"));154 EXPECT_NE(meta.keywords().end(), meta.keywords().find("news"));
@@ -176,12 +180,12 @@
176 EXPECT_EQ("Dummy demo scope 3.", meta.description());180 EXPECT_EQ("Dummy demo scope 3.", meta.description());
177 EXPECT_EQ("Mr.Fake", meta.author());181 EXPECT_EQ("Mr.Fake", meta.author());
178 EXPECT_FALSE(meta.invisible());182 EXPECT_FALSE(meta.invisible());
179 EXPECT_EQ(4, meta.settings_definitions().size());183 EXPECT_EQ(4u, meta.settings_definitions().size());
180 EXPECT_EQ("unitTemp", meta.settings_definitions()[1].get_dict()["id"].get_string());184 EXPECT_EQ("unitTemp", meta.settings_definitions()[1].get_dict()["id"].get_string());
181 EXPECT_EQ("Temperature Units", meta.settings_definitions()[1].get_dict()["displayName"].get_string());185 EXPECT_EQ("Temperature Units", meta.settings_definitions()[1].get_dict()["displayName"].get_string());
182 EXPECT_EQ("list", meta.settings_definitions()[1].get_dict()["type"].get_string());186 EXPECT_EQ("list", meta.settings_definitions()[1].get_dict()["type"].get_string());
183 EXPECT_EQ(1, meta.settings_definitions()[1].get_dict()["defaultValue"].get_int());187 EXPECT_EQ(1, meta.settings_definitions()[1].get_dict()["defaultValue"].get_int());
184 EXPECT_EQ(2, meta.settings_definitions()[1].get_dict()["displayValues"].get_array().size());188 EXPECT_EQ(2u, meta.settings_definitions()[1].get_dict()["displayValues"].get_array().size());
185 EXPECT_EQ("Celsius", meta.settings_definitions()[1].get_dict()["displayValues"].get_array()[0].get_string());189 EXPECT_EQ("Celsius", meta.settings_definitions()[1].get_dict()["displayValues"].get_array()[0].get_string());
186 EXPECT_EQ("Fahrenheit", meta.settings_definitions()[1].get_dict()["displayValues"].get_array()[1].get_string());190 EXPECT_EQ("Fahrenheit", meta.settings_definitions()[1].get_dict()["displayValues"].get_array()[1].get_string());
187 }191 }
@@ -192,7 +196,7 @@
192 // set an invalid LANGUAGE env var (should return 0 scopes)196 // set an invalid LANGUAGE env var (should return 0 scopes)
193 ::setenv("LANGUAGE", "test_FAIL", 1);197 ::setenv("LANGUAGE", "test_FAIL", 1);
194 reset_reg();198 reset_reg();
195 EXPECT_EQ(0, reg_->list().size());199 EXPECT_EQ(0u, reg_->list().size());
196200
197 // set an empty LANGUAGE env var (should return 2 scopes)201 // set an empty LANGUAGE env var (should return 2 scopes)
198 ::setenv("LANGUAGE", "", 1);202 ::setenv("LANGUAGE", "", 1);
@@ -217,7 +221,7 @@
217 // set a colon seperated LANGUAGE env var (first invalid - should return 0 scopes)221 // set a colon seperated LANGUAGE env var (first invalid - should return 0 scopes)
218 ::setenv("LANGUAGE", "test_FAIL:test_TEST", 1);222 ::setenv("LANGUAGE", "test_FAIL:test_TEST", 1);
219 reset_reg();223 reset_reg();
220 EXPECT_EQ(0, reg_->list().size());224 EXPECT_EQ(0u, reg_->list().size());
221}225}
222226
223class Receiver : public SearchListenerBase227class Receiver : public SearchListenerBase
224228
=== modified file 'test/gtest/scopes/internal/zmq_middleware/ConnectionPool/ConnectionPool_test.cpp'
--- test/gtest/scopes/internal/zmq_middleware/ConnectionPool/ConnectionPool_test.cpp 2014-10-09 00:49:02 +0000
+++ test/gtest/scopes/internal/zmq_middleware/ConnectionPool/ConnectionPool_test.cpp 2016-11-28 10:48:16 +0000
@@ -20,7 +20,10 @@
2020
21#include <zmqpp/context.hpp>21#include <zmqpp/context.hpp>
2222
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
23#include <gtest/gtest.h>25#include <gtest/gtest.h>
26#pragma GCC diagnostic pop
2427
25using namespace std;28using namespace std;
26using namespace unity::scopes::internal::zmq_middleware;29using namespace unity::scopes::internal::zmq_middleware;
2730
=== modified file 'test/gtest/scopes/internal/zmq_middleware/ObjectAdapter/ObjectAdapter_test.cpp'
--- test/gtest/scopes/internal/zmq_middleware/ObjectAdapter/ObjectAdapter_test.cpp 2014-11-18 07:04:04 +0000
+++ test/gtest/scopes/internal/zmq_middleware/ObjectAdapter/ObjectAdapter_test.cpp 2016-11-28 10:48:16 +0000
@@ -30,7 +30,11 @@
3030
31#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.31#include <boost/regex.hpp> // Use Boost implementation until http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53631 is fixed.
32#include <capnp/serialize.h>32#include <capnp/serialize.h>
33
34#pragma GCC diagnostic push
35#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
33#include <gtest/gtest.h>36#include <gtest/gtest.h>
37#pragma GCC diagnostic pop
3438
35using namespace std;39using namespace std;
36using namespace unity;40using namespace unity;
3741
=== modified file 'test/gtest/scopes/internal/zmq_middleware/PubSub/PubSub_test.cpp'
--- test/gtest/scopes/internal/zmq_middleware/PubSub/PubSub_test.cpp 2014-11-18 07:04:04 +0000
+++ test/gtest/scopes/internal/zmq_middleware/PubSub/PubSub_test.cpp 2016-11-28 10:48:16 +0000
@@ -20,7 +20,11 @@
20#include <unity/scopes/internal/zmq_middleware/ZmqMiddleware.h>20#include <unity/scopes/internal/zmq_middleware/ZmqMiddleware.h>
21#include <unity/scopes/ScopeExceptions.h>21#include <unity/scopes/ScopeExceptions.h>
2222
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
23#include <gtest/gtest.h>25#include <gtest/gtest.h>
26#pragma GCC diagnostic pop
27
24#include <condition_variable>28#include <condition_variable>
25#include <mutex>29#include <mutex>
2630
2731
=== modified file 'test/gtest/scopes/internal/zmq_middleware/RegistryI/RegistryI_test.cpp'
--- test/gtest/scopes/internal/zmq_middleware/RegistryI/RegistryI_test.cpp 2016-02-22 00:19:46 +0000
+++ test/gtest/scopes/internal/zmq_middleware/RegistryI/RegistryI_test.cpp 2016-11-28 10:48:16 +0000
@@ -52,7 +52,10 @@
5252
53#pragma pop_macro("BOOST_RANGE_ENABLE_CONCEPT_ASSERT")53#pragma pop_macro("BOOST_RANGE_ENABLE_CONCEPT_ASSERT")
5454
55#pragma GCC diagnostic push
56#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
55#include <gtest/gtest.h>57#include <gtest/gtest.h>
58#pragma GCC diagnostic pop
5659
57#include <array>60#include <array>
58#include <cassert>61#include <cassert>
@@ -459,7 +462,7 @@
459 pid_t only_child_pid()462 pid_t only_child_pid()
460 {463 {
461 auto pids = child_pids();464 auto pids = child_pids();
462 EXPECT_EQ(1, pids.size()) << "Expected to find a single child process";465 EXPECT_EQ(1u, pids.size()) << "Expected to find a single child process";
463 return pids[0];466 return pids[0];
464 }467 }
465468
466469
=== modified file 'test/gtest/scopes/internal/zmq_middleware/ServantBase/ServantBase_test.cpp'
--- test/gtest/scopes/internal/zmq_middleware/ServantBase/ServantBase_test.cpp 2014-11-18 07:04:04 +0000
+++ test/gtest/scopes/internal/zmq_middleware/ServantBase/ServantBase_test.cpp 2016-11-28 10:48:16 +0000
@@ -22,7 +22,10 @@
22#include <unity/scopes/internal/zmq_middleware/ObjectAdapter.h>22#include <unity/scopes/internal/zmq_middleware/ObjectAdapter.h>
23#include <unity/UnityExceptions.h>23#include <unity/UnityExceptions.h>
2424
25#pragma GCC diagnostic push
26#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
25#include <gtest/gtest.h>27#include <gtest/gtest.h>
28#pragma GCC diagnostic pop
2629
27#include <cassert>30#include <cassert>
2831
2932
=== modified file 'test/gtest/scopes/internal/zmq_middleware/StopPublisher/StopPublisher_test.cpp'
--- test/gtest/scopes/internal/zmq_middleware/StopPublisher/StopPublisher_test.cpp 2014-04-14 23:47:33 +0000
+++ test/gtest/scopes/internal/zmq_middleware/StopPublisher/StopPublisher_test.cpp 2016-11-28 10:48:16 +0000
@@ -20,7 +20,10 @@
20#include <unity/scopes/ScopeExceptions.h>20#include <unity/scopes/ScopeExceptions.h>
21#include <zmqpp/poller.hpp>21#include <zmqpp/poller.hpp>
2222
23#pragma GCC diagnostic push
24#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
23#include <gtest/gtest.h>25#include <gtest/gtest.h>
26#pragma GCC diagnostic pop
2427
25using namespace std;28using namespace std;
26using namespace unity::scopes;29using namespace unity::scopes;
2730
=== modified file 'test/gtest/scopes/internal/zmq_middleware/Util/Util_test.cpp'
--- test/gtest/scopes/internal/zmq_middleware/Util/Util_test.cpp 2014-08-28 00:20:56 +0000
+++ test/gtest/scopes/internal/zmq_middleware/Util/Util_test.cpp 2016-11-28 10:48:16 +0000
@@ -22,7 +22,11 @@
22#include <unity/scopes/ScopeExceptions.h>22#include <unity/scopes/ScopeExceptions.h>
2323
24#include <sys/un.h>24#include <sys/un.h>
25
26#pragma GCC diagnostic push
27#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
25#include <gtest/gtest.h>28#include <gtest/gtest.h>
29#pragma GCC diagnostic pop
2630
27using namespace std;31using namespace std;
28using namespace unity;32using namespace unity;
2933
=== modified file 'test/gtest/scopes/internal/zmq_middleware/VariantConverter/VariantConverter_test.cpp'
--- test/gtest/scopes/internal/zmq_middleware/VariantConverter/VariantConverter_test.cpp 2015-03-30 15:58:45 +0000
+++ test/gtest/scopes/internal/zmq_middleware/VariantConverter/VariantConverter_test.cpp 2016-11-28 10:48:16 +0000
@@ -20,8 +20,12 @@
20#include <scopes/internal/zmq_middleware/capnproto/ValueDict.capnp.h>20#include <scopes/internal/zmq_middleware/capnproto/ValueDict.capnp.h>
21#include <unity/UnityExceptions.h>21#include <unity/UnityExceptions.h>
2222
23#include <capnp/message.h>
24
25#pragma GCC diagnostic push
26#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
23#include <gtest/gtest.h>27#include <gtest/gtest.h>
24#include <capnp/message.h>28#pragma GCC diagnostic pop
2529
26using namespace std;30using namespace std;
27using namespace unity;31using namespace unity;
2832
=== modified file 'test/gtest/scopes/internal/zmq_middleware/ZmqMiddleware/ZmqMiddleware_test.cpp'
--- test/gtest/scopes/internal/zmq_middleware/ZmqMiddleware/ZmqMiddleware_test.cpp 2015-05-29 12:02:54 +0000
+++ test/gtest/scopes/internal/zmq_middleware/ZmqMiddleware/ZmqMiddleware_test.cpp 2016-11-28 10:48:16 +0000
@@ -23,7 +23,10 @@
23#include <unity/scopes/internal/zmq_middleware/ZmqObjectProxy.h>23#include <unity/scopes/internal/zmq_middleware/ZmqObjectProxy.h>
24#include <unity/scopes/ScopeExceptions.h>24#include <unity/scopes/ScopeExceptions.h>
2525
26#pragma GCC diagnostic push
27#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
26#include <gtest/gtest.h>28#include <gtest/gtest.h>
29#pragma GCC diagnostic pop
2730
28using namespace std;31using namespace std;
29using namespace unity::scopes;32using namespace unity::scopes;
3033
=== modified file 'test/gtest/scopes/qt/JsonAsyncReader/JsonAsyncReader_test.cpp'
--- test/gtest/scopes/qt/JsonAsyncReader/JsonAsyncReader_test.cpp 2015-02-19 02:30:09 +0000
+++ test/gtest/scopes/qt/JsonAsyncReader/JsonAsyncReader_test.cpp 2016-11-28 10:48:16 +0000
@@ -23,7 +23,11 @@
2323
24#include <QtCore/QJsonObject>24#include <QtCore/QJsonObject>
2525
26#pragma GCC diagnostic push
27#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
26#include <gtest/gtest.h>28#include <gtest/gtest.h>
29#pragma GCC diagnostic pop
30
27#include <core/posix/exec.h>31#include <core/posix/exec.h>
2832
29namespace posix = core::posix;33namespace posix = core::posix;
@@ -162,7 +166,7 @@
162 }166 }
163167
164 // check that we've got 5 valid results168 // check that we've got 5 valid results
165 EXPECT_EQ(results.size(), 5);169 EXPECT_EQ(5u, results.size());
166}170}
167171
168TEST_F(ExceptionsTest, check_xml_bad_formed)172TEST_F(ExceptionsTest, check_xml_bad_formed)
169173
=== modified file 'test/gtest/scopes/qt/XmlAsyncReader/XmlAsyncReader_test.cpp'
--- test/gtest/scopes/qt/XmlAsyncReader/XmlAsyncReader_test.cpp 2015-02-19 02:30:09 +0000
+++ test/gtest/scopes/qt/XmlAsyncReader/XmlAsyncReader_test.cpp 2016-11-28 10:48:16 +0000
@@ -23,7 +23,10 @@
23#include <QtCore/QXmlStreamReader>23#include <QtCore/QXmlStreamReader>
24#include <QtCore/QJsonObject>24#include <QtCore/QJsonObject>
2525
26#pragma GCC diagnostic push
27#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
26#include <gtest/gtest.h>28#include <gtest/gtest.h>
29#pragma GCC diagnostic pop
2730
28#include <core/posix/exec.h>31#include <core/posix/exec.h>
2932
3033
=== modified file 'test/gtest/scopes/qt/qt-bindings/QActionMetadata_test.cpp'
--- test/gtest/scopes/qt/qt-bindings/QActionMetadata_test.cpp 2015-02-19 02:30:09 +0000
+++ test/gtest/scopes/qt/qt-bindings/QActionMetadata_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,10 @@
16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
2023
21#include <unity/scopes/qt/QActionMetadata.h>24#include <unity/scopes/qt/QActionMetadata.h>
2225
2326
=== modified file 'test/gtest/scopes/qt/qt-bindings/QCannedQuery_test.cpp'
--- test/gtest/scopes/qt/qt-bindings/QCannedQuery_test.cpp 2015-02-24 02:11:17 +0000
+++ test/gtest/scopes/qt/qt-bindings/QCannedQuery_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,10 @@
16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
2023
21#include <unity/scopes/qt/QCannedQuery.h>24#include <unity/scopes/qt/QCannedQuery.h>
22#include <unity/scopes/qt/internal/QCannedQueryImpl.h>25#include <unity/scopes/qt/internal/QCannedQueryImpl.h>
@@ -49,7 +52,7 @@
4952
50 unity::scopes::VariantMap api_map = api_query->serialize();53 unity::scopes::VariantMap api_map = api_query->serialize();
51 QVariantMap qt_map = query.serialize();54 QVariantMap qt_map = query.serialize();
52 EXPECT_EQ(api_map.size(), qt_map.size());55 EXPECT_EQ(int(api_map.size()), qt_map.size());
53 EXPECT_TRUE(qt_map.size() != 0);56 EXPECT_TRUE(qt_map.size() != 0);
54 EXPECT_EQ(variantmap_to_qvariantmap(api_map), qt_map);57 EXPECT_EQ(variantmap_to_qvariantmap(api_map), qt_map);
5558
5659
=== modified file 'test/gtest/scopes/qt/qt-bindings/QCategorisedResult_test.cpp'
--- test/gtest/scopes/qt/qt-bindings/QCategorisedResult_test.cpp 2015-02-25 12:37:03 +0000
+++ test/gtest/scopes/qt/qt-bindings/QCategorisedResult_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,10 @@
16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
2023
21#include <unity/scopes/qt/QCategorisedResult.h>24#include <unity/scopes/qt/QCategorisedResult.h>
22#include <unity/scopes/qt/QCategory.h>25#include <unity/scopes/qt/QCategory.h>
2326
=== modified file 'test/gtest/scopes/qt/qt-bindings/QColumnLayout_test.cpp'
--- test/gtest/scopes/qt/qt-bindings/QColumnLayout_test.cpp 2015-02-24 02:11:17 +0000
+++ test/gtest/scopes/qt/qt-bindings/QColumnLayout_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,10 @@
16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
2023
21#include <unity/scopes/qt/QColumnLayout.h>24#include <unity/scopes/qt/QColumnLayout.h>
22#include <unity/scopes/qt/internal/QColumnLayoutImpl.h>25#include <unity/scopes/qt/internal/QColumnLayoutImpl.h>
@@ -50,7 +53,7 @@
50 QVector<QString> retrieved_widget_ids = layout.column(0);53 QVector<QString> retrieved_widget_ids = layout.column(0);
5154
52 std::vector<std::string> api_widgets = api_layout->column(0);55 std::vector<std::string> api_widgets = api_layout->column(0);
53 EXPECT_EQ(api_widgets.size(), retrieved_widget_ids.size());56 EXPECT_EQ(int(api_widgets.size()), retrieved_widget_ids.size());
54 EXPECT_TRUE(api_widgets.size() != 0);57 EXPECT_TRUE(api_widgets.size() != 0);
55 for (uint i = 0; i < api_widgets.size(); ++i)58 for (uint i = 0; i < api_widgets.size(); ++i)
56 {59 {
@@ -59,7 +62,7 @@
5962
60 retrieved_widget_ids = layout.column(1);63 retrieved_widget_ids = layout.column(1);
61 api_widgets = api_layout->column(1);64 api_widgets = api_layout->column(1);
62 EXPECT_EQ(api_widgets.size(), retrieved_widget_ids.size());65 EXPECT_EQ(int(api_widgets.size()), retrieved_widget_ids.size());
63 EXPECT_TRUE(api_widgets.size() != 0);66 EXPECT_TRUE(api_widgets.size() != 0);
64 for (uint i = 0; i < api_widgets.size(); ++i)67 for (uint i = 0; i < api_widgets.size(); ++i)
65 {68 {
6669
=== modified file 'test/gtest/scopes/qt/qt-bindings/QDepartment_test.cpp'
--- test/gtest/scopes/qt/qt-bindings/QDepartment_test.cpp 2015-02-24 02:11:17 +0000
+++ test/gtest/scopes/qt/qt-bindings/QDepartment_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,10 @@
16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
2023
21#include <unity/scopes/qt/QCannedQuery.h>24#include <unity/scopes/qt/QCannedQuery.h>
22#include <unity/scopes/qt/QDepartment.h>25#include <unity/scopes/qt/QDepartment.h>
@@ -63,7 +66,7 @@
63 unity::scopes::DepartmentList api_list = api_dep->subdepartments();66 unity::scopes::DepartmentList api_list = api_dep->subdepartments();
6467
65 EXPECT_TRUE(qt_list.size() != 0);68 EXPECT_TRUE(qt_list.size() != 0);
66 EXPECT_EQ(qt_list.size(), api_list.size());69 EXPECT_EQ(qt_list.size(), int(api_list.size()));
6770
68 std::vector<std::string> dep_ids;71 std::vector<std::string> dep_ids;
69 for (auto item : api_list)72 for (auto item : api_list)
7073
=== modified file 'test/gtest/scopes/qt/qt-bindings/QPreviewQueryBaseAPI_test.cpp'
--- test/gtest/scopes/qt/qt-bindings/QPreviewQueryBaseAPI_test.cpp 2015-02-19 05:27:04 +0000
+++ test/gtest/scopes/qt/qt-bindings/QPreviewQueryBaseAPI_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,8 +16,10 @@
16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>
17 */17 */
1818
19#include <gtest/gtest.h>19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
20#include <gmock/gmock.h>21#include <gmock/gmock.h>
22#pragma GCC diagnostic pop
2123
22#include "BasicEventsChecker.h"24#include "BasicEventsChecker.h"
23#include "TestSetup.h"25#include "TestSetup.h"
2426
=== modified file 'test/gtest/scopes/qt/qt-bindings/QPreviewWidget_test.cpp'
--- test/gtest/scopes/qt/qt-bindings/QPreviewWidget_test.cpp 2015-02-24 06:56:42 +0000
+++ test/gtest/scopes/qt/qt-bindings/QPreviewWidget_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,10 @@
16 * Authored by: Michi Henning <michi.henning@canonical.com>16 * Authored by: Michi Henning <michi.henning@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
2023
21#include <unity/scopes/qt/QPreviewWidget.h>24#include <unity/scopes/qt/QPreviewWidget.h>
22#include <unity/scopes/qt/internal/QPreviewWidgetImpl.h>25#include <unity/scopes/qt/internal/QPreviewWidgetImpl.h>
2326
=== modified file 'test/gtest/scopes/qt/qt-bindings/QScopeBaseAPIImpl_test.cpp'
--- test/gtest/scopes/qt/qt-bindings/QScopeBaseAPIImpl_test.cpp 2015-02-24 04:03:22 +0000
+++ test/gtest/scopes/qt/qt-bindings/QScopeBaseAPIImpl_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,9 +16,11 @@
16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>
17 */17 */
1818
19#include <gtest/gtest.h>19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
20#include <gmock/gmock.h>21#include <gmock/gmock.h>
21#include <gmock/gmock-actions.h>22#include <gmock/gmock-actions.h>
23#pragma GCC diagnostic pop
2224
23#include "QMockScope.h"25#include "QMockScope.h"
24#include "QScopeBaseAPIMock.h"26#include "QScopeBaseAPIMock.h"
2527
=== modified file 'test/gtest/scopes/qt/qt-bindings/QScopeCreation_test.cpp'
--- test/gtest/scopes/qt/qt-bindings/QScopeCreation_test.cpp 2015-02-24 04:05:51 +0000
+++ test/gtest/scopes/qt/qt-bindings/QScopeCreation_test.cpp 2016-11-28 10:48:16 +0000
@@ -17,7 +17,11 @@
17 */17 */
1818
19#include "FakeScope.h"19#include "FakeScope.h"
20
21#pragma GCC diagnostic push
22#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
20#include <gtest/gtest.h>23#include <gtest/gtest.h>
24#pragma GCC diagnostic pop
2125
22#include <unity/scopes/qt/QScopeBaseAPI.h>26#include <unity/scopes/qt/QScopeBaseAPI.h>
2327
2428
=== modified file 'test/gtest/scopes/qt/qt-bindings/QSearchMetadata_test.cpp'
--- test/gtest/scopes/qt/qt-bindings/QSearchMetadata_test.cpp 2015-02-19 02:30:09 +0000
+++ test/gtest/scopes/qt/qt-bindings/QSearchMetadata_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,10 @@
16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
2023
21#include <unity/scopes/qt/QSearchMetadata.h>24#include <unity/scopes/qt/QSearchMetadata.h>
2225
2326
=== modified file 'test/gtest/scopes/qt/qt-bindings/QSearchQueryBaseAPI_test.cpp'
--- test/gtest/scopes/qt/qt-bindings/QSearchQueryBaseAPI_test.cpp 2015-02-19 02:30:09 +0000
+++ test/gtest/scopes/qt/qt-bindings/QSearchQueryBaseAPI_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,8 +16,10 @@
16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>
17 */17 */
1818
19#include <gtest/gtest.h>19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
20#include <gmock/gmock.h>21#include <gmock/gmock.h>
22#pragma GCC diagnostic pop
2123
22#include "BasicEventsChecker.h"24#include "BasicEventsChecker.h"
23#include "TestSetup.h"25#include "TestSetup.h"
2426
=== modified file 'test/gtest/scopes/qt/qt-bindings/QUtils_test.cpp'
--- test/gtest/scopes/qt/qt-bindings/QUtils_test.cpp 2015-02-24 02:11:17 +0000
+++ test/gtest/scopes/qt/qt-bindings/QUtils_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,10 @@
16 * Authored by: Michi Henning <michi.henning@canonical.com>16 * Authored by: Michi Henning <michi.henning@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
2023
21#include <unity/scopes/qt/internal/QUtils.h>24#include <unity/scopes/qt/internal/QUtils.h>
2225
@@ -161,7 +164,7 @@
161 qvm["string"] = "Hello";164 qvm["string"] = "Hello";
162165
163 VariantMap vm = qvariantmap_to_variantmap(qvm);166 VariantMap vm = qvariantmap_to_variantmap(qvm);
164 ASSERT_EQ(2, vm.size());167 ASSERT_EQ(2u, vm.size());
165 EXPECT_EQ(42, vm["int"].get_int());168 EXPECT_EQ(42, vm["int"].get_int());
166 EXPECT_EQ("Hello", vm["string"].get_string());169 EXPECT_EQ("Hello", vm["string"].get_string());
167}170}
168171
=== modified file 'test/gtest/scopes/qt/qt-bindings/QVariantBuilder_test.cpp'
--- test/gtest/scopes/qt/qt-bindings/QVariantBuilder_test.cpp 2015-02-24 02:11:17 +0000
+++ test/gtest/scopes/qt/qt-bindings/QVariantBuilder_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,10 @@
16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>16 * Authored by: Xavi Garcia <xavi.garcia.mena@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
2023
21#include <unity/scopes/qt/QVariantBuilder.h>24#include <unity/scopes/qt/QVariantBuilder.h>
22#include <unity/scopes/qt/internal/QVariantBuilderImpl.h>25#include <unity/scopes/qt/internal/QVariantBuilderImpl.h>
2326
=== modified file 'test/gtest/scopes/stress/scopes-stress.cpp'
--- test/gtest/scopes/stress/scopes-stress.cpp 2014-10-24 17:59:48 +0000
+++ test/gtest/scopes/stress/scopes-stress.cpp 2016-11-28 10:48:16 +0000
@@ -18,7 +18,11 @@
1818
19// You may also include individual headers if you prefer.19// You may also include individual headers if you prefer.
20#include <unity-scopes.h>20#include <unity-scopes.h>
21
22#pragma GCC diagnostic push
23#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
21#include <gtest/gtest.h>24#include <gtest/gtest.h>
25#pragma GCC diagnostic pop
2226
23#include <boost/filesystem.hpp>27#include <boost/filesystem.hpp>
24#include <condition_variable>28#include <condition_variable>
@@ -107,7 +111,7 @@
107 RegistryProxy r = rt->registry();111 RegistryProxy r = rt->registry();
108112
109 auto scopes_meta = r->list();113 auto scopes_meta = r->list();
110 EXPECT_EQ(scopes_meta.size(), 3);114 EXPECT_EQ(3u, scopes_meta.size());
111115
112 const std::list<std::string> scopes {"scope1", "scope2", "scope3"};116 const std::list<std::string> scopes {"scope1", "scope2", "scope3"};
113117
@@ -131,7 +135,7 @@
131 {135 {
132 reply->wait_until_finished();136 reply->wait_until_finished();
133 cout << "finished query for scope " << reply->scope_id() << endl;137 cout << "finished query for scope " << reply->scope_id() << endl;
134 EXPECT_EQ(reply->result_count(), 20u);138 EXPECT_EQ(20, reply->result_count());
135 }139 }
136 }140 }
137}141}
138142
=== modified file 'test/gtest/scopes/testing/IsolatedScope/IsolatedScope_test.cpp'
--- test/gtest/scopes/testing/IsolatedScope/IsolatedScope_test.cpp 2015-01-28 09:03:59 +0000
+++ test/gtest/scopes/testing/IsolatedScope/IsolatedScope_test.cpp 2016-11-28 10:48:16 +0000
@@ -32,7 +32,10 @@
3232
33#include <unity/scopes/CategoryRenderer.h>33#include <unity/scopes/CategoryRenderer.h>
3434
35#pragma GCC diagnostic push
36#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
35#include <gtest/gtest.h>37#include <gtest/gtest.h>
38#pragma GCC diagnostic pop
3639
37#include "scope.h"40#include "scope.h"
3841
3942
=== modified file 'test/gtest/scopes/testing/IsolatedScopeBenchmark/IsolatedScopeBenchmark_test.cpp'
--- test/gtest/scopes/testing/IsolatedScopeBenchmark/IsolatedScopeBenchmark_test.cpp 2014-08-01 14:31:16 +0000
+++ test/gtest/scopes/testing/IsolatedScopeBenchmark/IsolatedScopeBenchmark_test.cpp 2016-11-28 10:48:16 +0000
@@ -26,7 +26,10 @@
2626
27#include <unity/scopes/CategoryRenderer.h>27#include <unity/scopes/CategoryRenderer.h>
2828
29#pragma GCC diagnostic push
30#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
29#include <gtest/gtest.h>31#include <gtest/gtest.h>
32#pragma GCC diagnostic pop
3033
31#include "config.h"34#include "config.h"
32#include "scope.h"35#include "scope.h"
3336
=== modified file 'test/gtest/scopes/testing/Statistics/Statistics_test.cpp'
--- test/gtest/scopes/testing/Statistics/Statistics_test.cpp 2014-08-28 00:20:56 +0000
+++ test/gtest/scopes/testing/Statistics/Statistics_test.cpp 2016-11-28 10:48:16 +0000
@@ -19,7 +19,10 @@
19#include <unity/scopes/testing/Benchmark.h>19#include <unity/scopes/testing/Benchmark.h>
20#include <unity/scopes/testing/Statistics.h>20#include <unity/scopes/testing/Statistics.h>
2121
22#pragma GCC diagnostic push
23#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
22#include <gtest/gtest.h>24#include <gtest/gtest.h>
25#pragma GCC diagnostic pop
2326
24#include "config.h"27#include "config.h"
2528
2629
=== modified file 'test/gtest/scopes/utility/BufferedResultForwarder/BufferedResultForwarder_test.cpp'
--- test/gtest/scopes/utility/BufferedResultForwarder/BufferedResultForwarder_test.cpp 2014-12-01 01:51:38 +0000
+++ test/gtest/scopes/utility/BufferedResultForwarder/BufferedResultForwarder_test.cpp 2016-11-28 10:48:16 +0000
@@ -16,7 +16,11 @@
16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>16 * Authored by: Pawel Stolowski <pawel.stolowski@canonical.com>
17 */17 */
1818
19#pragma GCC diagnostic push
20#pragma GCC diagnostic ignored "-Wctor-dtor-privacy"
19#include <gtest/gtest.h>21#include <gtest/gtest.h>
22#pragma GCC diagnostic pop
23
20#include <unity/scopes/utility/BufferedResultForwarder.h>24#include <unity/scopes/utility/BufferedResultForwarder.h>
21#include <unity/scopes/CategoryRenderer.h>25#include <unity/scopes/CategoryRenderer.h>
22#include <unity/scopes/testing/MockSearchReply.h>26#include <unity/scopes/testing/MockSearchReply.h>

Subscribers

People subscribed via source and target branches

to all changes: