Code review comment for lp:~michihenning/unity-scopes-api/config-fixes

Revision history for this message
Michal Hruby (mhr3) wrote :

> > Last thing is that we're putting the binaries in .../unity-scopes - imo that
> > dir should be reserved only for scopes. Although it will only ever contain
> > scopes that are controlled by us (and packaged as .debs), so not a big deal.
>
> Well, I hear you :-) I wasn't happy about the weird path we had:
> /usr/lib/<arch>/scoperunner/scoperunner.
>
> I don't think it matters that the three binaries are in the same directory as
> the scopes. We could make a bin subdirectory or some such, though. Would that
> improve things? (I'm open to either approach.)

Meh, let's keep it the way it is, as I said, no biggie.

Thanks for the other fixes, looks merge-able to me now :)

review: Approve

« Back to merge proposal