Code review comment for lp:~michihenning/unity-scopes-api/config-fixes

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

1447 +// For example, if a config file contains "Smartscopes.Registry.Idenity" instead
1448 +// of "SS.Registry.Identity" (did you spot it?), we print a warning,

This should read: '"Smartscopes.Registry.Idenity" instead of "Smartscopes.Registry.Identity"'

1298 - RuntimeImpl::UPtr reg_rt = RuntimeImpl::create(ss_reg_id, DFLT_SS_RUNTIME_INI);
1299 + RuntimeImpl::UPtr reg_rt = RuntimeImpl::create(ss_reg_id, config_file);

This change breaks the smart scopes proxy. As reg_rt->registry_identity() now returns the identity of the main registry and not the SS registry.

To fix this, smartscopesproxy.cpp line 143: needs to change
from: "reg_mw->add_registry_object(reg_rt->registry_identity(), reg);"
to: "reg_mw->add_registry_object(reg_rt->ss_registry_identity(), reg);"

review: Needs Fixing

« Back to merge proposal