Code review comment for lp:~michihenning/unity-scopes-api/abigail

Revision history for this message
Michi Henning (michihenning) wrote :

Dodji has fixed the issues around he different behaviour when using a dump vs comparing the base dump against the .so.

We'll have to wait until the next version of abigail makes it into archives. At that point, we'll also have to re-generate the base dumps because, as it turns out, they are currently not storing all of the relevant information.

At that point, we also should consider comparing against two dumps: the base dump, to make sure we haven't broken ABI with respect to the base, and the most recently-released version dump, to make sure that, in a later version, we haven't removed something that was added on an earlier (non-base) version, thereby breaking ABI not against the base, but against a version that was released into the wild.

« Back to merge proposal