Code review comment for lp:~michihenning/unity-scopes-api/abigail
Revision history for this message
| James Henstridge (jamesh) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Okay, so I guess there are two options here:
1. If you want to generate a new dump as part of the vbuild process, why not just have a custom_command that depends on the libunity-scopes target and outputs the ABI dump, rather than dealing with the "run_always" bits?
2. Do you even need to dump the current ABI to an XML file as part of the test? Might it be quicker to just have abidiff compare the reference XML dump against the just-built .so file? That would reduce the number of moving parts in the test, and would likely be even faster.
I can understand having a helper script to generate a dump based on the just-built library, but it doesn't seem like a prerequisite for running the tests.