Merge lp:~michihenning/unity-api/static-test-lib into lp:unity-api
Status: | Merged |
---|---|
Approved by: | Jussi Pakkanen |
Approved revision: | 62 |
Merged at revision: | 62 |
Proposed branch: | lp:~michihenning/unity-api/static-test-lib |
Merge into: | lp:unity-api |
Diff against target: |
138 lines (+34/-9) 8 files modified
CMakeLists.txt (+7/-0) src/CMakeLists.txt (+20/-2) test/gtest/CMakeLists.txt (+2/-2) test/gtest/unity/CMakeLists.txt (+1/-1) test/gtest/unity/util/Daemon/CMakeLists.txt (+1/-1) test/gtest/unity/util/DefinesPtrs/CMakeLists.txt (+1/-1) test/gtest/unity/util/FileIO/CMakeLists.txt (+1/-1) test/gtest/unity/util/ResourcePtr/CMakeLists.txt (+1/-1) |
To merge this branch: | bzr merge lp:~michihenning/unity-api/static-test-lib |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Jussi Pakkanen (community) | Needs Fixing | ||
Review via email:
|
Commit message
This changes the build environment to link the tests against a static version of the library, allows us to write unit tests for internal classes that are not visible through the public API (support classes in the internal namespace that don't have a public pimple facade).
Code is always compiled with -fPIC, so it can be used for both static and dynamic versions and we don't need to compile every source file twice with different compiler flags.
Description of the change
This changes the build environment to link the tests against a static version of the library, allows us to write unit tests for internal classes that are not visible through the public API (support classes in the internal namespace that don't have a public pimple facade).
Code is always compiled with -fPIC, so it can be used for both static and dynamic versions and we don't need to compile every source file twice with different compiler flags.
PASSED: Continuous integration, rev:61 jenkins. qa.ubuntu. com/job/ unity-api- ci/78/ jenkins. qa.ubuntu. com/job/ unity-api- saucy-armhf- ci/35 jenkins. qa.ubuntu. com/job/ unity-api- saucy-armhf- ci/35/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ unity-api- saucy-i386- ci/36
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ unity-api- ci/78/rebuild
http://