Code review comment for lp:~michihenning/thumbnailer/snap

Revision history for this message
James Henstridge (jamesh) wrote :

Looks good. I am a bit concerned about the "control" slot you're exposing though: the dbus interface auto connects, and I don't think we want this one auto-connecting.

Also, we don't ever acquire the name "com.canonical.ThumbnailerAdmin", so that doesn't sound quite right either.

I wonder if there is anything to allow snaps to communicate with other binaries from the same snap via dbus? If so, then we wouldn't even need this second slot.

« Back to merge proposal