Code review comment for lp:~michihenning/thumbnailer/gstreamer-plugins

> I don't think the GST_PLUGIN_PATH manipulation should be done here: instead,
> it probably belongs in the desktop-ubuntu-app-platform part.

I can raise a bug for that, but I'm not sure I agree. ubuntu-app-platform can't really know where a snap chooses to install additional plugins; they could be in a different path.

> In particular, I don't think we want to ignore the GStreamer plugins from
> ubuntu-app-platform: instead, GST_PLUGIN_PATH should be set to take plugins
> from our snap, and then ubuntu-app-platform second. That way we probably only
> need to ship libgstlibav.so, rather than an entire suite of elements.

We are not ignoring them. desktop-launch sets GST_PLUGIN_SYSTEM_PATH, and vs-thumb sets GST_PLUGIN_PATH. According to the gstreamer doc, it first loads anything in GST_PLUGIN_PATH, and then anything in GST_PLUGIN_SYSTEM_PATH. (If we were ignoring the libs in ubuntu-app-platform, it wouldn't work at all, but .ogg video extraction definitely works.)

None of the libraries in the explicit list are in ubuntu-app-platform. They are basically all dependencies of gstreamer when it uses the codecs in libav.

I can't for the life of me figure out at the moment why .mp4 won't work. I keep getting "Your GStreamer installation is missing a plug-in."