Code review comment for lp:~michihenning/storage-framework/registry

Revision history for this message
James Henstridge (jamesh) wrote :

Sorry for the delay in following up.

I still feel that it would be better to follow the naming convention of libonline-accounts for name vs. displayName. My default policy would be to maintain the same naming unless we've got a compelling reason to be different.

Additionally, to me "name" has connotations of uniqueness or the ability to be used as a key, while "display name" does not. The display name for an online-accounts account is certainly not unique, and could very well be blank.

« Back to merge proposal