Code review comment for lp:~michihenning/storage-framework/api2

Revision history for this message
Michi Henning (michihenning) wrote :

Hi Lukáš,

my apologies, I suspect the message got lost in translation. The *only* headers that matter for the v2 API are the ones in include/unity/storage/qt. Ignore any headers in subduers of this. (The new API does not use boost, does not use futures, etc.

We are not targeting Vivid, so Q_GADGET and Q_ENUM OK.

I'll check the hash function, thanks! The one that is there will do the job with std::unordered_map. I just had a brief look, and it seems it'll be easy enough to have a Qt-compatible hash function as well, so that'll be easy to fix. Thanks for pointing this out!

« Back to merge proposal