Code review comment for lp:~michihenning/storage-framework/api2

Revision history for this message
Albert Astals Cid (aacid) wrote :

you seem to be missing lots of NOTIFY stuff in the properties
i.e.
 Q_PROPERTY(unity::Storage::qt::StorageError error READ error)
will change at some point i guess?

Other properties seem to be missing CONSTANT, e.g.
 Q_PROPERTY(QString READ description)

QML will complain if using properties that are read but don't have neither CONSTANT nor NOTIFY

« Back to merge proposal