Code review comment for lp:~michihenning/online-accounts-api/leak-fix

Revision history for this message
Alberto Mardegan (mardy) wrote :

Hi Michi! I still do prefer an explicit delete, when the lifetime of the object is as simple as in this case (and yet I forgot it! :-) ).
If you still decide to go for the QScopedPointer, please add its include file to pending_call.h (now it works even without it, but compilation might break on a future Qt release).

review: Needs Fixing

« Back to merge proposal