Nux

Merge lp:~michihenning/nux/937583 into lp:nux

Proposed by Michi Henning
Status: Merged
Approved by: Michi Henning
Approved revision: 679
Merged at revision: 679
Proposed branch: lp:~michihenning/nux/937583
Merge into: lp:nux
Diff against target: 28 lines (+2/-6)
2 files modified
NuxCore/PropertyTraits.h (+1/-5)
configure.ac (+1/-1)
To merge this branch: bzr merge lp:~michihenning/nux/937583
Reviewer Review Type Date Requested Status
Michi Henning (community) Approve
Review via email: mp+127406@code.launchpad.net

Commit message

Fixed catch clause and removed #ifdef because it can be the same for Windows and Linux.

Removed duplicate -Werror flag from maintainer flags.

Description of the change

Fixed catch clause and removed #ifdef because it can be the same for Windows and Linux.

Removed duplicate -Werror flag from maintainer flags.

To post a comment you must log in.
Revision history for this message
Michi Henning (michihenning) wrote :

Trivial fix only.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NuxCore/PropertyTraits.h'
--- NuxCore/PropertyTraits.h 2011-10-02 06:43:17 +0000
+++ NuxCore/PropertyTraits.h 2012-10-02 02:06:22 +0000
@@ -86,11 +86,7 @@
86 try {86 try {
87 return ResultType(boost::lexical_cast<T>(serialized_form), true);87 return ResultType(boost::lexical_cast<T>(serialized_form), true);
88 }88 }
89#if defined(NUX_OS_WINDOWS)89 catch (const boost::bad_lexical_cast& ) {
90 catch (boost::bad_lexical_cast const& ) {
91#else
92 catch (boost::bad_lexical_cast const& e) {
93#endif
94 return std::make_pair<T, bool>(T(), false);90 return std::make_pair<T, bool>(T(), false);
95 }91 }
96 }92 }
9793
=== modified file 'configure.ac'
--- configure.ac 2012-10-02 00:33:24 +0000
+++ configure.ac 2012-10-02 02:06:22 +0000
@@ -353,7 +353,7 @@
353353
354AS_IF([test "x$enable_maintainer_mode" = "xyes" && test "x$GCC" = "xyes"],354AS_IF([test "x$enable_maintainer_mode" = "xyes" && test "x$GCC" = "xyes"],
355 [355 [
356 MAINTAINER_CFLAGS+="-Werror -Wall -Wextra -Werror -Wcast-align -Wno-uninitialized -Wempty-body -Wformat-security -Winit-self"356 MAINTAINER_CFLAGS+="-Werror -Wall -Wextra -Wcast-align -Wno-uninitialized -Wempty-body -Wformat-security -Winit-self"
357 ]357 ]
358)358)
359359

Subscribers

People subscribed via source and target branches