Code review comment for lp:~michihenning/apparmor-easyprof-ubuntu/new-thumbnailer-methods
Revision history for this message
| Michi Henning (michihenning) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
MaxBacklog is a tunable parameter that affects the internals of the client API. It's not necessarily used only for debugging.
TraceClient is sort of like debug. When turned on, we write log messages about API activity into the application log (well, stderr, really).
I don't really know anything about a debug policy group. (This is the first time I've heard of it.)
Basically, where this MR is coming from is that we have settings in gsettings, but the client API can't get at the settings because apparmor denies access. So, the easiest thing was to have the server read the settings values and feed them to the client, so the client-side API can configure itself appropriately.
I think it might be easiest to use the MR as is? I added the methods to all the groups that currently need access to the thumbnailer. It seemed easiest to go that way because the new methods are on the same interface, and anything that uses the thumbnailer needs to call them.