Code review comment for lp:~michihenning/apparmor-easyprof-ubuntu/new-thumbnailer-methods

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

ACK, ok, so the read only bit is settled.

As for the stable-phone-overlay, apps/scopes typically use the 'debug' policy for debugging. This policy group does not currently allow these proposed dbus methods. Are both MaxBacklog and TraceClient only used for debugging? Would it make sense to add them to the debug policy group instead? (This would be fine for a stable-phone-overlay because apps aren't supposed to ship with the debug policy group so there is little (if not nothing) that would need to be recompiled.

review: Needs Information

« Back to merge proposal