Code review comment for ~michal-maloszewski99/ubuntu/+source/simplestreams:lp-2013081-gpg-keys-jammyr

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

I think it is a good idea in general to also add a review slot for canonical-server.

I added an inline comment regarding your changelog entry, same for your commit message. It also applies to the MPs targeting the other releases.

Regarding the SRU bug description, the error message you added to Test Plan is kind of useless:

dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2

This is a generic error, it does not show what is the real issue. Please fix that.

review: Needs Fixing

« Back to merge proposal