Code review comment for ~michal-maloszewski99/ubuntu/+source/mako:fix-pkg-resources-mako

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

LGTM.

From the dh-python code, I see that if we wanted to get the dependency through setup.py, adding "setuptools" to the install requires would do the trick.

This looks good enough though, given mako 1.2.0 will no longer need that dependency.

It would be worth to add a note regarding the dependency being dropped in mako 1.2.0 to aid the next person touching the package in a future potential sync (this could go in the commit message).

While forwarding this to Debian may not make much sense in case the maintainer is planing on packaging the new 1.2.0 version of mako soon, it would be nice to mention the fix in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1010237 after it lands in kinetic.

« Back to merge proposal