Code review comment for ~michal-maloszewski99/ubuntu/+source/amavisd-new:merge-1.2.13.0-3_mantic
Revision history for this message
| Michał Małoszewski (michal-maloszewski99) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
"Leaving the formal review to Christian since he owns the review slot, but since he's on PTO today I can give some drive-by review comments:"
Due to that sentence, I haven't addressed fixes from Bryce's comment (it does not mean that I do not agree), but there might be situations where reviewers have different perspectives on something (what is obvious), and I would like to apply fixes after two people review it (if applicable).
Long story short, I do not want the situation where I add fixes after Bryce's review, then let's suppose specific thing is not okay according to the second reviewer, and then I would have to fix it again.
I would want to see comments from two reviewers, then do a kind of tradeoff, discuss if I wouldn't agree with any point, etc., and then apply changes once.