Code review comment for ~michal-maloszewski99/ubuntu/+source/amavisd-new:merge-1.2.13.0-3_mantic

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

We re-did the merge together

Theories and findings and differences:
- d/control: dh-apparmor should be ordered right
- d/control: indent before unrar and altermine is different
- d/rules: as mentioned before do not drop the mv (unless we understand why)
- d/rules: do not drop distzilla added in Debian

Underlying issue is that th emv fails, but not because the mv is wrong.
In Debian [1] auto_install does
Installing /<<PKGBUILDDIR>>/debian/amavisd-new/usr/bin/amavisd-submit
In our build it does:
Installing /<<PKGBUILDDIR>>/debian/tmp/usr/bin/amavisd-submit

Due to this, the later mv fails.
removing the mv isn't the solution, understanding what is wrong here is.

Debian:
   dh_auto_install -D .build/debian-build --destdir=debian/amavisd-new/ -i
 cd .build/debian-build && make -j4 install DESTDIR=/<<PKGBUILDDIR>>/debian/amavisd-new AM_UPDATE_INFO_DIR=no PREFIX=/usr
Ubuntu:
   dh_auto_install -D .build/debian-build
 cd .build/debian-build && make -j4 install DESTDIR=/<<PKGBUILDDIR>>/debian/tmp AM_UPDATE_INFO_DIR=no PREFIX=/usr

DESTDIR is different - that is the problem.
I do not see yet why that is the case :-/
This ^^ is what you have to find out and fix.

You also might want to re-use my branch merge-2.13.0-3-mantic-CE which fixes some issues in the changelog as we discussed.

[1]: https://buildd.debian.org/status/fetch.php?pkg=amavisd-new&arch=all&ver=1%3A2.13.0-3&stamp=1683851020&raw=1

review: Needs Fixing

« Back to merge proposal