Merge lp:~michaelh1/gcc-linaro/lp-602171 into lp:gcc-linaro/4.4

Proposed by Michael Hope
Status: Merged
Approved by: Andrew Stubbs
Approved revision: no longer in the source branch.
Merged at revision: 93537
Proposed branch: lp:~michaelh1/gcc-linaro/lp-602171
Merge into: lp:gcc-linaro/4.4
Diff against target: 50 lines (+27/-1)
2 files modified
ChangeLog.linaro (+17/-0)
gcc/testsuite/gcc.target/i386/pr9771-1.c (+10/-1)
To merge this branch: bzr merge lp:~michaelh1/gcc-linaro/lp-602171
Reviewer Review Type Date Requested Status
Andrew Stubbs (community) Approve
Review via email: mp+29749@code.launchpad.net

This proposal supersedes a proposal from 2010-07-12.

Description of the change

Fixes LP: #602171

To post a comment you must log in.
Revision history for this message
Loïc Minier (lool) : Posted in a previous version of this proposal
review: Abstain
Revision history for this message
Michael Hope (michaelh1) wrote :

Note that r93536, which is the main body, and r93537, which fixes a double-paste, need to be merged.

Revision history for this message
Andrew Stubbs (ams-codesourcery) wrote :

The patch looks fine, but the ChangeLog could use a little work.

Next time, please do it like this:

2010-07-13 Michael Hope <email address hidden>

 LP: #602171

 Backport from FSF (r159776):
        2010-05-24 Paul Brook <email address hidden>
 * gcc.target/i386/pr9771-1.c: Move code out of main to allow frame
 pointer elimination.

I.e. no need to add your own changelog, and omit the extra text.

This is fine this time though. I'll merge it myself so that it doesn't interfere with the release process.

Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ChangeLog.linaro'
2--- ChangeLog.linaro 2010-07-09 11:47:12 +0000
3+++ ChangeLog.linaro 2010-07-12 21:45:00 +0000
4@@ -1,3 +1,20 @@
5+2010-07-13 Michael Hope <michael.hope@linaro.org>
6+
7+ LP: #602171
8+ * gcc/testsuite/gcc.target/i386/pr9771-1.c: Merge r159776 from FSF
9+ GCC into the Linaro branch.
10+ * gcc/testsuite/gcc.target/arm/frame-pointer-1.c: Likewise.
11+
12+ Original entry:
13+ 2010-05-24 Paul Brook <paul@codesourcery.com>
14+
15+ * gcc.target/arm/frame-pointer-1.c: New test.
16+ * gcc.target/i386/pr9771-1.c: Move code out of main to allow frame
17+ pointer elimination.
18+
19+ Note that the change was already present but the test cases hadn't
20+ been updated.
21+
22 2010-07-09 Andrew Stubbs <ams@codesourcery.com>
23
24 gcc/
25
26=== modified file 'gcc/testsuite/gcc.target/i386/pr9771-1.c'
27--- gcc/testsuite/gcc.target/i386/pr9771-1.c 2007-08-22 08:59:14 +0000
28+++ gcc/testsuite/gcc.target/i386/pr9771-1.c 2010-07-12 21:45:00 +0000
29@@ -28,7 +28,10 @@
30 *adr = save;
31 }
32
33-int main()
34+/* This must not be inlined becuase main() requires the frame pointer
35+ for stack alignment. */
36+void test(void) __attribute__((noinline));
37+void test(void)
38 {
39 B = &x;
40
41@@ -42,3 +45,9 @@
42 exit(0);
43 }
44
45+int main()
46+{
47+ test();
48+ return 0;
49+
50+}

Subscribers

People subscribed via source and target branches