Code review comment for lp:~michael.nelson/ubuntu-webcatalog/render_404_rather_than_raise_exception

Revision history for this message
James Westby (james-w) wrote :

68 + 'instance_id': 'dev',

It is preferred not to set instance_id at all.

16 +[oops_datedir_publisher]
17 +type = datedir
18 +error_dir = /tmp/uwc-oops/
19 +instance_id = dev

Why override from the default here? Having the oopses in-tree seems
preferable to me anyway.

Other than that this looks excellent.

Thanks,

James

review: Approve

« Back to merge proposal