Code review comment for lp:~michael.nelson/ubuntu-webcatalog/953306-display-app-version

On Wed, Mar 14, 2012 at 11:11 PM, Anthony Lenton
<email address hidden> wrote:
> Hi Michael,
>
> Thanks for the branch!  The only thing I think would be missing would be to also import the version for for-purchase apps, within the import_for_purchase_apps command.
>

Sheesh - you had me worried there for a second. It is there, you can
see it being tested line 389 of the MP diff, it's just that
import_for_purchase_apps didn't contain the change, it uses a form to
clean the data and the form was updated (first part of the diff).

> About rev. 77, I think it's neat if the tests can all work with the same mock_response.  Why is test_app_is_not_created_if_already_in_webcatalog removed though? Was that already tested by a different test?

Yeah, with test_existing_app_gets_updated_by_archive_id, it made sense
that part of this test was to ensure not only that the existing app is
updated, but that the number of apps didn't change. If you think it
should be separate, just let me know.

Thanks!