Code review comment for lp:~michael.nelson/ubuntu-webcatalog/953306-display-app-version

Revision history for this message
Anthony Lenton (elachuni) wrote :

Hi Michael,

Thanks for the branch! The only thing I think would be missing would be to also import the version for for-purchase apps, within the import_for_purchase_apps command.

About rev. 77, I think it's neat if the tests can all work with the same mock_response. Why is test_app_is_not_created_if_already_in_webcatalog removed though? Was that already tested by a different test?

Cheers,

achuni.

« Back to merge proposal