Merge lp:~michael.nelson/snapcraft/fix-golang-tutorial-to-match-changes-from-r132 into lp:~snappy-dev/snapcraft/core
| Status: | Merged |
|---|---|
| Approved by: | Sergio Schvezov on 2015-09-07 |
| Approved revision: | 153 |
| Merged at revision: | 151 |
| Proposed branch: | lp:~michael.nelson/snapcraft/fix-golang-tutorial-to-match-changes-from-r132 |
| Merge into: | lp:~snappy-dev/snapcraft/core |
| Diff against target: |
95 lines (+18/-23) 1 file modified
docs/your-first-snap.md (+18/-23) |
| To merge this branch: | bzr merge lp:~michael.nelson/snapcraft/fix-golang-tutorial-to-match-changes-from-r132 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sergio Schvezov | 2015-09-04 | Approve on 2015-09-07 | |
|
Review via email:
|
|||
Commit Message
Fix snapcraft.yaml's reference to go-package plugin to match changes in r132.
Description of the Change
Without this, following the tutorial results in:
$ snapcraft stage
Unknown plugin: go1.4-project
Could not load part go1.4-project
Currently, if you try to add a:
snappy-
to your snapcraft.yaml, you'll see an error [1]. Turns out the metadata is now expected in the snapcraft.yaml itself, so README updated to match that after testing locally.
- 152. By Michael Nelson on 2015-09-04
-
Update your-first-snap now that metadata is in the snapcraft.yaml file itself.
| Sergio Schvezov (sergiusens) wrote : | # |
- 153. By Michael Nelson on 2015-09-07
-
Switch example icon to text-x-apport.png
| Michael Nelson (michael.nelson) wrote : | # |
On Mon, Sep 7, 2015 at 11:21 PM Sergio Schvezov <
<email address hidden>> wrote:
> it all looks good, thanks, just maybe pick a different a icon?
>
> Diff comments:
>
> > === modified file 'docs/your-
> > --- docs/your-
> > +++ docs/your-
> > @@ -213,9 +205,12 @@
> > plugin: copy
> > files:
> > webcam-webui: bin/webcam-webui
> > - snappy-metadata: meta
> > -
> > -And tell Snapcraft to actually make the snap package:
> > +
> > +Copy a png icon of your choice into your current directory:
> > +
> > + $ cp /usr/share/
> ./icon.png
>
> how about a different icon?
>
>
Done. It's just an example to run the demo (as the icon is now required),
but I've switch it
to /usr/share/
| Sergio Schvezov (sergiusens) wrote : | # |
Ok, thanks! I'll improve snapcraft init to get a 'template' of the required fields soon, it's one of the reasons I disabled daily builds as of yet.


it all looks good, thanks, just maybe pick a different a icon?