Code review comment for lp:~michael.nelson/launchpad/include-binary-size

Revision history for this message
Michael Nelson (michael.nelson) wrote :

r16523 adds functionality requested by cjwatson (including the sha1).

08:59 < cjwatson> I know wgrant said that adding hashes would be "probably overcomplicated", but cf. bug 1088527
08:59 < noodles775> Wow - 40mins from 6hrs.
08:59 < noodles775> Looking
08:59 < _mup_> Bug #1088527: Needlessly asks for exact package name, file size, uploaded version <ca-escalated> <Developer registration portal:New for michael.nelson> <Launchpad itself:In Progress by michael.nelson> < https://launchpad.net/bugs/1088527 >
09:00 < cjwatson> Err, sorry
09:00 < cjwatson> cf. bug 1007195
09:01 < cjwatson> is what I meant to say
09:01 < _mup_> Bug #1007195: Librarian-backed HostedFile objects do not expose SHA-1 hash <soyuz-build> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1007195 >
09:01 < cjwatson> (Doesn't specifically have to be the SHA-1 of course; I think that was just what the librarian keyed off at the time or something
09:01 < cjwatson> )
09:02 < cjwatson> Anyway, don't let me get in the way by expanding the scope of your work, it was just in case it was trivial to allow for it
09:03 < noodles775> cjwatson: sure - it should be trivial. So s/include_sizes/include_meta/ and add the the sha1 to the dict?
09:07 < cjwatson> I guess something like that

« Back to merge proposal