Code review comment for lp:~michael.nelson/launchpad/copy-binaries-timeout

= Summary =

This branch addresses some of the causes of bug 447138.

Five options for improving the performance when copying a large number
of binaries are identified at:
https://bugs.edge.launchpad.net/soyuz/+bug/447138/comments/1

This branch addresses points (1) and (4).

== Proposed fix ==

Create IPublishingSet.copyBinariesTo() so that we only need to lookup
the 'main' component once (point 1 above) and only need one query to
obtain all the newly created BPPHs.

== Pre-implementation notes ==

See comment #1 on bug above.

== Implementation details ==

== Tests ==

bin/test -vv -t test_copypackage -t doc/pubishing.txt

== Demo and Q/A ==

I'll start Q/Aing this on dogfood now. In production we can ask the arch
admins to try including binaries when copying linux kernel package.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/scripts/packagecopier.py
  lib/lp/soyuz/model/publishing.py
  lib/lp/soyuz/interfaces/publishing.py

== Pylint notices ==

lib/lp/soyuz/scripts/packagecopier.py
    27: [F0401] Unable to import 'lazr.delegates' (No module named
delegates)

lib/lp/soyuz/interfaces/publishing.py
    33: [F0401] Unable to import 'lazr.enum' (No module named enum)
    40: [F0401] Unable to import 'lazr.restful.fields' (No module named
restful)
    41: [F0401] Unable to import 'lazr.restful.declarations' (No module
named restful)

--
Michael