Merge lp:~michael.nelson/launchpad/567922-binarypackagebuild-packagebuild-4 into lp:launchpad/db-devel
- 567922-binarypackagebuild-packagebuild-4
- Merge into db-devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Michael Nelson | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 9405 | ||||
Proposed branch: | lp:~michael.nelson/launchpad/567922-binarypackagebuild-packagebuild-4 | ||||
Merge into: | lp:launchpad/db-devel | ||||
Prerequisite: | lp:~michael.nelson/launchpad/567922-binarypackagebuild-packagebuild-3 | ||||
Diff against target: |
711 lines (+184/-237) (has conflicts) 11 files modified
BRANCH.TODO (+6/-0) lib/lp/buildmaster/interfaces/buildfarmjob.py (+40/-34) lib/lp/buildmaster/model/buildfarmjob.py (+109/-97) lib/lp/buildmaster/model/packagebuild.py (+8/-71) lib/lp/buildmaster/tests/test_buildfarmjob.py (+0/-12) lib/lp/code/model/sourcepackagerecipebuild.py (+4/-4) lib/lp/soyuz/interfaces/buildfarmbuildjob.py (+2/-2) lib/lp/soyuz/model/buildpackagejob.py (+6/-6) lib/lp/soyuz/tests/test_buildpackagejob.py (+3/-3) lib/lp/translations/model/translationtemplatesbuildjob.py (+3/-4) lib/lp/translations/tests/test_translationtemplatesbuildjob.py (+3/-4) Text conflict in lib/lp/buildmaster/interfaces/buildbase.py Text conflict in lib/lp/buildmaster/model/buildbase.py Text conflict in lib/lp/buildmaster/tests/test_buildbase.py |
||||
To merge this branch: | bzr merge lp:~michael.nelson/launchpad/567922-binarypackagebuild-packagebuild-4 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Review via email: mp+24356@code.launchpad.net |
Commit message
Description of the change
This branch is part of a pipeline for
https:/
https:/
Overview
========
The changes in this branch just do a bit of cleaning up after the refactoring of the past 3 branches.
The previous 3 branches added all the IBuildBase attributes and methods to IBuildFarmJob/
This branch does some retrospective cleaning up.
Details
=======
The previous branches update the IBuildFarmJob as planned so that new database-backed BuildFarmJob/
So, to simplify the ongoing refactoring work, I split out IBuildFarmJobOld from IBuildFarmJob, where IBuildFarmJobOld is the exact interface that existing classes currently expect, while IBuildFarmJob is a superset representing the new database-backed objects. I also added a note in the BRANCH.TODO that these *Old classes will be removed before the branch is landed.
This allowed IBuildFarmJob and IPackageBuild to be simplified, as they no longer need to worry about whether they are representing a database-backed object or not.
This branch is dependent on the pending schema patch in a previous branch.
To test
=======
First update the test db schema (required as the db patch still needs to be updated to remove the old build table):
psql launchpad_
bin/py database/
And then either:
bin/test -vvt test_*build (lots of tests), or for a quicker run:
bin/test -vvt test_packagebuild -t test_buildfarmjob -t doc/build.txt -t test_buildqueue -t test_sourcepack
(there is one intentional test failure in test_buildfarmjob for a method that can't be implemented until I switch BinaryPackageBuild to the new delegation model of IPackageBuild/
The next branch will (finally) the work to switch BinaryPackageBuild from the old build table to the new buildfarmjob/
Abel Deuring (adeuring) : | # |
Preview Diff
1 | === modified file 'BRANCH.TODO' | |||
2 | --- BRANCH.TODO 2010-05-05 15:48:49 +0000 | |||
3 | +++ BRANCH.TODO 2010-05-05 15:48:52 +0000 | |||
4 | @@ -2,6 +2,12 @@ | |||
5 | 2 | # landing. There is a test to ensure it is empty in trunk. If there is | 2 | # landing. There is a test to ensure it is empty in trunk. If there is |
6 | 3 | # stuff still here when you are ready to land, the items should probably | 3 | # stuff still here when you are ready to land, the items should probably |
7 | 4 | # be converted to bugs so they can be scheduled. | 4 | # be converted to bugs so they can be scheduled. |
8 | 5 | The following temporary classes need to be removed before this branch can | ||
9 | 6 | land: | ||
10 | 7 | * BuildFarmJobOld/IBuildFarmJobOld (update the classes using this to | ||
11 | 8 | use the new db versions). | ||
12 | 9 | * BuildFarmJobOldDerived (move queue-methods onto BuildFarmJobDerived). | ||
13 | 10 | * BuildBase. | ||
14 | 5 | 11 | ||
15 | 6 | The static methods on IBuildFarmJob/IPackageBuild should be reverted | 12 | The static methods on IBuildFarmJob/IPackageBuild should be reverted |
16 | 7 | to normal methods once all *Build classes have transitioned to the new | 13 | to normal methods once all *Build classes have transitioned to the new |
17 | 8 | 14 | ||
18 | === modified file 'lib/lp/buildmaster/interfaces/buildfarmjob.py' | |||
19 | --- lib/lp/buildmaster/interfaces/buildfarmjob.py 2010-05-05 15:48:49 +0000 | |||
20 | +++ lib/lp/buildmaster/interfaces/buildfarmjob.py 2010-05-05 15:48:52 +0000 | |||
21 | @@ -9,6 +9,7 @@ | |||
22 | 9 | 9 | ||
23 | 10 | __all__ = [ | 10 | __all__ = [ |
24 | 11 | 'IBuildFarmJob', | 11 | 'IBuildFarmJob', |
25 | 12 | 'IBuildFarmJobOld', | ||
26 | 12 | 'IBuildFarmJobSource', | 13 | 'IBuildFarmJobSource', |
27 | 13 | 'IBuildFarmJobDerived', | 14 | 'IBuildFarmJobDerived', |
28 | 14 | 'BuildFarmJobType', | 15 | 'BuildFarmJobType', |
29 | @@ -59,11 +60,18 @@ | |||
30 | 59 | """) | 60 | """) |
31 | 60 | 61 | ||
32 | 61 | 62 | ||
38 | 62 | class IBuildFarmJob(Interface): | 63 | class IBuildFarmJobOld(Interface): |
39 | 63 | """Operations that jobs for the build farm must implement.""" | 64 | """Defines the previous non-database BuildFarmJob interface. |
40 | 64 | 65 | ||
41 | 65 | id = Attribute('The build farm job ID.') | 66 | This interface is still used by the temporary build queue related |
42 | 66 | 67 | classes (TranslationTemplatesBuildJob, SourcePackageRecipeBuildJob | |
43 | 68 | and BuildPackageJob). | ||
44 | 69 | |||
45 | 70 | XXX 2010-04-28 michael.nelson bug=567922 | ||
46 | 71 | This class can be removed (merging all the attributes directly into | ||
47 | 72 | IBuildFarmJob) once all the corresponding *Build classes and the | ||
48 | 73 | BuildQueue have been transitioned to the new database schema. | ||
49 | 74 | """ | ||
50 | 67 | processor = Reference( | 75 | processor = Reference( |
51 | 68 | IProcessor, title=_("Processor"), required=False, readonly=True, | 76 | IProcessor, title=_("Processor"), required=False, readonly=True, |
52 | 69 | description=_( | 77 | description=_( |
53 | @@ -77,6 +85,33 @@ | |||
54 | 77 | "This should be None for job types that do not care whether " | 85 | "This should be None for job types that do not care whether " |
55 | 78 | "they run virtualized.")) | 86 | "they run virtualized.")) |
56 | 79 | 87 | ||
57 | 88 | def score(): | ||
58 | 89 | """Calculate a job score appropriate for the job type in question.""" | ||
59 | 90 | |||
60 | 91 | def getLogFileName(): | ||
61 | 92 | """The preferred file name for this job's log.""" | ||
62 | 93 | |||
63 | 94 | def getName(): | ||
64 | 95 | """An appropriate name for this job.""" | ||
65 | 96 | |||
66 | 97 | def getTitle(): | ||
67 | 98 | """A string to identify and describe the job to users.""" | ||
68 | 99 | |||
69 | 100 | def jobStarted(): | ||
70 | 101 | """'Job started' life cycle event, handle as appropriate.""" | ||
71 | 102 | |||
72 | 103 | def jobReset(): | ||
73 | 104 | """'Job reset' life cycle event, handle as appropriate.""" | ||
74 | 105 | |||
75 | 106 | def jobAborted(): | ||
76 | 107 | """'Job aborted' life cycle event, handle as appropriate.""" | ||
77 | 108 | |||
78 | 109 | |||
79 | 110 | class IBuildFarmJob(IBuildFarmJobOld): | ||
80 | 111 | """Operations that jobs for the build farm must implement.""" | ||
81 | 112 | |||
82 | 113 | id = Attribute('The build farm job ID.') | ||
83 | 114 | |||
84 | 80 | date_created = exported( | 115 | date_created = exported( |
85 | 81 | Datetime( | 116 | Datetime( |
86 | 82 | title=_("Date created"), required=True, readonly=True, | 117 | title=_("Date created"), required=True, readonly=True, |
87 | @@ -142,37 +177,8 @@ | |||
88 | 142 | vocabulary=BuildFarmJobType, | 177 | vocabulary=BuildFarmJobType, |
89 | 143 | description=_("The specific type of job.")) | 178 | description=_("The specific type of job.")) |
90 | 144 | 179 | ||
91 | 145 | # XXX 2010-04-21 michael.nelson bug=567922. This property | ||
92 | 146 | # can be removed once all *Build classes use the concrete | ||
93 | 147 | # BuildFarmJob. | ||
94 | 148 | has_concrete_build_farm_job = Bool( | ||
95 | 149 | title=_('Has concrete build farm job'), required=False, | ||
96 | 150 | readonly=True, description=_( | ||
97 | 151 | 'Whether this instance is or has a concrete build farm job.')) | ||
98 | 152 | |||
99 | 153 | title = exported(TextLine(title=_("Title"), required=False)) | 180 | title = exported(TextLine(title=_("Title"), required=False)) |
100 | 154 | 181 | ||
101 | 155 | def score(): | ||
102 | 156 | """Calculate a job score appropriate for the job type in question.""" | ||
103 | 157 | |||
104 | 158 | def getLogFileName(): | ||
105 | 159 | """The preferred file name for this job's log.""" | ||
106 | 160 | |||
107 | 161 | def getName(): | ||
108 | 162 | """An appropriate name for this job.""" | ||
109 | 163 | |||
110 | 164 | def getTitle(): | ||
111 | 165 | """A string to identify and describe the job to users.""" | ||
112 | 166 | |||
113 | 167 | def jobStarted(): | ||
114 | 168 | """'Job started' life cycle event, handle as appropriate.""" | ||
115 | 169 | |||
116 | 170 | def jobReset(): | ||
117 | 171 | """'Job reset' life cycle event, handle as appropriate.""" | ||
118 | 172 | |||
119 | 173 | def jobAborted(): | ||
120 | 174 | """'Job aborted' life cycle event, handle as appropriate.""" | ||
121 | 175 | |||
122 | 176 | def makeJob(): | 182 | def makeJob(): |
123 | 177 | """Create the specific job relating this with an lp.services.job. | 183 | """Create the specific job relating this with an lp.services.job. |
124 | 178 | 184 | ||
125 | 179 | 185 | ||
126 | === modified file 'lib/lp/buildmaster/model/buildfarmjob.py' | |||
127 | --- lib/lp/buildmaster/model/buildfarmjob.py 2010-05-05 15:48:49 +0000 | |||
128 | +++ lib/lp/buildmaster/model/buildfarmjob.py 2010-05-05 15:48:52 +0000 | |||
129 | @@ -5,6 +5,8 @@ | |||
130 | 5 | __all__ = [ | 5 | __all__ = [ |
131 | 6 | 'BuildFarmJob', | 6 | 'BuildFarmJob', |
132 | 7 | 'BuildFarmJobDerived', | 7 | 'BuildFarmJobDerived', |
133 | 8 | 'BuildFarmJobOld', | ||
134 | 9 | 'BuildFarmJobOldDerived', | ||
135 | 8 | ] | 10 | ] |
136 | 9 | 11 | ||
137 | 10 | 12 | ||
138 | @@ -15,7 +17,6 @@ | |||
139 | 15 | import hashlib | 17 | import hashlib |
140 | 16 | import pytz | 18 | import pytz |
141 | 17 | 19 | ||
142 | 18 | from storm.info import get_obj_info | ||
143 | 19 | from storm.locals import Bool, DateTime, Int, Reference, Storm | 20 | from storm.locals import Bool, DateTime, Int, Reference, Storm |
144 | 20 | from storm.store import Store | 21 | from storm.store import Store |
145 | 21 | 22 | ||
146 | @@ -32,13 +33,116 @@ | |||
147 | 32 | from lp.buildmaster.interfaces.buildbase import BuildStatus | 33 | from lp.buildmaster.interfaces.buildbase import BuildStatus |
148 | 33 | from lp.buildmaster.interfaces.buildfarmjob import ( | 34 | from lp.buildmaster.interfaces.buildfarmjob import ( |
149 | 34 | BuildFarmJobType, IBuildFarmJob, IBuildFarmJobDerived, | 35 | BuildFarmJobType, IBuildFarmJob, IBuildFarmJobDerived, |
151 | 35 | IBuildFarmJobSource) | 36 | IBuildFarmJobOld, IBuildFarmJobSource) |
152 | 36 | from lp.buildmaster.interfaces.buildqueue import IBuildQueueSet | 37 | from lp.buildmaster.interfaces.buildqueue import IBuildQueueSet |
153 | 37 | 38 | ||
154 | 38 | 39 | ||
156 | 39 | class BuildFarmJob(Storm): | 40 | class BuildFarmJobOld: |
157 | 41 | """See `IBuildFarmJobOld`.""" | ||
158 | 42 | implements(IBuildFarmJobOld) | ||
159 | 43 | processor = None | ||
160 | 44 | virtualized = None | ||
161 | 45 | |||
162 | 46 | def score(self): | ||
163 | 47 | """See `IBuildFarmJobOld`.""" | ||
164 | 48 | raise NotImplementedError | ||
165 | 49 | |||
166 | 50 | def getLogFileName(self): | ||
167 | 51 | """See `IBuildFarmJobOld`.""" | ||
168 | 52 | return 'buildlog.txt' | ||
169 | 53 | |||
170 | 54 | def getName(self): | ||
171 | 55 | """See `IBuildFarmJobOld`.""" | ||
172 | 56 | raise NotImplementedError | ||
173 | 57 | |||
174 | 58 | def getTitle(self): | ||
175 | 59 | """See `IBuildFarmJobOld`.""" | ||
176 | 60 | raise NotImplementedError | ||
177 | 61 | |||
178 | 62 | def makeJob(self): | ||
179 | 63 | """See `IBuildFarmJobOld`.""" | ||
180 | 64 | raise NotImplementedError | ||
181 | 65 | |||
182 | 66 | def jobStarted(self): | ||
183 | 67 | """See `IBuildFarmJobOld`.""" | ||
184 | 68 | pass | ||
185 | 69 | |||
186 | 70 | def jobReset(self): | ||
187 | 71 | """See `IBuildFarmJobOld`.""" | ||
188 | 72 | pass | ||
189 | 73 | |||
190 | 74 | def jobAborted(self): | ||
191 | 75 | """See `IBuildFarmJobOld`.""" | ||
192 | 76 | pass | ||
193 | 77 | |||
194 | 78 | |||
195 | 79 | class BuildFarmJobOldDerived: | ||
196 | 80 | delegates(IBuildFarmJobOld, context='build_farm_job') | ||
197 | 81 | |||
198 | 82 | def __init__(self, *args, **kwargs): | ||
199 | 83 | """Ensure the instance to which we delegate is set on creation.""" | ||
200 | 84 | self._set_build_farm_job() | ||
201 | 85 | super(BuildFarmJobOldDerived, self).__init__(*args, **kwargs) | ||
202 | 86 | |||
203 | 87 | def __storm_loaded__(self): | ||
204 | 88 | """Set the attribute for our IBuildFarmJob delegation. | ||
205 | 89 | |||
206 | 90 | This is needed here as __init__() is not called when a storm object | ||
207 | 91 | is loaded from the database. | ||
208 | 92 | """ | ||
209 | 93 | self._set_build_farm_job() | ||
210 | 94 | |||
211 | 95 | def _set_build_farm_job(self): | ||
212 | 96 | """Set the build farm job to which we will delegate. | ||
213 | 97 | |||
214 | 98 | Deriving classes must set the build_farm_job attribute for the | ||
215 | 99 | delegation. | ||
216 | 100 | """ | ||
217 | 101 | raise NotImplementedError | ||
218 | 102 | |||
219 | 103 | @classmethod | ||
220 | 104 | def getByJob(cls, job): | ||
221 | 105 | """See `IBuildFarmJobDerived`.""" | ||
222 | 106 | store = getUtility(IStoreSelector).get(MAIN_STORE, DEFAULT_FLAVOR) | ||
223 | 107 | return store.find(cls, cls.job == job).one() | ||
224 | 108 | |||
225 | 109 | @staticmethod | ||
226 | 110 | def addCandidateSelectionCriteria(processor, virtualized): | ||
227 | 111 | """See `IBuildFarmJobDerived`.""" | ||
228 | 112 | return ('') | ||
229 | 113 | |||
230 | 114 | @staticmethod | ||
231 | 115 | def postprocessCandidate(job, logger): | ||
232 | 116 | """See `IBuildFarmJobDerived`.""" | ||
233 | 117 | return True | ||
234 | 118 | |||
235 | 119 | def generateSlaveBuildCookie(self): | ||
236 | 120 | """See `IBuildFarmJobDerived`.""" | ||
237 | 121 | buildqueue = getUtility(IBuildQueueSet).getByJob(self.job) | ||
238 | 122 | |||
239 | 123 | if buildqueue.processor is None: | ||
240 | 124 | processor = '*' | ||
241 | 125 | else: | ||
242 | 126 | processor = repr(buildqueue.processor.id) | ||
243 | 127 | |||
244 | 128 | contents = ';'.join([ | ||
245 | 129 | repr(removeSecurityProxy(self.job).id), | ||
246 | 130 | self.job.date_created.isoformat(), | ||
247 | 131 | repr(buildqueue.id), | ||
248 | 132 | buildqueue.job_type.name, | ||
249 | 133 | processor, | ||
250 | 134 | self.getName(), | ||
251 | 135 | ]) | ||
252 | 136 | |||
253 | 137 | return hashlib.sha1(contents).hexdigest() | ||
254 | 138 | |||
255 | 139 | def cleanUp(self): | ||
256 | 140 | """See `IBuildFarmJob`.""" | ||
257 | 141 | Store.of(self).remove(self) | ||
258 | 142 | |||
259 | 143 | |||
260 | 144 | class BuildFarmJob(BuildFarmJobOld, Storm): | ||
261 | 40 | """A base implementation for `IBuildFarmJob` classes.""" | 145 | """A base implementation for `IBuildFarmJob` classes.""" |
262 | 41 | |||
263 | 42 | __storm_table__ = 'BuildFarmJob' | 146 | __storm_table__ = 'BuildFarmJob' |
264 | 43 | 147 | ||
265 | 44 | implements(IBuildFarmJob) | 148 | implements(IBuildFarmJob) |
266 | @@ -76,6 +180,7 @@ | |||
267 | 76 | 180 | ||
268 | 77 | def __init__(self, job_type, status=BuildStatus.NEEDSBUILD, | 181 | def __init__(self, job_type, status=BuildStatus.NEEDSBUILD, |
269 | 78 | processor=None, virtualized=None): | 182 | processor=None, virtualized=None): |
270 | 183 | super(BuildFarmJob, self).__init__() | ||
271 | 79 | self.job_type, self.status, self.process, self.virtualized = ( | 184 | self.job_type, self.status, self.process, self.virtualized = ( |
272 | 80 | job_type, | 185 | job_type, |
273 | 81 | status, | 186 | status, |
274 | @@ -95,40 +200,16 @@ | |||
275 | 95 | return build_farm_job | 200 | return build_farm_job |
276 | 96 | 201 | ||
277 | 97 | @property | 202 | @property |
278 | 98 | def has_concrete_build_farm_job(self): | ||
279 | 99 | """See `IBuildFarmJob`.""" | ||
280 | 100 | # Check if the object has been added to the store. | ||
281 | 101 | return get_obj_info(self).get('store') is not None | ||
282 | 102 | |||
283 | 103 | @property | ||
284 | 104 | def title(self): | 203 | def title(self): |
285 | 105 | """See `IBuildFarmJob`.""" | 204 | """See `IBuildFarmJob`.""" |
286 | 106 | return self.job_type.title | 205 | return self.job_type.title |
287 | 107 | 206 | ||
288 | 108 | def score(self): | ||
289 | 109 | """See `IBuildFarmJob`.""" | ||
290 | 110 | raise NotImplementedError | ||
291 | 111 | |||
292 | 112 | def getLogFileName(self): | ||
293 | 113 | """See `IBuildFarmJob`.""" | ||
294 | 114 | return 'buildlog.txt' | ||
295 | 115 | |||
296 | 116 | def getName(self): | ||
297 | 117 | """See `IBuildFarmJob`.""" | ||
298 | 118 | raise NotImplementedError | ||
299 | 119 | |||
300 | 120 | def getTitle(self): | ||
301 | 121 | """See `IBuildFarmJob`.""" | ||
302 | 122 | raise NotImplementedError | ||
303 | 123 | |||
304 | 124 | def makeJob(self): | 207 | def makeJob(self): |
305 | 125 | """See `IBuildFarmJob`.""" | 208 | """See `IBuildFarmJob`.""" |
306 | 126 | raise NotImplementedError | 209 | raise NotImplementedError |
307 | 127 | 210 | ||
308 | 128 | def jobStarted(self): | 211 | def jobStarted(self): |
309 | 129 | """See `IBuildFarmJob`.""" | 212 | """See `IBuildFarmJob`.""" |
310 | 130 | if not self.has_concrete_build_farm_job: | ||
311 | 131 | return | ||
312 | 132 | self.status = BuildStatus.BUILDING | 213 | self.status = BuildStatus.BUILDING |
313 | 133 | # The build started, set the start time if not set already. | 214 | # The build started, set the start time if not set already. |
314 | 134 | self.date_started = UTC_NOW | 215 | self.date_started = UTC_NOW |
315 | @@ -137,8 +218,6 @@ | |||
316 | 137 | 218 | ||
317 | 138 | def jobReset(self): | 219 | def jobReset(self): |
318 | 139 | """See `IBuildFarmJob`.""" | 220 | """See `IBuildFarmJob`.""" |
319 | 140 | if not self.has_concrete_build_farm_job: | ||
320 | 141 | return | ||
321 | 142 | self.status = BuildStatus.NEEDSBUILD | 221 | self.status = BuildStatus.NEEDSBUILD |
322 | 143 | self.date_started = None | 222 | self.date_started = None |
323 | 144 | 223 | ||
324 | @@ -186,70 +265,3 @@ | |||
325 | 186 | """See `IBuildFarmJobDerived`.""" | 265 | """See `IBuildFarmJobDerived`.""" |
326 | 187 | implements(IBuildFarmJobDerived) | 266 | implements(IBuildFarmJobDerived) |
327 | 188 | delegates(IBuildFarmJob, context='build_farm_job') | 267 | delegates(IBuildFarmJob, context='build_farm_job') |
328 | 189 | |||
329 | 190 | def __init__(self, *args, **kwargs): | ||
330 | 191 | """Ensure the instance to which we delegate is set on creation.""" | ||
331 | 192 | self._set_build_farm_job() | ||
332 | 193 | super(BuildFarmJobDerived, self).__init__(*args, **kwargs) | ||
333 | 194 | |||
334 | 195 | def __storm_loaded__(self): | ||
335 | 196 | """Set the attribute for our IBuildFarmJob delegation. | ||
336 | 197 | |||
337 | 198 | This is needed here as __init__() is not called when a storm object | ||
338 | 199 | is loaded from the database. | ||
339 | 200 | """ | ||
340 | 201 | self._set_build_farm_job() | ||
341 | 202 | |||
342 | 203 | def _set_build_farm_job(self): | ||
343 | 204 | """Set the default build farm job to which we will delegate. | ||
344 | 205 | |||
345 | 206 | Sub-classes should override as required. | ||
346 | 207 | |||
347 | 208 | XXX 2010-04-27 michael.nelson bug=570939 | ||
348 | 209 | This only exists because certain classes assume that | ||
349 | 210 | BuildFarmJob/PackageBuild are in-memory objects that simply | ||
350 | 211 | provide methods to update the associated builds. | ||
351 | 212 | We can remove it once the above bug is completed. | ||
352 | 213 | """ | ||
353 | 214 | self.build_farm_job = BuildFarmJob( | ||
354 | 215 | job_type=BuildFarmJobType.PACKAGEBUILD) | ||
355 | 216 | |||
356 | 217 | @classmethod | ||
357 | 218 | def getByJob(cls, job): | ||
358 | 219 | """See `IBuildFarmJobDerived`.""" | ||
359 | 220 | store = getUtility(IStoreSelector).get(MAIN_STORE, DEFAULT_FLAVOR) | ||
360 | 221 | return store.find(cls, cls.job == job).one() | ||
361 | 222 | |||
362 | 223 | @staticmethod | ||
363 | 224 | def addCandidateSelectionCriteria(processor, virtualized): | ||
364 | 225 | """See `IBuildFarmJobDerived`.""" | ||
365 | 226 | return ('') | ||
366 | 227 | |||
367 | 228 | @staticmethod | ||
368 | 229 | def postprocessCandidate(job, logger): | ||
369 | 230 | """See `IBuildFarmJobDerived`.""" | ||
370 | 231 | return True | ||
371 | 232 | |||
372 | 233 | def generateSlaveBuildCookie(self): | ||
373 | 234 | """See `IBuildFarmJobDerived`.""" | ||
374 | 235 | buildqueue = getUtility(IBuildQueueSet).getByJob(self.job) | ||
375 | 236 | |||
376 | 237 | if buildqueue.processor is None: | ||
377 | 238 | processor = '*' | ||
378 | 239 | else: | ||
379 | 240 | processor = repr(buildqueue.processor.id) | ||
380 | 241 | |||
381 | 242 | contents = ';'.join([ | ||
382 | 243 | repr(removeSecurityProxy(self.job).id), | ||
383 | 244 | self.job.date_created.isoformat(), | ||
384 | 245 | repr(buildqueue.id), | ||
385 | 246 | buildqueue.job_type.name, | ||
386 | 247 | processor, | ||
387 | 248 | self.getName(), | ||
388 | 249 | ]) | ||
389 | 250 | |||
390 | 251 | return hashlib.sha1(contents).hexdigest() | ||
391 | 252 | |||
392 | 253 | def cleanUp(self): | ||
393 | 254 | """See `IBuildFarmJob`.""" | ||
394 | 255 | Store.of(self).remove(self) | ||
395 | 256 | 268 | ||
396 | === modified file 'lib/lp/buildmaster/model/packagebuild.py' | |||
397 | --- lib/lp/buildmaster/model/packagebuild.py 2010-05-05 15:48:49 +0000 | |||
398 | +++ lib/lp/buildmaster/model/packagebuild.py 2010-05-05 15:48:52 +0000 | |||
399 | @@ -13,7 +13,6 @@ | |||
400 | 13 | from zope.component import getUtility | 13 | from zope.component import getUtility |
401 | 14 | from zope.interface import classProvides, implements | 14 | from zope.interface import classProvides, implements |
402 | 15 | 15 | ||
403 | 16 | from canonical.database.constants import UTC_NOW | ||
404 | 17 | from canonical.database.enumcol import DBEnum | 16 | from canonical.database.enumcol import DBEnum |
405 | 18 | from canonical.launchpad.browser.librarian import ( | 17 | from canonical.launchpad.browser.librarian import ( |
406 | 19 | ProxiedLibraryFileAlias) | 18 | ProxiedLibraryFileAlias) |
407 | @@ -59,19 +58,14 @@ | |||
408 | 59 | policy_name = 'buildd' | 58 | policy_name = 'buildd' |
409 | 60 | distribution = None | 59 | distribution = None |
410 | 61 | 60 | ||
422 | 62 | def __init__(self, build): | 61 | def __init__(self, build_farm_job, archive, pocket, |
423 | 63 | """Construct a PackageBuild. | 62 | dependencies=None): |
424 | 64 | 63 | """Construct a PackageBuild.""" | |
414 | 65 | XXX 2010-04-21 michael.nelson bug=570939 | ||
415 | 66 | This initialiser is only used by IBuildFarmJobDerived classes | ||
416 | 67 | that are not yet expecting a concrete BuildFarmJob (and so are | ||
417 | 68 | expecting to pass in the build to which they refer, such as | ||
418 | 69 | BinaryPackageBuild/BuildPackageJob, SPRecipeBuild/SPRecipeBuildJob | ||
419 | 70 | and TranslationTemplatesBuild). Once they have been updated it | ||
420 | 71 | can be updated for use by new below. | ||
421 | 72 | """ | ||
425 | 73 | super(PackageBuild, self).__init__() | 64 | super(PackageBuild, self).__init__() |
427 | 74 | self.build = build | 65 | self.build_farm_job = build_farm_job |
428 | 66 | self.archive = archive | ||
429 | 67 | self.pocket = pocket | ||
430 | 68 | self.dependencies = dependencies | ||
431 | 75 | 69 | ||
432 | 76 | @classmethod | 70 | @classmethod |
433 | 77 | def new(cls, job_type, virtualized, archive, pocket, | 71 | def new(cls, job_type, virtualized, archive, pocket, |
434 | @@ -84,67 +78,10 @@ | |||
435 | 84 | build_farm_job = getUtility(IBuildFarmJobSource).new( | 78 | build_farm_job = getUtility(IBuildFarmJobSource).new( |
436 | 85 | job_type, status, processor, virtualized) | 79 | job_type, status, processor, virtualized) |
437 | 86 | 80 | ||
445 | 87 | # Update the __init__ and call instead once all callsites use | 81 | package_build = cls(build_farm_job, archive, pocket, dependencies) |
439 | 88 | # instances of this class as a concrete class. | ||
440 | 89 | package_build = cls(None) | ||
441 | 90 | package_build.build_farm_job = build_farm_job | ||
442 | 91 | package_build.archive = archive | ||
443 | 92 | package_build.pocket = pocket | ||
444 | 93 | package_build.dependencies = dependencies | ||
446 | 94 | store.add(package_build) | 82 | store.add(package_build) |
447 | 95 | return package_build | 83 | return package_build |
448 | 96 | 84 | ||
449 | 97 | def getTitle(self): | ||
450 | 98 | """See `IBuildFarmJob`. | ||
451 | 99 | |||
452 | 100 | XXX 2010-04-21 michael.nelson bug=567922. This method | ||
453 | 101 | can be removed once all *Build classes use the concrete | ||
454 | 102 | BuildFarmJob. | ||
455 | 103 | """ | ||
456 | 104 | if self.has_concrete_build_farm_job: | ||
457 | 105 | return self.build_farm_job.getTitle() | ||
458 | 106 | |||
459 | 107 | return self.build.title | ||
460 | 108 | |||
461 | 109 | def jobStarted(self): | ||
462 | 110 | """See `IBuildFarmJob`. | ||
463 | 111 | |||
464 | 112 | XXX 2010-04-21 michael.nelson bug=567922. This method | ||
465 | 113 | can be removed once all *Build classes use the concrete | ||
466 | 114 | BuildFarmJob. | ||
467 | 115 | """ | ||
468 | 116 | if self.has_concrete_build_farm_job: | ||
469 | 117 | return self.build_farm_job.jobStarted() | ||
470 | 118 | |||
471 | 119 | self.build.buildstate = BuildStatus.BUILDING | ||
472 | 120 | # The build started, set the start time if not set already. | ||
473 | 121 | if self.build.date_first_dispatched is None: | ||
474 | 122 | self.build.date_first_dispatched = UTC_NOW | ||
475 | 123 | |||
476 | 124 | def jobReset(self): | ||
477 | 125 | """See `IBuildFarmJob`. | ||
478 | 126 | |||
479 | 127 | XXX 2010-04-21 michael.nelson bug=567922. This method | ||
480 | 128 | can be removed once all *Build classes use the concrete | ||
481 | 129 | BuildFarmJob. | ||
482 | 130 | """ | ||
483 | 131 | if self.has_concrete_build_farm_job: | ||
484 | 132 | return self.build_farm_job.jobReset() | ||
485 | 133 | |||
486 | 134 | self.build.buildstate = BuildStatus.NEEDSBUILD | ||
487 | 135 | |||
488 | 136 | def jobAborted(self): | ||
489 | 137 | """See `IBuildFarmJob`. | ||
490 | 138 | |||
491 | 139 | XXX 2010-04-21 michael.nelson bug=567922. This method | ||
492 | 140 | can be removed once all *Build classes use the concrete | ||
493 | 141 | BuildFarmJob. | ||
494 | 142 | """ | ||
495 | 143 | if self.has_concrete_build_farm_job: | ||
496 | 144 | return self.build_farm_job.jobAborted() | ||
497 | 145 | |||
498 | 146 | self.build.buildstate = BuildStatus.NEEDSBUILD | ||
499 | 147 | |||
500 | 148 | @property | 85 | @property |
501 | 149 | def current_component(self): | 86 | def current_component(self): |
502 | 150 | """See `IPackageBuild`.""" | 87 | """See `IPackageBuild`.""" |
503 | 151 | 88 | ||
504 | === modified file 'lib/lp/buildmaster/tests/test_buildfarmjob.py' | |||
505 | --- lib/lp/buildmaster/tests/test_buildfarmjob.py 2010-05-05 15:48:49 +0000 | |||
506 | +++ lib/lp/buildmaster/tests/test_buildfarmjob.py 2010-05-05 15:48:52 +0000 | |||
507 | @@ -34,18 +34,6 @@ | |||
508 | 34 | return getUtility(IBuildFarmJobSource).new( | 34 | return getUtility(IBuildFarmJobSource).new( |
509 | 35 | job_type=BuildFarmJobType.PACKAGEBUILD) | 35 | job_type=BuildFarmJobType.PACKAGEBUILD) |
510 | 36 | 36 | ||
511 | 37 | def test_has_concrete_build_farm_job(self): | ||
512 | 38 | # This temporary property returns true if the instance | ||
513 | 39 | # corresponds to a concrete database record, even if | ||
514 | 40 | # db updates have not yet been flushed, and false | ||
515 | 41 | # otherwise. | ||
516 | 42 | concrete_build_farm_job = self.makeBuildFarmJob() | ||
517 | 43 | self.failUnless(concrete_build_farm_job.has_concrete_build_farm_job) | ||
518 | 44 | |||
519 | 45 | mem_build_farm_job = BuildFarmJob( | ||
520 | 46 | job_type=BuildFarmJobType.PACKAGEBUILD) | ||
521 | 47 | self.failIf(mem_build_farm_job.has_concrete_build_farm_job) | ||
522 | 48 | |||
523 | 49 | def test_providesInterface(self): | 37 | def test_providesInterface(self): |
524 | 50 | # BuildFarmJob provides IBuildFarmJob | 38 | # BuildFarmJob provides IBuildFarmJob |
525 | 51 | self.assertProvides(self.build_farm_job, IBuildFarmJob) | 39 | self.assertProvides(self.build_farm_job, IBuildFarmJob) |
526 | 52 | 40 | ||
527 | === modified file 'lib/lp/code/model/sourcepackagerecipebuild.py' | |||
528 | --- lib/lp/code/model/sourcepackagerecipebuild.py 2010-05-05 15:48:49 +0000 | |||
529 | +++ lib/lp/code/model/sourcepackagerecipebuild.py 2010-05-05 15:48:52 +0000 | |||
530 | @@ -27,8 +27,7 @@ | |||
531 | 27 | from lp.buildmaster.interfaces.buildfarmjob import BuildFarmJobType | 27 | from lp.buildmaster.interfaces.buildfarmjob import BuildFarmJobType |
532 | 28 | from lp.buildmaster.model.buildbase import BuildBase | 28 | from lp.buildmaster.model.buildbase import BuildBase |
533 | 29 | from lp.buildmaster.model.buildqueue import BuildQueue | 29 | from lp.buildmaster.model.buildqueue import BuildQueue |
536 | 30 | from lp.buildmaster.model.buildfarmjob import BuildFarmJobDerived | 30 | from lp.buildmaster.model.buildfarmjob import BuildFarmJobOldDerived |
535 | 31 | from lp.buildmaster.model.packagebuild import PackageBuild | ||
537 | 32 | from lp.code.interfaces.sourcepackagerecipebuild import ( | 31 | from lp.code.interfaces.sourcepackagerecipebuild import ( |
538 | 33 | ISourcePackageRecipeBuildJob, ISourcePackageRecipeBuildJobSource, | 32 | ISourcePackageRecipeBuildJob, ISourcePackageRecipeBuildJobSource, |
539 | 34 | ISourcePackageRecipeBuild, ISourcePackageRecipeBuildSource) | 33 | ISourcePackageRecipeBuild, ISourcePackageRecipeBuildSource) |
540 | @@ -37,6 +36,7 @@ | |||
541 | 37 | from lp.soyuz.adapters.archivedependencies import ( | 36 | from lp.soyuz.adapters.archivedependencies import ( |
542 | 38 | default_component_dependency_name,) | 37 | default_component_dependency_name,) |
543 | 39 | from lp.soyuz.interfaces.component import IComponentSet | 38 | from lp.soyuz.interfaces.component import IComponentSet |
544 | 39 | from lp.soyuz.model.buildfarmbuildjob import BuildFarmBuildJob | ||
545 | 40 | from lp.soyuz.model.sourcepackagerelease import SourcePackageRelease | 40 | from lp.soyuz.model.sourcepackagerelease import SourcePackageRelease |
546 | 41 | 41 | ||
547 | 42 | 42 | ||
548 | @@ -199,7 +199,7 @@ | |||
549 | 199 | return | 199 | return |
550 | 200 | 200 | ||
551 | 201 | 201 | ||
553 | 202 | class SourcePackageRecipeBuildJob(BuildFarmJobDerived, Storm): | 202 | class SourcePackageRecipeBuildJob(BuildFarmJobOldDerived, Storm): |
554 | 203 | classProvides(ISourcePackageRecipeBuildJobSource) | 203 | classProvides(ISourcePackageRecipeBuildJobSource) |
555 | 204 | implements(ISourcePackageRecipeBuildJob) | 204 | implements(ISourcePackageRecipeBuildJob) |
556 | 205 | 205 | ||
557 | @@ -226,7 +226,7 @@ | |||
558 | 226 | """Setup the IBuildFarmJob delegate. | 226 | """Setup the IBuildFarmJob delegate. |
559 | 227 | 227 | ||
560 | 228 | We override this to provide a delegate specific to package builds.""" | 228 | We override this to provide a delegate specific to package builds.""" |
562 | 229 | self.build_farm_job = PackageBuild(self.build) | 229 | self.build_farm_job = BuildFarmBuildJob(self.build) |
563 | 230 | 230 | ||
564 | 231 | @classmethod | 231 | @classmethod |
565 | 232 | def new(cls, build, job): | 232 | def new(cls, build, job): |
566 | 233 | 233 | ||
567 | === modified file 'lib/lp/soyuz/interfaces/buildfarmbuildjob.py' | |||
568 | --- lib/lp/soyuz/interfaces/buildfarmbuildjob.py 2010-04-09 15:46:09 +0000 | |||
569 | +++ lib/lp/soyuz/interfaces/buildfarmbuildjob.py 2010-05-05 15:48:52 +0000 | |||
570 | @@ -10,11 +10,11 @@ | |||
571 | 10 | 10 | ||
572 | 11 | from canonical.launchpad import _ | 11 | from canonical.launchpad import _ |
573 | 12 | from lazr.restful.fields import Reference | 12 | from lazr.restful.fields import Reference |
575 | 13 | from lp.buildmaster.interfaces.buildfarmjob import IBuildFarmJob | 13 | from lp.buildmaster.interfaces.buildfarmjob import IBuildFarmJobOld |
576 | 14 | from lp.soyuz.interfaces.binarypackagebuild import IBinaryPackageBuild | 14 | from lp.soyuz.interfaces.binarypackagebuild import IBinaryPackageBuild |
577 | 15 | 15 | ||
578 | 16 | 16 | ||
580 | 17 | class IBuildFarmBuildJob(IBuildFarmJob): | 17 | class IBuildFarmBuildJob(IBuildFarmJobOld): |
581 | 18 | """An `IBuildFarmJob` with an `IBuild` reference.""" | 18 | """An `IBuildFarmJob` with an `IBuild` reference.""" |
582 | 19 | build = Reference( | 19 | build = Reference( |
583 | 20 | IBinaryPackageBuild, title=_("Build"), required=True, readonly=True, | 20 | IBinaryPackageBuild, title=_("Build"), required=True, readonly=True, |
584 | 21 | 21 | ||
585 | === modified file 'lib/lp/soyuz/model/buildpackagejob.py' | |||
586 | --- lib/lp/soyuz/model/buildpackagejob.py 2010-05-05 15:48:49 +0000 | |||
587 | +++ lib/lp/soyuz/model/buildpackagejob.py 2010-05-05 15:48:52 +0000 | |||
588 | @@ -18,17 +18,17 @@ | |||
589 | 18 | from canonical.database.sqlbase import sqlvalues | 18 | from canonical.database.sqlbase import sqlvalues |
590 | 19 | 19 | ||
591 | 20 | from lp.buildmaster.interfaces.buildbase import BuildStatus | 20 | from lp.buildmaster.interfaces.buildbase import BuildStatus |
594 | 21 | from lp.buildmaster.model.buildfarmjob import BuildFarmJobDerived | 21 | from lp.buildmaster.model.buildfarmjob import BuildFarmJobOldDerived |
593 | 22 | from lp.buildmaster.model.packagebuild import PackageBuild | ||
595 | 23 | from lp.registry.interfaces.sourcepackage import SourcePackageUrgency | 22 | from lp.registry.interfaces.sourcepackage import SourcePackageUrgency |
596 | 24 | from lp.registry.interfaces.pocket import PackagePublishingPocket | 23 | from lp.registry.interfaces.pocket import PackagePublishingPocket |
597 | 25 | from lp.soyuz.interfaces.archive import ArchivePurpose | 24 | from lp.soyuz.interfaces.archive import ArchivePurpose |
598 | 26 | from lp.soyuz.interfaces.binarypackagebuild import IBinaryPackageBuildSet | 25 | from lp.soyuz.interfaces.binarypackagebuild import IBinaryPackageBuildSet |
599 | 27 | from lp.soyuz.interfaces.buildpackagejob import IBuildPackageJob | 26 | from lp.soyuz.interfaces.buildpackagejob import IBuildPackageJob |
600 | 28 | from lp.soyuz.interfaces.publishing import PackagePublishingStatus | 27 | from lp.soyuz.interfaces.publishing import PackagePublishingStatus |
604 | 29 | 28 | from lp.soyuz.model.buildfarmbuildjob import BuildFarmBuildJob | |
605 | 30 | 29 | ||
606 | 31 | class BuildPackageJob(BuildFarmJobDerived, Storm): | 30 | |
607 | 31 | class BuildPackageJob(BuildFarmJobOldDerived, Storm): | ||
608 | 32 | """See `IBuildPackageJob`.""" | 32 | """See `IBuildPackageJob`.""" |
609 | 33 | implements(IBuildPackageJob) | 33 | implements(IBuildPackageJob) |
610 | 34 | 34 | ||
611 | @@ -49,7 +49,7 @@ | |||
612 | 49 | """Setup the IBuildFarmJob delegate. | 49 | """Setup the IBuildFarmJob delegate. |
613 | 50 | 50 | ||
614 | 51 | We override this to provide a delegate specific to package builds.""" | 51 | We override this to provide a delegate specific to package builds.""" |
616 | 52 | self.build_farm_job = PackageBuild(self.build) | 52 | self.build_farm_job = BuildFarmBuildJob(self.build) |
617 | 53 | 53 | ||
618 | 54 | def score(self): | 54 | def score(self): |
619 | 55 | """See `IBuildPackageJob`.""" | 55 | """See `IBuildPackageJob`.""" |
620 | 56 | 56 | ||
621 | === modified file 'lib/lp/soyuz/tests/test_buildpackagejob.py' | |||
622 | --- lib/lp/soyuz/tests/test_buildpackagejob.py 2010-04-20 14:30:00 +0000 | |||
623 | +++ lib/lp/soyuz/tests/test_buildpackagejob.py 2010-05-05 15:48:52 +0000 | |||
624 | @@ -13,9 +13,9 @@ | |||
625 | 13 | 13 | ||
626 | 14 | from lp.buildmaster.interfaces.buildbase import BuildStatus | 14 | from lp.buildmaster.interfaces.buildbase import BuildStatus |
627 | 15 | from lp.buildmaster.interfaces.builder import IBuilderSet | 15 | from lp.buildmaster.interfaces.builder import IBuilderSet |
630 | 16 | from lp.buildmaster.interfaces.buildfarmjob import ( | 16 | from lp.buildmaster.interfaces.buildfarmjob import IBuildFarmJobDerived |
629 | 17 | IBuildFarmJob, IBuildFarmJobDerived) | ||
631 | 18 | from lp.soyuz.interfaces.archive import ArchivePurpose | 17 | from lp.soyuz.interfaces.archive import ArchivePurpose |
632 | 18 | from lp.soyuz.interfaces.buildfarmbuildjob import IBuildFarmBuildJob | ||
633 | 19 | from lp.soyuz.interfaces.buildpackagejob import IBuildPackageJob | 19 | from lp.soyuz.interfaces.buildpackagejob import IBuildPackageJob |
634 | 20 | from lp.soyuz.interfaces.publishing import PackagePublishingStatus | 20 | from lp.soyuz.interfaces.publishing import PackagePublishingStatus |
635 | 21 | from lp.soyuz.model.binarypackagebuild import BinaryPackageBuild | 21 | from lp.soyuz.model.binarypackagebuild import BinaryPackageBuild |
636 | @@ -234,7 +234,7 @@ | |||
637 | 234 | build, bq = find_job(self, 'gcc', '386') | 234 | build, bq = find_job(self, 'gcc', '386') |
638 | 235 | build_farm_job = bq.specific_job | 235 | build_farm_job = bq.specific_job |
639 | 236 | self.assertProvides(build_farm_job, IBuildPackageJob) | 236 | self.assertProvides(build_farm_job, IBuildPackageJob) |
641 | 237 | self.assertProvides(build_farm_job, IBuildFarmJob) | 237 | self.assertProvides(build_farm_job, IBuildFarmBuildJob) |
642 | 238 | self.assertProvides(build_farm_job, IBuildFarmJobDerived) | 238 | self.assertProvides(build_farm_job, IBuildFarmJobDerived) |
643 | 239 | 239 | ||
644 | 240 | 240 | ||
645 | 241 | 241 | ||
646 | === modified file 'lib/lp/translations/model/translationtemplatesbuildjob.py' | |||
647 | --- lib/lp/translations/model/translationtemplatesbuildjob.py 2010-05-05 15:48:49 +0000 | |||
648 | +++ lib/lp/translations/model/translationtemplatesbuildjob.py 2010-05-05 15:48:52 +0000 | |||
649 | @@ -23,7 +23,7 @@ | |||
650 | 23 | from lp.buildmaster.interfaces.buildfarmjob import BuildFarmJobType | 23 | from lp.buildmaster.interfaces.buildfarmjob import BuildFarmJobType |
651 | 24 | from lp.buildmaster.interfaces.buildqueue import IBuildQueueSet | 24 | from lp.buildmaster.interfaces.buildqueue import IBuildQueueSet |
652 | 25 | from lp.buildmaster.model.buildfarmjob import ( | 25 | from lp.buildmaster.model.buildfarmjob import ( |
654 | 26 | BuildFarmJob, BuildFarmJobDerived) | 26 | BuildFarmJobOld, BuildFarmJobOldDerived) |
655 | 27 | from lp.buildmaster.model.buildqueue import BuildQueue | 27 | from lp.buildmaster.model.buildqueue import BuildQueue |
656 | 28 | from lp.code.interfaces.branchjob import IRosettaUploadJobSource | 28 | from lp.code.interfaces.branchjob import IRosettaUploadJobSource |
657 | 29 | from lp.buildmaster.interfaces.buildfarmbranchjob import IBuildFarmBranchJob | 29 | from lp.buildmaster.interfaces.buildfarmbranchjob import IBuildFarmBranchJob |
658 | @@ -33,7 +33,7 @@ | |||
659 | 33 | from lp.translations.pottery.detect_intltool import is_intltool_structure | 33 | from lp.translations.pottery.detect_intltool import is_intltool_structure |
660 | 34 | 34 | ||
661 | 35 | 35 | ||
663 | 36 | class TranslationTemplatesBuildJob(BuildFarmJobDerived, BranchJobDerived): | 36 | class TranslationTemplatesBuildJob(BuildFarmJobOldDerived, BranchJobDerived): |
664 | 37 | """An `IBuildFarmJob` implementation that generates templates. | 37 | """An `IBuildFarmJob` implementation that generates templates. |
665 | 38 | 38 | ||
666 | 39 | Implementation-wise, this is actually a `BranchJob`. | 39 | Implementation-wise, this is actually a `BranchJob`. |
667 | @@ -55,8 +55,7 @@ | |||
668 | 55 | 55 | ||
669 | 56 | We override this to provide a non-database delegate that simply | 56 | We override this to provide a non-database delegate that simply |
670 | 57 | provides required functionality to the queue system.""" | 57 | provides required functionality to the queue system.""" |
673 | 58 | self.build_farm_job = BuildFarmJob( | 58 | self.build_farm_job = BuildFarmJobOld() |
672 | 59 | job_type=BuildFarmJobType.TRANSLATIONTEMPLATESBUILD) | ||
674 | 60 | 59 | ||
675 | 61 | def score(self): | 60 | def score(self): |
676 | 62 | """See `IBuildFarmJob`.""" | 61 | """See `IBuildFarmJob`.""" |
677 | 63 | 62 | ||
678 | === modified file 'lib/lp/translations/tests/test_translationtemplatesbuildjob.py' | |||
679 | --- lib/lp/translations/tests/test_translationtemplatesbuildjob.py 2010-04-30 03:10:17 +0000 | |||
680 | +++ lib/lp/translations/tests/test_translationtemplatesbuildjob.py 2010-05-05 15:48:52 +0000 | |||
681 | @@ -9,7 +9,6 @@ | |||
682 | 9 | from zope.event import notify | 9 | from zope.event import notify |
683 | 10 | from zope.security.proxy import removeSecurityProxy | 10 | from zope.security.proxy import removeSecurityProxy |
684 | 11 | 11 | ||
685 | 12 | from sqlobject import SQLObjectNotFound | ||
686 | 13 | from storm.store import Store | 12 | from storm.store import Store |
687 | 14 | 13 | ||
688 | 15 | from canonical.launchpad.webapp.testing import verifyObject | 14 | from canonical.launchpad.webapp.testing import verifyObject |
689 | @@ -20,7 +19,7 @@ | |||
690 | 20 | from lp.testing import TestCaseWithFactory | 19 | from lp.testing import TestCaseWithFactory |
691 | 21 | 20 | ||
692 | 22 | from lp.buildmaster.interfaces.buildfarmjob import ( | 21 | from lp.buildmaster.interfaces.buildfarmjob import ( |
694 | 23 | IBuildFarmJob, IBuildFarmJobDerived) | 22 | IBuildFarmJobOld, IBuildFarmJobDerived) |
695 | 24 | from lp.buildmaster.interfaces.buildqueue import IBuildQueueSet | 23 | from lp.buildmaster.interfaces.buildqueue import IBuildQueueSet |
696 | 25 | from lp.buildmaster.model.buildqueue import BuildQueue | 24 | from lp.buildmaster.model.buildqueue import BuildQueue |
697 | 26 | from lp.code.interfaces.branch import IBranchSet | 25 | from lp.code.interfaces.branch import IBranchSet |
698 | @@ -54,11 +53,11 @@ | |||
699 | 54 | self.specific_job = self.jobset.create(self.branch) | 53 | self.specific_job = self.jobset.create(self.branch) |
700 | 55 | 54 | ||
701 | 56 | def test_new_TranslationTemplatesBuildJob(self): | 55 | def test_new_TranslationTemplatesBuildJob(self): |
703 | 57 | # TranslationTemplateBuildJob implements IBuildFarmJob, | 56 | # TranslationTemplateBuildJob implements IBuildFarmJobOld, |
704 | 58 | # IBuildFarmJobDerived, and IBranchJob. | 57 | # IBuildFarmJobDerived, and IBranchJob. |
705 | 59 | verifyObject(IBranchJob, self.specific_job) | 58 | verifyObject(IBranchJob, self.specific_job) |
706 | 60 | verifyObject(IBuildFarmJobDerived, self.specific_job) | 59 | verifyObject(IBuildFarmJobDerived, self.specific_job) |
708 | 61 | verifyObject(IBuildFarmJob, self.specific_job) | 60 | verifyObject(IBuildFarmJobOld, self.specific_job) |
709 | 62 | 61 | ||
710 | 63 | # Each of these jobs knows the branch it will operate on. | 62 | # Each of these jobs knows the branch it will operate on. |
711 | 64 | self.assertEqual(self.branch, self.specific_job.branch) | 63 | self.assertEqual(self.branch, self.specific_job.branch) |