Code review comment for lp:~michael.nelson/launchpad/487009-db-more-soyuz-extraction

= Summary =

This branch continues on from the prerequisite at:

https://code.edge.launchpad.net/~michael.nelson/launchpad/487009-db-generalise-ibuilder-1b/+merge/15477

and extracts most of the remaining soyuz-specific binary build logic from IBuilder and into the custom BinaryPackageBuildBehavior to which IBuilder delegates for binary builds, in particular leaving the IBuilder.startBuild() method looking like:

http://pastebin.ubuntu.com/332947/

with verifyBuildRequest() and dispatchBuildToSlave() now being delegated to the current build behavior.

I will have one further branch that:
 * extracts IBuilder.getBuildRecords()
 * extracts IBuilder.slaveStatus()
 * adds documentation for the IBuildFarmJobBehavior with examples for adding further behaviors.

== Pre-implementation notes ==

See the pre-implementation notes on bug 487009.

== Implementation details ==

== Tests ==

bin/test -vv -t doc/builder.txt -t doc/buildd-dispatching.txt

== Demo and Q/A ==

We will need to Q/A this on dogfood.

= Launchpad lint =

lib/lp/soyuz/model/builder.py
    23: [F0401] Unable to import 'lazr.delegates' (No module named delegates)