Code review comment for lp:~michael.nelson/launchpad/409187-trivial-ui-fixes-for-p3a-access

= Summary =

This branch deals with a number of UI issues related to private PPA
subscriptions. Please refer tot bug 409187 for the details.

== Proposed fix ==

== Pre-implementation notes ==

All before-after screenshots and notes are on bug 409187, as well as a
screencast of the new interaction.

== Implementation details ==

I have not added a windmill test for the new interaction yet, but will
do soon. If I need to do it now I will, but otherwise I'll focus on
blueprint templates for the rest of today.

== Tests ==

bin/test -vv -t archivesubscription-views.txt -t
TestArchiveSubscriptionBreadcrumb -t stories/ppa

== Demo and Q/A ==

For screenshots/casts, see bug 409187.

To demo locally, run the following in a harness:

ppa = getUtility(IPersonSet).getByName('cprov').archive
ppa.private = True
ppa.buildd_secret = 'blah'
import transaction;transaction.commit()

and then navigate to:
https://launchpad.dev/~cprov/+archive/ppa

Click on 'Manage access', add yourself (Celso) and others. Try editing.

Next go to:
https://launchpad.dev/~cprov and click on 'View your private ppa
subscriptions'. Click on the subscription listed there etc.

For QA, the soyuz-team ppa can be used.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/templates/person-archive-subscriptions.pt
  lib/lp/soyuz/templates/archive-subscribers.pt
  lib/canonical/launchpad/pagetitles.py
  lib/lp/soyuz/templates/person-archive-subscription.pt
  lib/lp/soyuz/browser/tests/test_breadcrumbs.py
  lib/lp/soyuz/browser/tests/archivesubscription-views.txt
  lib/lp/soyuz/interfaces/archivesubscriber.py
  lib/lp/soyuz/configure.zcml
  lib/lp/soyuz/stories/ppa/xx-private-ppa-subscription-stories.txt
  lib/canonical/launchpad/icing/style-3-0.css
  lib/lp/soyuz/browser/archivesubscription.py
  lib/lp/soyuz/browser/configure.zcml
  lib/lp/soyuz/templates/archive-subscriber-edit.pt

== Pylint notices ==

lib/lp/soyuz/interfaces/archivesubscriber.py
    20: [F0401] Unable to import 'lazr.enum' (No module named enum)
    26: [F0401] Unable to import 'lazr.restful.declarations' (No module
named restful)
    27: [F0401] Unable to import 'lazr.restful.fields' (No module named
restful)

--
Michael