Code review comment for lp:~michael.nelson/juju-core/1208505-status-env

The attempt to merge lp:~michael.nelson/juju-core/1208505-status-env into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core/agent 1.718s
ok launchpad.net/juju-core/agent/tools 20.424s
ok launchpad.net/juju-core/bzr 6.304s
ok launchpad.net/juju-core/cert 2.364s
ok launchpad.net/juju-core/charm 0.542s
? launchpad.net/juju-core/charm/hooks [no test files]
ok launchpad.net/juju-core/cloudinit 0.019s
ok launchpad.net/juju-core/cmd 0.218s
? launchpad.net/juju-core/cmd/builddb [no test files]
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 103.027s
ok launchpad.net/juju-core/cmd/jujud 51.236s
ok launchpad.net/juju-core/cmd/plugins/juju-metadata 0.812s
ok launchpad.net/juju-core/constraints 0.026s
ok launchpad.net/juju-core/container/lxc 0.315s
? launchpad.net/juju-core/container/lxc/mock [no test files]
ok launchpad.net/juju-core/downloader 5.262s
ok launchpad.net/juju-core/environs 1.250s
? launchpad.net/juju-core/environs/all [no test files]
ok launchpad.net/juju-core/environs/azure 3.545s
ok launchpad.net/juju-core/environs/cloudinit 0.515s
ok launchpad.net/juju-core/environs/config 0.743s
ok launchpad.net/juju-core/environs/dummy 16.244s
ok launchpad.net/juju-core/environs/ec2 182.018s
ok launchpad.net/juju-core/environs/imagemetadata 0.250s
ok launchpad.net/juju-core/environs/instances 0.292s
ok launchpad.net/juju-core/environs/jujutest 0.263s
ok launchpad.net/juju-core/environs/local 1.229s
? launchpad.net/juju-core/environs/local/storage [no test files]
ok launchpad.net/juju-core/environs/localstorage 0.246s
ok launchpad.net/juju-core/environs/maas 2.125s
ok launchpad.net/juju-core/environs/openstack 3.881s
? launchpad.net/juju-core/environs/provider [no test files]
ok launchpad.net/juju-core/environs/sync 0.310s
ok launchpad.net/juju-core/environs/testing 0.016s
? launchpad.net/juju-core/errors [no test files]
ok launchpad.net/juju-core/instance 0.025s
ok launchpad.net/juju-core/juju 11.916s
ok launchpad.net/juju-core/juju/osenv 0.227s
? launchpad.net/juju-core/juju/testing [no test files]
ok launchpad.net/juju-core/log 0.019s
ok launchpad.net/juju-core/log/syslog 0.037s
ok launchpad.net/juju-core/names 0.033s
ok launchpad.net/juju-core/rpc 0.280s
ok launchpad.net/juju-core/rpc/jsoncodec 0.196s
ok launchpad.net/juju-core/schema 0.037s

----------------------------------------------------------------------
FAIL: machine_test.go:558: MachineSuite.TestWatchMachine

[LOG] 95.72981 INFO juju state: opening state; mongo addresses: ["localhost:38714"]; entity ""
[LOG] 95.73443 INFO juju state: connection established
[LOG] 95.75393 INFO juju state: initializing environment
machine_test.go:594:
    testing.NewNotifyWatcherC(c, s.State, w).AssertOneChange()
testing/watcher.go:85:
    c.Fatalf("watcher sent unexpected change: (_, %v)", ok)
... Error: watcher sent unexpected change: (_, true)

OOPS: 309 passed, 1 FAILED
--- FAIL: TestPackage (67.55 seconds)
FAIL
FAIL launchpad.net/juju-core/state 67.856s
? launchpad.net/juju-core/state/api [no test files]
ok launchpad.net/juju-core/state/api/agent 1.775s
? launchpad.net/juju-core/state/api/common [no test files]
ok launchpad.net/juju-core/state/api/deployer 5.163s
ok launchpad.net/juju-core/state/api/machiner 2.492s
ok launchpad.net/juju-core/state/api/params 0.038s
ok launchpad.net/juju-core/state/api/upgrader 2.996s
ok launchpad.net/juju-core/state/api/watcher 2.847s
ok launchpad.net/juju-core/state/apiserver 2.527s
ok launchpad.net/juju-core/state/apiserver/agent 2.275s
ok launchpad.net/juju-core/state/apiserver/client 12.002s
ok launchpad.net/juju-core/state/apiserver/common 0.047s
ok launchpad.net/juju-core/state/apiserver/deployer 3.825s
ok launchpad.net/juju-core/state/apiserver/machine 3.299s
? launchpad.net/juju-core/state/apiserver/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/upgrader 3.451s
ok launchpad.net/juju-core/state/multiwatcher 0.898s
ok launchpad.net/juju-core/state/presence 6.416s
ok launchpad.net/juju-core/state/statecmd 6.303s
? launchpad.net/juju-core/state/testing [no test files]
ok launchpad.net/juju-core/state/watcher 5.396s
ok launchpad.net/juju-core/store 18.116s
ok launchpad.net/juju-core/testing 1.324s
ok launchpad.net/juju-core/testing/checkers 0.016s
ok launchpad.net/juju-core/thirdparty/pbkdf2 0.137s
ok launchpad.net/juju-core/upstart 0.121s
ok launchpad.net/juju-core/utils 0.990s
ok launchpad.net/juju-core/utils/fslock 0.971s
ok launchpad.net/juju-core/utils/set 0.022s
ok launchpad.net/juju-core/version 0.060s
ok launchpad.net/juju-core/worker 1.442s
ok launchpad.net/juju-core/worker/cleaner 1.094s
ok launchpad.net/juju-core/worker/deployer 3.174s
ok launchpad.net/juju-core/worker/firewaller 10.144s
ok launchpad.net/juju-core/worker/machiner 7.060s
ok launchpad.net/juju-core/worker/minunitsworker 1.209s
ok launchpad.net/juju-core/worker/provisioner 16.680s
ok launchpad.net/juju-core/worker/resumer 1.450s
ok launchpad.net/juju-core/worker/uniter 115.426s
ok launchpad.net/juju-core/worker/uniter/charm 2.321s
ok launchpad.net/juju-core/worker/uniter/debug 2.123s
ok launchpad.net/juju-core/worker/uniter/hook 0.014s
ok launchpad.net/juju-core/worker/uniter/jujuc 0.492s
ok launchpad.net/juju-core/worker/uniter/relation 1.370s
ok launchpad.net/juju-core/worker/upgrader 2.401s

warning: building out-of-date packages:
 launchpad.net/goamz/ec2/ec2test
 launchpad.net/goamz/s3/s3test
 launchpad.net/goose/testservices/hook
 launchpad.net/goose/testservices/identityservice
 launchpad.net/goose/testservices
 launchpad.net/goose/testservices/novaservice
 launchpad.net/goose/testservices/swiftservice
 launchpad.net/goose/testservices/openstackservice
installing these packages with 'go test -i ./...' will speed future tests.